Commit Graph

1463 Commits

Author SHA1 Message Date
Matt Bierner
9d41c706c6 Allow manually restarting TS Server even if it has crashed too many times
Currently if the server crashes too many times, the user has to restart VS Code. It's possible the user could fix something (such as a bad plugin) and then run this command to just restart the server without needing to restart the entire editor
2022-03-08 18:48:48 -08:00
Matt Bierner
886ab06860 Try to have more explicit error when we don't have a server
Fixes #143032

This change removes a call that would automatically restart the TS server when invoking a command. Instead we now return a `NoServer` response

When this happens, the server still should be restarted. This change stops us from logging a large number of errors when we get into this state where the server has crashed too many times and we no longer want to automatically restart it
2022-03-08 18:48:48 -08:00
Matt Bierner
eb6050d8a8 Preserve path item details for JS/TS completions
Fixes #144455
2022-03-08 14:33:26 -08:00
Ondrej Medek
529cc9c859 fix markdownDescription for javascript.suggest.jsdoc.generateReturns (#144486) 2022-03-07 17:12:55 -08:00
Matt Bierner
5c452f8973 Use [].flat() 2022-03-03 15:03:33 -08:00
Matt Bierner
1900abc88b while -> for 2022-03-01 16:39:41 -08:00
Matt Bierner
ea76090229 Remove support for old plugin based semantic token responses
We removed support for the plugin a few iterations ago so this branch should no longer be active
2022-03-01 16:38:37 -08:00
Matt Bierner
fb292d9a46 Cleanup semantic tokens provider
- Don't modify params
- mark public
- Use standard api version object
- remove extra disposable
- Don't use declare for const enums
2022-03-01 16:38:36 -08:00
Matt Bierner
e6d702383d Remove experimental protocol stubs 2022-03-01 16:38:36 -08:00
Matt Bierner
a068ebee8d Finalize markdownstring.baseUri
Fixes #142051
2022-03-01 15:48:53 -08:00
Matt Bierner
e04c70a676 Fix TS resolved paths when on vfs
For #136433

These paths always have to start with `/`
2022-02-28 17:27:43 -08:00
Matt Bierner
c662fe67bf Bump default target for jsconfig template 2022-02-28 15:16:39 -08:00
Matt Bierner
062b82c1bc Use .test instead of .match 2022-02-28 14:27:47 -08:00
Matt Bierner
1d77856203 Use ?.forEach instead of ( || []).forEach 2022-02-28 13:52:59 -08:00
Matt Bierner
6f63577e80 Remove unused event 2022-02-28 13:46:52 -08:00
Matt Bierner
2fc747419d use ?. 2022-02-28 13:44:48 -08:00
Matt Bierner
cf898ff7d1 null -> undefined 2022-02-28 13:43:18 -08:00
Matt Bierner
70dd24e9bd Remove extra check
This should not be nullable
2022-02-28 13:43:18 -08:00
Matt Bierner
d218b48067 Always use nameSpan for code lenses
Fixes #143648

The nameSpan property has existed for something like years or so, so it should be safe to use. There's currently not a good way to request the reference count of an anon function and I don't think this is actually useful to show since the ref count should always be 1 for these
2022-02-28 13:43:16 -08:00
Matt Bierner
ee9c87ccca Clean up logged messages 2022-02-24 14:28:27 -08:00
Matt Bierner
2a72cf7070 Restore 'follow link' text on tsconfig links
For #141112
2022-02-24 14:02:38 -08:00
Robo
df645f1450 chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Matt Bierner
932976b8d2 Fix return type typing 2022-02-22 16:22:55 -08:00
Matt Bierner
ad0311a25a Improve quote style setting display
Follow up on #143164
2022-02-16 12:13:45 -08:00
Matt Bierner
1f5f486ccb Add note about quote style setting to jsxAttributeCompletionStyle
For #143164
2022-02-16 12:13:45 -08:00
Matt Bierner
3ecc99a3f5 Format switch using braces 2022-02-09 14:49:13 -08:00
Matt Bierner
ca6c806af5 Adopt busy for TS intellisense status
For #141269
2022-02-09 14:49:13 -08:00
Johannes Rieken
b7955eac38 finalize inlay hints provider API, https://github.com/microsoft/vscode/issues/16221 2022-02-09 15:32:46 +01:00
Matt Bierner
36ee187589 Surface TS code action desc in completions
Fixes #141591
2022-02-08 17:11:48 -08:00
Robo
01df559c18 chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Johannes Rieken
17ed7bf82c finalize LanguageStatusItem API, https://github.com/microsoft/vscode/issues/129037 2022-02-08 18:50:46 +01:00
Johannes Rieken
765d2ef252 add doc for padding-left/right, add doc for inlay hint kind but also remove InlayHintKind#other, https://github.com/microsoft/vscode/issues/16221 2022-02-08 18:37:43 +01:00
Johannes Rieken
627d46551d support double click gesture on inlay hints, API polish, https://github.com/microsoft/vscode/issues/16221 2022-02-05 14:25:37 +01:00
Matt Bierner
df09257f2e Make sure we pass along windows style paths to pluginProbeLocations 2022-02-03 17:10:43 -08:00
Matt Bierner
2b92835853 Move js/ts language configs to json file
Fixes #125748
2022-02-03 11:38:09 -08:00
Raymond Zhao
9b75370b4a Modify click-here link on type init fail msg
Ref #140059
2022-02-03 10:52:52 -08:00
Matt Bierner
571a3c3a55 Don't try tacking on a tsconfig.json if the file already has a json ext 2022-02-03 09:59:10 -08:00
Matt Bierner
92616196f8 💄 2022-02-03 09:59:10 -08:00
Matt Bierner
94a3d96861 Fix missing semicolons 2022-02-03 09:59:10 -08:00
Matt Bierner
820c2b3a12 Update yarn lock 2022-02-03 09:37:29 -08:00
Vitaly
c134702cc4 Resolve correct link path for tsconfig.extends (#141062)
* fix(ts-features-extension): resolve correct path for `extends` of tsconfig
fixes #131643

* always provide link. add command to resolve the link path on click

* cleanup
just make the code cleaner

* revert `yarn.lock` changes

* pretending eslint

* use `vscode.open`

* don't add `.json` to path if it's already here
this change better conforms the TS resolving algorithm (see the reference)

* style: move `resolveNodeModulesPath` to top level

* don't show falsy errors on absolute paths

* improve resolveNodeModulesPath impl
- fixed a bug with infinite loop
- check for module existence once per level
2022-02-03 09:37:00 -08:00
Matt Bierner
69896100ed Add MarkdownString.baseUri proposal (#142055)
For #142051
2022-02-03 08:51:49 -08:00
Andrew Jones
9dc211a499 fix indentation (#141997)
* fix indentation

* add tests

* make regex valid
2022-02-02 19:51:57 -08:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Matt Bierner
90b50dc7e2 Use ?. in a few more places 2022-02-01 13:59:12 -08:00
Martin Aeschlimann
d971263085 remove the last typescript-vscode-sh-plugin references 2022-02-01 17:38:36 +01:00
Matt Bierner
ce119308e8 Allow using language override for more js/ts settings
Fixes #141912
2022-01-31 18:03:51 -08:00
Matt Bierner
c2af7753f6 Mark some JS/TS prefs as language-overridable
Fixes #139864
2022-01-31 17:48:45 -08:00
Matt Bierner
1ab6e6fd06 Pass in doc instead of doc uri 2022-01-31 17:41:03 -08:00
Matt Bierner
c33f53e1f2 Pass language desc around instead of modeid 2022-01-31 17:21:55 -08:00