Commit Graph

72 Commits

Author SHA1 Message Date
Johannes
43c31079ee manual fixing of prefer-const violations 2022-06-09 10:19:56 +02:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Megan Rogge
7c22caad55 Use I prefix for task interfaces (#151350) 2022-06-07 09:27:44 -07:00
Jason Williams
e19f09713b Enable globs on tasks otherwise fallback to default - fixes #88106 (#141230)
* use glob on tasks otherwise fallback to default

* add support for test commands also

* try to find one globbed task otherwise fallback to defaults

* - get relativePath (but fallback to absolute if outside of workspace)
- bring back json schema

* Refactor and reduce duplicate code

* remove glob, make isDefault a string or boolean

* update taskConfig

* - rebase
- type updates
- splitPerGroupType should check explicitly for true on isDefault
- hygiene check

* Remove task glob from API

* Task group DTO updates

* Make sure globs run ahead of default task if there's multiple globs matching

* Style and name changes

* More naming and code re-use

* Glob doesn't work when only 1 glob match

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-05-03 09:56:24 +02:00
Alex Ross
5bdfec8311 Dispose of all terminals before running task test
Fixes #142565
2022-02-09 14:06:09 +01:00
Alex Ross
b170ef3444 Fix no-async-promise-executor in task tests
Fixes #141993
2022-02-02 16:27:26 +01:00
Johannes Rieken
de1ae9e2cc update todo-tag for https://github.com/microsoft/vscode/issues/141993 2022-02-02 12:39:06 +01:00
Johannes Rieken
7ccb868835 make sure to use .eslintignore when running yarn eslint, this will ensure that cli failure and editor squiggles are always equal 2022-02-02 12:37:29 +01:00
Alex Ross
4d0b81edfb Fix task smoke test
Fixes #140110
2022-01-07 15:07:33 +01:00
Daniel Imms
79ed98edc9 Skip flaky tests
Part of #140110
2022-01-04 09:40:49 -08:00
Alex Ross
61cd6437a0 Fix timing bug for back-to-back CustomExecution tasks
Fixes #131926
2021-11-02 14:01:34 +01:00
Alex Ross
84a8a567e8 Move TaskGroup isDefault api out of proposed
Part of #79188
2021-08-16 15:07:07 +02:00
Matt Bierner
ab8e743520 Organize imports in ext tests 2021-08-11 16:55:51 -07:00
Alex Ross
3d5b13265d Re-add task default API with fixes (#129397)
Part of #79188
2021-07-26 15:30:46 +02:00
Alex Ross
cbde02b886 Failing test: Revert "Add isDefault to TaskGroup API (#128596)"
This reverts commit 48975dc080.
2021-07-16 10:16:16 +02:00
headerjson
48975dc080 Add isDefault to TaskGroup API (#128596)
* first pass at adding api

(cherry picked from commit 8a583c52ee)

* add task2 remaining changes

* remove unnecessary changes

* modify tasks.json directly for test

* reset tasks in test

* Fix compilation errors

Co-authored-by: Alex Ross <alros@microsoft.com>
2021-07-15 15:42:12 +02:00
Alex Ross
876dd2782a Don't allow multiple tasks runs to start at once
Fixes #118238
2021-04-23 17:03:31 +02:00
Daniel Imms
4c76edff2b Revert "skip failing terminal tests."
This reverts commit 2d5f0e4953.
2021-03-31 05:07:32 -07:00
rebornix
2d5f0e4953 skip failing terminal tests. 2021-03-30 18:26:57 -07:00
Daniel Imms
f02e4853c3 Change rendererType to gpuAcceleration
Fixes #106202
2021-03-29 14:15:45 -07:00
Daniel Imms
2d536914ea Await task config updates 2021-03-16 07:20:49 -07:00
Daniel Imms
e8f5186722 Improve task test layout 2021-03-16 06:29:44 -07:00
Daniel Imms
1b9a61662a Regression test for #118256
Part of #118256
2021-03-16 06:28:16 -07:00
Daniel Imms
09c3c2d3be Remove broken part of test 2021-03-08 17:43:35 -08:00
Daniel Imms
5fdbc82111 Re-enable task and term test 2021-03-08 17:07:14 -08:00
Daniel Imms
8fe29a7c41 Uncomment in test 2021-03-08 15:52:59 -08:00
Daniel Imms
30f4163184 Skip the failing test for remote only 2021-03-08 15:12:24 -08:00
Daniel Imms
221e20b374 Re-enable, add some more test logs 2021-03-08 11:44:37 -08:00
Daniel Imms
45c032da7a Skip the failing task test 2021-03-08 08:17:16 -08:00
Daniel Imms
4d3b158023 Disable terminal tests in remote again, fix settings for tasks 2021-03-08 05:54:43 -08:00
Daniel Imms
755fae50ab Bail out of create process if it's been disposed
This is likely the cause of several terminal test issues we've been seeing,
especially on remote. When process creation becomes async, the process
seems to hang around if the terminal was disposed during the process
creation.

Another thing to consider if env var relaunches messing with tests.
2021-03-05 17:47:39 -08:00
Daniel Imms
b15bbfa851 More test logs 2021-03-05 16:21:33 -08:00
Daniel Imms
7af259ab84 Add logs to test 2021-03-05 14:59:23 -08:00
Daniel Imms
88d9e2b46b Refactor second task test 2021-03-02 10:59:16 -08:00
Daniel Imms
f8c41a80b0 Refactor first task test 2021-03-02 10:59:15 -08:00
Daniel Imms
c8fc575275 Ignore terminal events not related to task test 2021-03-02 10:59:13 -08:00
Benjamin Pasero
be11cb2de0 disable failing test (#117446) 2021-03-02 10:10:36 +01:00
Johannes Rieken
46cf57b264 a bunch of failing tests 2021-02-01 12:01:32 +01:00
Matt Bierner
d1b49cd8b9 Adding more explicit typings for TS 4.1 new Promise logic 2020-09-16 11:58:01 -07:00
Alex Ross
0de8d51904 Finalize task detail API
Fixes #69785
2020-08-27 11:08:48 +02:00
Alex Ross
2344987359 Add task test back in 2020-07-31 10:15:05 +02:00
Alex Ross
ae245c9b1f Fix onDidStart and End task test 2020-07-30 16:19:22 +02:00
isidor
15ada625f2 skip moree tests 2020-07-30 16:11:05 +02:00
isidor
d7ed2f5382 skip more tests 2020-07-30 15:23:53 +02:00
Alex Ross
c8b5be4801 Add wait wait in tasks test for execute to return 2020-07-30 13:38:20 +02:00
Alex Ross
e39d21e318 Remove hack in terminal task system to delay disposal
This is no longer needed because #92868 is fixed

This reverts commit d6354443f4.
2020-07-30 11:59:18 +02:00
Matt Bierner
e0f0cc4bf2 Skip another failing test 2020-07-29 15:05:49 -07:00
Matt Bierner
55ad57fc2a Skipping failing test 2020-07-29 14:06:12 -07:00
Alex Ross
5e5fa3edde Tasks without a registered definition should run (#102696)
Fixes #102684
2020-07-16 14:42:02 +02:00
Alex Ross
a05390d952 Disable failing tasks test to get build 2020-07-16 10:45:17 +02:00