Commit Graph

224 Commits

Author SHA1 Message Date
Nikolai Vavilov
aaa778b5e2 Use 'r+' with truncation when saving existing files on Windows (#42899)
* Use 'r+' with truncation when saving existing files on Windows

Opening a file with 'w' flag removes its alternate data streams. To
prevent this, extend the logic used for hidden files to all existing
files.

Fixes: https://github.com/Microsoft/vscode/issues/6363

* adopt truncate for saving as admin
2018-08-20 18:55:12 +02:00
Martin Aeschlimann
1f1b778104 resource.isEqual / isEqualOrParent: use isIgnore default bahaviour 2018-08-20 12:10:08 +02:00
Martin Aeschlimann
8d9331a57c incorperate review comments 2018-08-13 12:09:34 +02:00
Martin Aeschlimann
8b8feed4ad polish cli args parsing 2018-08-09 17:54:54 +02:00
Martin Aeschlimann
50dba3707c Support file-uris as arguments 2018-07-30 15:07:08 +02:00
Sandeep Somavarapu
1ee90dc8d2 Fix findWindowOnWorkspaceOrFolderUri to accept URI and adopt 2018-07-19 12:55:30 +02:00
Sandeep Somavarapu
5a7da8c687 💄 2018-07-19 12:48:50 +02:00
Sandeep Somavarapu
bba73a471f Rename to SingleFolderIdentifier 2018-07-19 12:33:20 +02:00
Sandeep Somavarapu
fd7d83f663 Use URI instead of Path for folders 2018-07-18 21:49:52 +02:00
Benjamin Pasero
18b5d32140 fix #52583 2018-07-17 12:14:06 +02:00
Johannes Rieken
19f25e4801 add telemetry appender that writes to log (#53603)
* add log-telemetry-appender and wire it up in the shell

* enable log-only-telemetry in scripts/code.[sh|bat]

* Reduce noise, separate log file for telemetry

* Print telemetry events from shared process to corresponding log channel

* Telemetry events for cli go to the log file for cli

* Merge cli telemetry with all data with cli log

* Use LogAppender when running from source

* Skip check on isBuilt as the same is done in the shared process

* Telemetry events from main process go to corresponding log file

* Telemetry events from issue reporter go to corresponding log file

* Cleanup to reduce diff amount as I have OCD

* More cleanup

* Open telemetry log file via the Open Log File command

* Use regex to strip out common data

* Tests
2018-07-11 12:21:40 -07:00
Joao Moreno
ba7b1cb0d5 cleanup more promises
related to #53442
2018-07-02 16:49:11 +02:00
Sandeep Somavarapu
1624b81855 #45072 Add a prompt to update the extension 2018-07-02 15:52:51 +02:00
Sandeep Somavarapu
6bf20cc217 Merge pull request #45533 from oriash93/oriash93/45072
Support for updating extensions from CLI
2018-07-02 15:06:07 +02:00
Sandeep Somavarapu
4d93f9cc37 Fix #51145 2018-06-25 16:38:21 +02:00
Benjamin Pasero
cf88c4f0ae 💄 2018-06-18 16:53:25 +02:00
oriash93
876062c52f Handle all cases 2018-06-12 13:38:25 +03:00
oriash93
1912fcae3d fixed review notes 2018-06-11 23:16:49 +03:00
oriash93
268312889a Support for updating extensions from CLI 2018-06-11 23:00:17 +03:00
Ramya Rao
f7cc895901 Dont do async work on process.on('exit') (#51411)
* Dont do async work on process.on('exit') Fixes #47180

* Refactoring
2018-06-11 08:15:26 -07:00
Matt Bierner
82be8c8b01 Build with TS 2.7 (#45348)
* Pick up TS 2.7

* Fix formatter in build script

* Fix build error for ts 2.7

* Pick up new ts format and tslint versions

* Update lock

* use 2.7.2 for build

* Formatting
2018-03-08 16:58:32 -08:00
Benjamin Pasero
8d0228f52b jsdoc 💄 2018-03-07 14:26:21 +01:00
Benjamin Pasero
9fa1442003 debt - remove choice service in favour of dialog service 2018-03-07 12:23:40 +01:00
Christof Marti
6fe0c32698 Don't check parent folders for settings / settings folder (fixes #45121) 2018-03-06 10:44:53 +01:00
Benjamin Pasero
d674f7b7e1 fix #44980 2018-03-05 14:29:16 +01:00
Benjamin Pasero
8a2df5e021 notifications - extract choice/confirm service from message service 2018-02-19 08:11:32 +01:00
Peng Lyu
6729e2b7df --max-memory and fix test failture. 2018-02-13 15:12:07 -08:00
Peng Lyu
50a1deb9f6 Fix #42839. avoid ui freeze when file is larger than heap size limit. 2018-02-13 14:07:01 -08:00
Ramya Achutha Rao
b8b726b4a9 Remove unused net declaration 2018-02-01 16:03:07 -08:00
Matt Bierner
1872949236 Use args based confirmation for log upload instead of using stdin 2018-02-01 15:31:56 -08:00
Matt Bierner
d233df9a12 Use named pipe for stdio in upload logs
Fixes #42635
2018-02-01 14:22:28 -08:00
Matt Bierner
279c4d048a Forward stdin for loguploader
Fixes #42055
2018-01-26 00:08:15 -08:00
Joao Moreno
93d7d51eb7 fixes #42115 2018-01-25 16:40:44 +01:00
Sandeep Somavarapu
07d50ff62e Fix #39574 2018-01-23 20:31:07 +01:00
Joao Moreno
57e5c7147b fix opening urls as files 2018-01-10 16:38:12 +01:00
Daniel Imms
4fd1a5c3e6 progress 2018-01-09 13:03:58 -08:00
Joao Moreno
9914a95ddf buffer spdlog calls in main until singleton
fixes #41218
2018-01-09 15:55:10 +01:00
Benjamin Pasero
ec31203310 cli - remove stdin argument properly 2017-12-28 11:04:45 +01:00
Benjamin Pasero
549cda29da 💄 2017-12-20 16:57:40 +01:00
Benjamin Pasero
894dcea691 Require to use "-" when reading from stdin (#40424)
* Require to use "-" when reading from stdin

* cli - better help message

* more narrow error handling

* better data listener
2017-12-18 14:56:06 +01:00
Benjamin Pasero
3d9d00ff46 save as admin - handle windows hidden files 2017-12-14 16:17:24 +01:00
Benjamin Pasero
4e9cd88e37 save as admin - handle case for readonly files 2017-12-14 15:50:21 +01:00
Benjamin Pasero
0ef13b6d54 Allow to save files that need user elevation (fixes #1614) (#40107) 2017-12-12 16:03:25 +01:00
Joao Moreno
4ecad4714f fixes #39806 2017-12-06 17:34:11 +01:00
Sandeep Somavarapu
6a95d97a55 #38609 Show cancelled message on cancel 2017-12-06 09:38:48 +01:00
Sandeep Somavarapu
fd1c9a12cc #39659: Fallback to noop log service when spd log service is failed to create 2017-12-05 20:14:13 +01:00
Benjamin Pasero
be788e2dc7 fix #39654 2017-12-05 14:43:14 +01:00
Joao Moreno
8fb1d172e1 allow log service in cli process 2017-12-04 18:28:50 +01:00
Dirk Baeumer
dc98a60576 Windows work for #39262 2017-12-04 16:17:06 +01:00
Benjamin Pasero
3f9b66c2cd try to detect terminal encoding when reading from stdin (for #6161) 2017-12-04 12:00:25 +01:00