Commit Graph

254 Commits

Author SHA1 Message Date
Daniel Imms
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
This reverts commit 7f5a4a3f5b.
2019-10-13 10:55:54 -07:00
Daniel Imms
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Benjamin Pasero
93bb67d7ef debt - use common/product over node/product 2019-09-16 11:35:11 +02:00
Benjamin Pasero
5e1179f0b8 web - move help actions to browser 2019-09-16 10:37:58 +02:00
Daniel Imms
d68d86d2db Improve testing around terminal env vars 2019-09-12 18:00:54 -07:00
Daniel Imms
ebed7e9c5e Change setLocaleVariables to detectLocale
The setting is now an enum instead of boolean and defaults to auto
which should provide better detection and not set in cases where it
shouldn't.

Fixes #80072
2019-09-12 16:16:07 -07:00
Daniel Imms
63a0da438b Have ExtHostTerminalService extend Base service 2019-09-11 09:54:27 -07:00
Daniel Imms
b5a3125123 Move most of ExtHostTerminalService to common 2019-09-11 09:35:51 -07:00
Johannes Rieken
dedf0de944 change type of _serviceBrand from any to undefined, #79918 2019-08-30 15:40:46 +02:00
Daniel Imms
6f998109d8 Use void | number for onDidClose
Fixes #79643
2019-08-22 07:06:13 -07:00
Daniel Imms
0b4c4dc892 Ensure resolved cwd is passed back to window
Fixes #1109
2019-08-20 11:02:23 -07:00
Daniel Imms
37e0b8e229 Add terminal.integrated.automationShell
Fixes #78497
2019-08-09 09:40:38 -07:00
Johannes Rieken
7a6f22b3af rename rpcService to extHostRpcService 2019-08-09 09:51:22 +02:00
Johannes Rieken
9ac2fd8adc Merge branch 'master' into joh/extHostInject 2019-08-08 19:24:22 +02:00
Daniel Imms
b1bb36ba2e Revert "Revert "Remove unneeded queue from ExtHostPseudoterminal""
This reverts commit 8b85550c7d.
2019-08-08 09:31:24 -07:00
Daniel Imms
8b85550c7d Revert "Remove unneeded queue from ExtHostPseudoterminal"
This reverts commit 3dc832d088.

This broke the tests
2019-08-08 09:30:57 -07:00
Daniel Imms
3dc832d088 Remove unneeded queue from ExtHostPseudoterminal
Fixes #78705
2019-08-08 07:37:53 -07:00
Johannes Rieken
2420d4c505 separate rpc and init data into separate services 2019-08-07 19:51:28 +02:00
Johannes Rieken
2cf97fc2e5 add service brand to terminal service 2019-08-07 16:19:25 +02:00
Johannes Rieken
ebd96071d1 make extHost-things services, setup injector 2019-08-07 16:11:00 +02:00
Daniel Imms
81adc15a12 Merge remote-tracking branch 'origin/master' into tyriar/69865_remove_renderers 2019-08-06 10:02:39 -07:00
Daniel Imms
dc6b475be7 Add global event window.onDidWriteTerminalData
Fixes #78502
2019-08-06 09:58:26 -07:00
Alex Ross
a98faa4454 Remove CustomExecution
Fixes #78540
2019-08-06 13:48:37 +02:00
Daniel Imms
0eed3275f6 Some clean up 2019-08-05 15:03:31 -07:00
Daniel Imms
25fe980387 Remove terminal renderers
Part of #69865
2019-08-05 14:31:15 -07:00
Daniel Imms
6cc1cdba5b Merge pull request #78526 from microsoft/tyriar/78168
Fix some strict property init errors in terminal
2019-08-05 11:29:12 -07:00
Johannes Rieken
32da48e7a0 consistent dto namings 2019-08-05 16:50:13 +02:00
Daniel Imms
046c3f5fb0 strict prop init terminal 2019-08-05 07:35:36 -07:00
Daniel Imms
1e3cc1a30d Don't fail hard when shell/shellArgs vars aren't resolved
Fixes #78307
2019-08-01 16:04:32 -07:00
Daniel Imms
426bdb6122 Don't fail silently 2019-07-29 15:27:29 -07:00
Logan Ramos
6dfbb7f196 Merge remote-tracking branch 'microsoft/master' into resolve-terminal-cwd 2019-07-29 10:41:43 -07:00
Daniel Imms
e2888839ec Don't throw out ext host proc requests on slow remotes
Fixes microsoft/vscode-remote-release#1031
2019-07-26 16:48:01 -07:00
Daniel Imms
6bb5e193f9 start -> open, exit -> close, remove exit code 2019-07-26 15:30:36 -07:00
Daniel Imms
9b60caf9e0 Improve naming of start/spawn request calls 2019-07-25 16:09:03 -07:00
Daniel Imms
3866deba35 Use pty naming instead of virtual process
Part of #77160
2019-07-25 16:00:41 -07:00
Logan Ramos
68c125c344 Resolve CWD 2019-07-25 15:42:52 -07:00
Daniel Imms
0927be89c8 Tweak names, make shellLaunchConfig readonly again 2019-07-24 14:29:24 -07:00
Daniel Imms
87a474c36a Merge remote-tracking branch 'origin/master' into pr/lramos15/77664 2019-07-24 14:11:29 -07:00
Logan Ramos
4008ea909e Merge remote-tracking branch 'microsoft/master' into shell-path-error-remote 2019-07-24 11:22:02 -07:00
Daniel Imms
9d43802fd4 Create CustomExecution2 test, make start fire after onDidOpenTerminal
Part of #70978
2019-07-23 17:35:11 -07:00
Logan Ramos
170beba5db Move resolve shell launch config above fork the process 2019-07-22 07:33:49 -07:00
Daniel Imms
ce28d57e21 Use async 2019-07-19 12:23:50 -07:00
Logan Ramos
d826dfd943 Allow remote error messages to work 2019-07-19 11:19:00 -07:00
Daniel Imms
48e7c6d927 Fix start cb in CustomExecution2
Fixes #77428
2019-07-16 15:10:17 -07:00
Logan Ramos
0a8ca638f1 Resolve Terminal arguments (#76895)
* Resolved terminal argds

* Move location of resolution

* Fix routing of resolver in extHost

* Remove unnecessary comma

* Compilation errors

* some async stuff

* Undo changes

* Variable resolver in constructor

* Load resolver upon construction of extHostTerminalService

* Utilize last active workspace root

* Reevaluate variableReoslver whenever the workspace gets new folder

* Fix types for string shellArgs

* Use async one level higher

* Fix compile issue

* Initialize resolver when exthost is created

* Fix ext host in remote case with no folder open

* Resolve args that an ecxctension passes in

* Remove TODO

* Resolve extension arguments
2019-07-16 09:23:38 -07:00
Matt Bierner
7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Daniel Imms
3092a1023c Remember dimensions from other terminals
Part of #77228
2019-07-11 21:18:06 -07:00
Daniel Imms
5701770f87 Ensure negative exit codes are not used
Fixes #77250
2019-07-11 15:47:15 -07:00
Alex Ross
e84fc7021b Adopt TerminalVirtualProcess for Custom task execution (#76852)
* Adopt TerminalVirtualProcess for Custom task execution

* Update Custom task execution API to return TerminalVirtualProcess in callback

This also required the addtion of a start on the virtual terminal process

* Clarify start API

Fixes #76492
2019-07-10 09:31:40 +02:00
Daniel Imms
8ec3a1b39e Rename input to handleInput
Part of #70978
2019-07-08 12:32:27 -07:00