Daniel Imms
a560acd1bd
Remove test link provider
2020-06-21 18:01:33 -07:00
Daniel Imms
cb5ddcf44f
Resolve todos, move process creation after xterm
...
Having _processManager.createProcess called before _createXterm was causing
some event listeners like onProcessReady to fire before they were registered
within _createXterm.
2020-06-21 08:12:13 -07:00
Daniel Imms
ef93f6eb65
Update
2020-06-18 05:53:38 -07:00
Daniel Imms
a0558707ec
Handle link on exthost
2020-06-18 05:15:04 -07:00
Daniel Imms
2dbf1703b8
Get link providers passing all the way through to the renderer
2020-06-17 12:10:03 -07:00
Daniel Imms
16466627c1
Scaffold out link provider proposed API
...
Part of #91290
2020-06-16 11:47:48 -07:00
Daniel Imms
1dd4c04384
Fix launching in ext host/pty terminals
2020-06-12 11:05:45 -07:00
Daniel Imms
e6c745ebef
Refactor terminal launch logic to improve error
...
Fixes #99905
Part of #99996
2020-06-12 07:02:27 -07:00
Matt Bierner
cadabab73f
Mark _serviceBrand properties using declare ( #99312 )
...
_serviceBrand is only used for typing and should not result in emit
Also adds readonly
2020-06-05 11:04:15 -07:00
Daniel Imms
7f5bada046
Move EnvironmentVariableCollection API into ExtensionContext ( #96061 )
...
* Move env var collection to ext context
* Remove dispose, fix persistent passing
* Fire collection change on persistence change
* Fix tests by forcing activation and getting ctx
* chore: bump js-debug
Co-authored-by: Connor Peet <connor@peet.io >
2020-04-24 16:45:30 -07:00
Daniel Imms
8279cc70d9
Respect thisArg in EnvironmentVariableCollection.forEach
...
Fixes #94077
2020-04-09 06:05:34 -07:00
Daniel Imms
fe36108236
Add dispose checks to env var collections
...
Fixes #94066
2020-04-04 21:15:43 -07:00
Daniel Imms
000f8392b3
Only persist collections marked to do so
2020-03-27 09:03:53 -07:00
Daniel Imms
058bd5dbf7
Don't trigger renderer sync when no change happened
2020-03-27 07:51:51 -07:00
Daniel Imms
d91532afa8
Load in persisted collections from past sessions on ext host
2020-03-27 07:44:56 -07:00
Daniel Imms
1235bd0a60
Support diffs of collections, extracting additions
2020-03-26 16:51:04 -07:00
Daniel Imms
edc7100114
Apply multiple extension mutators, share code with ext host
2020-03-26 15:40:03 -07:00
Daniel Imms
ed9e7241b7
Move single ext collection updates across
2020-03-25 11:57:12 -07:00
Daniel Imms
b2a9d4dd61
Serialize collections on ext host
2020-03-25 07:35:19 -07:00
Daniel Imms
97eaa84d46
Pass terminal method through to ext host terminal service
2020-03-24 08:02:11 -07:00
Daniel Imms
9425f1224d
Move prop to top of class
2020-03-13 07:07:51 -07:00
Daniel Imms
b66d56602f
Implement terminal link handler API
...
Part of #91606
2020-03-12 18:17:18 -07:00
Daniel Imms
cd17694974
Fix possible race condition
...
Fixes #90883
2020-02-18 07:35:59 -08:00
Benjamin Pasero
54d57f552f
Integration tests: terminal throws exceptions ( fix #90046 )
2020-02-13 11:31:52 +01:00
Daniel Imms
5fad95f544
Change getDefaultShellAndArgs to use promises
...
Part of #75793
2020-02-05 12:03:45 -08:00
Daniel Imms
1aefcce704
Change requestAvailableShells to use promises
...
Part of #75793
2020-02-05 11:55:14 -08:00
Daniel Imms
ba8caea056
Merge branch 'master' into pty-links
2020-02-04 10:31:35 -08:00
Daniel Imms
a62805844e
Expose IExtHostTerminalService.getDefaultShellArgs internally
...
Fixes #88280
2020-01-13 07:45:08 -08:00
Konstantin Solomatov
fbec956fc4
Fix link handing in extension pseudoterminals
2020-01-10 15:15:34 -08:00
Matt Bierner
1b70625f8c
Use import type when importing vscode under src
...
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Daniel Imms
027d7caec5
Flush all buffered data events on terminal close
...
Fixes #85257
2020-01-02 08:41:08 -08:00
Daniel Imms
d630afbbb0
Fix strictFunctionTypes in extHostTerminalService
...
Part of #81574
2019-11-19 11:13:59 -08:00
Daniel Imms
649ef05dfb
Fix ws
2019-11-17 12:55:10 -08:00
Daniel Imms
f329ef3753
Merge dimensions into awaiting object
2019-11-17 12:54:38 -08:00
Daniel Imms
6d7f763548
Only set _extensionTerminalAwaitingStart when deferred start is needed
2019-11-17 12:52:17 -08:00
Daniel Imms
1004d51605
Merge branch 'master' into pty_bug
2019-11-17 12:35:57 -08:00
Konstantin Solomatov
b07e52a4ed
200 -> 2 * EXT_HOST_CREATION_DELAY * 2
...
remove dead code
2019-11-09 20:29:27 -08:00
Konstantin Solomatov
b145048e2c
Remove pointless code
2019-11-09 20:15:40 -08:00
Konstantin Solomatov
794ed4ff1c
Fixed test
2019-11-08 11:55:23 -08:00
Konstantin Solomatov
ed52435fe5
Fixing tests
2019-11-08 11:29:09 -08:00
Konstantin Solomatov
bde2d42430
Code review comments
2019-11-08 10:12:41 -08:00
Konstantin Solomatov
c60c6c1c57
Fix bug with hanged pseudoterminal
2019-11-07 17:41:31 -08:00
Daniel Imms
e41c71b0d0
Merge branch 'master' into tyriar/63052
2019-11-05 10:32:42 -08:00
Daniel Imms
1d60909d1f
Implement Terminal.creationOptions API
...
Fixes #63052
2019-11-05 10:30:43 -08:00
Daniel Imms
7215e5e9f5
Pass through undefined exit codes
2019-11-05 09:17:57 -08:00
Daniel Imms
2a0d3d0140
Support Terminal.exitStatus API
...
Fixes #62103
2019-11-05 09:09:39 -08:00
Daniel Imms
82c348326c
Merge remote-tracking branch 'origin/master' into tyriar/integration_test
2019-10-31 11:28:31 -07:00
Daniel Imms
3f3527dedb
Null check terminal processes before calling on them in ext host
...
Fixes #81821
2019-10-31 09:12:32 -07:00
Benjamin Pasero
33cc09da7a
Revert "Removing EXT_HOST_CREATION_DELAY hacks" ( #83422 )
...
This reverts commit 2b61a8817b .
2019-10-28 12:08:07 +01:00
Daniel Imms
2b61a8817b
Removing EXT_HOST_CREATION_DELAY hacks
...
This one was a bit tricky to figure out what was going on, but this is how it
was working before: Terminals that use extension processes calls
$createTerminal from the ext host, this returns a promise with an ID that gets
returned asynchronously after the process has been setup (ie. an ext host process
proxy was created).
The reason we needed the timeout was because the process initialization is async
as we need a layout to occur so that we have the dimensions of the terminal to
give to the process. The fix could have been setTimeout(..., 0) as well but that
feels hacky as well, the fix in this commit is to pipe an event through from
the process manager which is the actual time when we are good to start telling
ext hosts are the new terminals.
Fixes #77655
2019-10-25 12:57:30 -07:00