Connor Peet
a57cb45be8
notebooks: pipe renderer API postmessages to the renderer itself ( #100414 )
...
* notebooks: pipe renderer API postmessages to the renderer itself
Previously the postMessage on acquireNotebookRenderer API was just
a proxy to the global vscode postmessage. Now, it's linked to the
renderer and will cause an optional `onDidReceiveMessage` method on
the renderer to be called.
The message still _also_ goes to the global webview message handling
for advanced use cases, but this change allows the webview<->renderer
communication to be more nicely contained
and separate for most use cases.
* wip
* fixup! pr comments
2020-06-22 09:35:16 -07:00
Alex Ross
fb36c0ddc3
Adopt hover service in custom tree view
...
Part of #100741
2020-06-22 11:09:44 +02:00
Daniel Imms
269f0fdd83
Merge pull request #100496 from microsoft/tyriar/link_providers
...
Proposed terminal link provider API
2020-06-21 18:46:24 -07:00
Daniel Imms
a560acd1bd
Remove test link provider
2020-06-21 18:01:33 -07:00
João Moreno
cd3a3ea6fa
address codeql review
2020-06-21 17:17:51 +02:00
Daniel Imms
cb5ddcf44f
Resolve todos, move process creation after xterm
...
Having _processManager.createProcess called before _createXterm was causing
some event listeners like onProcessReady to fire before they were registered
within _createXterm.
2020-06-21 08:12:13 -07:00
Daniel Imms
34b20f9609
Merge branch 'master' into tyriar/link_providers
2020-06-21 07:36:20 -07:00
Benjamin Pasero
b385fa7ceb
editors - improve language
2020-06-19 14:53:55 +02:00
Daniel Imms
395b228387
Merge remote-tracking branch 'origin/master' into tyriar/link_providers
2020-06-19 05:26:26 -07:00
Benjamin Pasero
801ab0e2da
editors - move open with to editor ( fix #100057 ) ( #100466 )
2020-06-19 14:05:48 +02:00
Andre Weinand
ab8267f7f4
revert fix for #95423 ; fixes #100508
2020-06-18 18:41:00 +02:00
Johannes Rieken
9683615c00
make ExtHostWindow a service so that it can be consumed in terminal world, fyi @Tyriar
2020-06-18 15:07:06 +02:00
Daniel Imms
ef93f6eb65
Update
2020-06-18 05:53:38 -07:00
Daniel Imms
a0558707ec
Handle link on exthost
2020-06-18 05:15:04 -07:00
Alex Dima
39e3340d04
Push not-null assertion further down to usage
2020-06-18 13:18:47 +02:00
Johannes Rieken
cda677da09
make NotebookConcatTextDocument extends "normal" TextDocument, https://github.com/microsoft/vscode/issues/100186
2020-06-18 11:10:23 +02:00
rebornix
e51bb9be57
fix unit test.
2020-06-17 18:31:53 -07:00
rebornix
6c68514534
Fix #100329 . Content providers can contribute to undo/redo stack of a notebook document.
2020-06-17 17:08:09 -07:00
Daniel Imms
2dbf1703b8
Get link providers passing all the way through to the renderer
2020-06-17 12:10:03 -07:00
Alex Ross
d52f137ed5
Return task execution early from executeTask
...
Fixes #100361
2020-06-17 13:54:21 +02:00
Alex Ross
1abf21d3d8
Explicitly set task execution way before running task
...
Part of #100361
2020-06-17 13:39:02 +02:00
Alex Ross
d128b7c139
Resolve executeTask with execution earlier
...
Part of #100361
2020-06-17 11:15:58 +02:00
rebornix
ca7f2683fd
resolve notebook editor with comm object.
2020-06-16 17:21:11 -07:00
rebornix
a9db9d94ff
💄
2020-06-16 16:25:24 -07:00
rebornix
8ad77ef2b6
mimetype and remove revert.
2020-06-16 14:55:20 -07:00
Daniel Imms
16466627c1
Scaffold out link provider proposed API
...
Part of #91290
2020-06-16 11:47:48 -07:00
Alex Ross
60efd18c23
Task logging for failure cases
...
And unneded condition clean up
2020-06-16 17:11:08 +02:00
Andre Weinand
d4dbf77308
don't "delete" mandatory property; fixes #99479
2020-06-16 12:41:29 +02:00
Andre Weinand
f9c6fa3161
properly resolve ${file} variable; fixes #95423
2020-06-15 22:44:51 +02:00
Connor Peet
cf7b620598
api: finalize extensionMode
...
Fixes #95926
2020-06-15 09:35:14 -07:00
Daniel Imms
54b6e8fa41
Merge pull request #100011 from microsoft/tyriar/term_errors
...
Refactor terminal launch, improve error handling and add troubleshoot link to notification
2020-06-15 09:33:41 -07:00
Connor Peet
45dbf43a87
Merge branch 'connor4312/identify-cell-outputs'
2020-06-15 09:14:23 -07:00
isidor
5b703aff8e
fixes #100157
2020-06-15 15:58:02 +02:00
Daniel Imms
a870da6ab2
Merge branch 'master' into tyriar/term_errors
2020-06-15 06:20:48 -07:00
Alex Ross
acc5aab2fa
Fix extHostTask execution for strings
...
Fixes #98080
2020-06-15 11:38:26 +02:00
Daniel Imms
5053f27c39
Merge branch 'master' into tyriar/term_errors
2020-06-14 06:56:51 -07:00
rebornix
98c3065160
Fix #96840 . Support backup/revert from notebook content provider.
2020-06-12 18:00:15 -07:00
Rachel Macfarlane
faac1ffe01
Add codespaces extension to VSO_ALLOWED_EXTENSIONS list
2020-06-12 13:01:07 -07:00
Daniel Imms
3581908cce
Merge branch 'master' into tyriar/term_errors
2020-06-12 12:49:56 -07:00
Connor Peet
1d1b452f2f
notebooks: add ID for rich outputs, expose to renderer and webview
...
Some API changes:
- I changed the second param of NotebookOutputRenderer.render to a
`NotebookRenderRequest` since we were up to four parameters already.
- The request contains a unique `outputId`, which is generated when
output is first created or restored (the ID is not stable if a
notebook is closed and reopened)
- I changed the renderer events to `onDidCreateOutput` and
`onWillDestroyOutput` since they're for outputs, not cells.
- Additionally, they're called with objects that contain the output
ID to render.
2020-06-12 12:29:30 -07:00
Rachel Macfarlane
3718e630d1
Use submenu instead of quickpick for showing account commands, fixes #99901
2020-06-12 11:51:14 -07:00
Daniel Imms
d8a2d483da
Remove unneeded async
2020-06-12 11:15:55 -07:00
Daniel Imms
1dd4c04384
Fix launching in ext host/pty terminals
2020-06-12 11:05:45 -07:00
isidor
cc06e19b15
Introduce DebugSessionOptions.noDebug
...
#99743
2020-06-12 17:33:00 +02:00
Johannes Rieken
28cb90be8c
chore - ES6, use for-of instead of forEach
2020-06-12 16:20:23 +02:00
Daniel Imms
e6c745ebef
Refactor terminal launch logic to improve error
...
Fixes #99905
Part of #99996
2020-06-12 07:02:27 -07:00
Alex Dima
1927f9b6e0
Add getters for connection data & events for changes
2020-06-12 13:57:12 +02:00
Alex Dima
1f3ba68676
Move the remote connection data to the IRemoteAuthorityResolverService
2020-06-12 13:57:12 +02:00
Alex Dima
301597857d
Add connectionData to IInitData.remote
2020-06-12 13:57:12 +02:00
Johannes Rieken
b662583062
chore - more ES6 iteration
2020-06-12 13:55:31 +02:00