Commit Graph

25 Commits

Author SHA1 Message Date
Peng Lyu
c17bb3e4b3 Re #69955. Adopt new tree in comments panel. 2019-08-05 15:38:36 -07:00
Rachel Macfarlane
8efcc47e18 strictPropertyInitialization, #78168 2019-08-05 09:05:30 -07:00
Peng Lyu
f1bad37012 Remove Comment Id 2019-07-18 15:34:05 -07:00
Matt Bierner
7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions
Comment Reaction API
2019-06-10 10:36:21 -07:00
Peng Lyu
cae0668a0e reactions handler 2019-06-05 21:08:41 -07:00
Matt Bierner
2c8de04126 Fix merge error related to disposables 2019-06-05 15:41:45 -07:00
Matt Bierner
869e5921d8 Update more places where we are using an IDispoable[]
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Rachel Macfarlane
83ef31e6a2 Correctly set extensionId on comment threads 2019-06-04 11:50:47 -07:00
Peng Lyu
039b3e0a1a Merge pull request #74688 from microsoft/rebornix/fix#74641
Fix #74641. Update viewzone afterline when position changes.
2019-06-03 13:45:04 -07:00
Rachel Macfarlane
0284236851 Fix #74668, old comment API not adding comments 2019-05-31 12:00:24 -07:00
Peng Lyu
c042dabe2b Fix #74641. Update viewzone afterline when position changes. 2019-05-31 10:27:56 -07:00
Peng Lyu
346da6b01a dispose empty comment thread when collapse. 2019-05-23 16:37:42 -07:00
Peng Lyu
e26568b586 Add contextValue support 2019-05-21 16:59:34 -07:00
Rachel Macfarlane
925426e8b0 Remove activeCommentThread from extHost comments, set context keys on simple comment editor 2019-05-17 16:52:36 -07:00
Peng Lyu
4186bc0a44 menu items 2019-05-17 11:49:00 -07:00
Peng Lyu
072e9a35ee Comments API Finalization (#73010)
* Comments API Finalization
2019-04-30 14:59:59 -07:00
Peng Lyu
253809c186 Legacy api should still work. 2019-04-28 16:35:01 -07:00
Peng Lyu
67fc5ba4e1 Empty Comment Thread Factory works 2019-04-28 14:23:12 -07:00
Peng Lyu
2884d2239b Add active comment thread. 2019-04-28 12:30:29 -07:00
Peng Lyu
004894a5b5 Dispose comment thread properly 2019-04-17 11:27:19 -07:00
Peng Lyu
a556fe2761 Support multiple comment provider 2019-04-04 15:24:27 -07:00
Peng Lyu
260442f574 Batch comment thread properties update event (#71569) 2019-04-02 01:00:03 +02:00
Benjamin Pasero
3c136df8a2 move comments to browser (#70319, #69103) (#70939) 2019-03-25 07:56:48 +01:00