82 Commits

Author	SHA1	Message	Date
Peng Lyu	579e4ac025	Comments should be in ctor comment thread	2019-03-15 12:53:41 -07:00
Alex Ross	8f16a02e66	Move remote agent environment out of node (#70568)	2019-03-15 17:00:57 +01:00
Peng Lyu	f3f59aadc4	check if toggle reaction is available	2019-03-13 12:57:35 -07:00
Peng Lyu	528b422d92	strict null checks	2019-03-13 12:52:24 -07:00
Peng Lyu	58961de8fc	command is renamed to select command	2019-03-13 12:47:21 -07:00
Peng Lyu	16f80d5b74	toggle reactions	2019-03-13 12:46:38 -07:00
Peng Lyu	5c2d728a99	Select command for Comment.	2019-03-13 12:45:59 -07:00
Peng Lyu	9f6d5c009e	avoid redundant range update	2019-03-13 12:44:22 -07:00
Matt Bierner	32afa6d121	Strict null work in comments ... Lots of null supressions. Will open issue to track removal	2019-03-13 11:31:49 -07:00
Matt Bierner	ba569d8960	Strict null work on extHostComments	2019-03-13 11:31:49 -07:00
Peng Lyu	414aa83658	commentingRangeS	2019-03-11 11:42:28 -07:00
Peng Lyu	c8ffa51ca4	optional commenting range provider and empty comemnt thread factory.	2019-03-11 11:25:26 -07:00
Peng Lyu	75e711f8a6	seperate acceptInputCommand and additional commands.	2019-03-07 11:34:43 -08:00
Peng Lyu	b64a7295b2	Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement	2019-03-06 14:54:42 -08:00
Peng Lyu	ce1cb8a9fc	replace draft properties with labels in CommentThread and Comment	2019-03-06 14:29:02 -08:00
Peng Lyu	905248fa6e	comments panel handle new comment thread registration.	2019-03-06 11:57:30 -08:00
Peng Lyu	42194d82a1	Callback for creating new comments	2019-03-06 10:15:51 -08:00
Matt Bierner	52556f9742	Auto converting let -> const where possible in mainthread and extHost ... Const provides better type guards and can make logic clearer	2019-03-05 16:53:41 -08:00
Peng Lyu	3cf67b0b7d	exthost types, avoid using enums	2019-03-05 10:03:07 -08:00
Peng Lyu	e78c2e2a21	less verbose comment controller api	2019-03-04 17:27:19 -08:00
Peng Lyu	e42c30a294	CommentController.	2019-03-04 11:37:18 -08:00
Peng Lyu	15d782f4a4	Update comment range	2019-03-01 10:06:54 -08:00
Peng Lyu	e5dbd34dd3	Merge pull request #69253 from Microsoft/rebornix/commentscontrol ... Comments API refactor	2019-02-22 16:54:39 -08:00
Peng Lyu	bb62f5036d	Support new comment thread creation.	2019-02-22 16:46:49 -08:00
Peng Lyu	4f249529e8	Commenting Ranges API	2019-02-22 12:05:08 -08:00
Peng Lyu	39218635a5	Dispose commentcontrol properly.	2019-02-22 11:29:58 -08:00
Peng Lyu	bcc48091d3	Make sure CommentControl & CommentsProvider handles are unique.	2019-02-22 11:02:23 -08:00
Peng Lyu	de52daea94	edit/delete command	2019-02-20 16:45:50 -08:00
Peng Lyu	38e0c3f2c2	accept input commands.	2019-02-20 16:45:14 -08:00
Matt Bierner	7e759cf3c8	Annotate more usage before assign strict null errors	2019-02-19 16:29:01 -08:00
Peng Lyu	67ad526371	comment control. active thread, comment, input update.	2019-02-15 17:48:03 -08:00
Peng Lyu	54c75aa50b	support icons	2019-02-13 19:34:35 -08:00
Peng Lyu	1789af2b83	Use customized toolbar for reactions.	2019-02-13 19:34:35 -08:00
Peng Lyu	0d50120c71	fix comments npe	2019-02-12 09:19:33 -08:00
Peng Lyu	d50c9d8609	check if users can operate on reactions	2019-02-11 16:32:24 -08:00
Matt Bierner	f1afe72087	Add getDocument helper method ... Many places in `extHostLanguageFeatures` were calling `getDocumentData` without checking if the result is undefined. Add an `getDocument` that cannot return undefined values and instead throws an error if there is no document	2019-02-11 09:31:13 -08:00
Peng Lyu	130fdbee2b	reaction api	2019-01-27 15:06:33 -08:00
rebornix	fe5f523735	Add extension information to comment widget model	2019-01-10 09:58:56 -08:00
Alex Dima	9cf36cdf8f	Rename CanonicalExtensionIdentifier to ExtensionIdentifier	2019-01-07 12:00:54 +01:00
Alex Dima	25417553be	Adopt case insensitive extension identifiers	2018-12-21 12:41:41 +01:00
Rachel Macfarlane	c5c15eb75f	Add document parameter to draft methods on comments provider	2018-12-18 14:57:50 -08:00
Matt Bierner	d40fa4a27e	Review uses of Promise.resolve(null) ... Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.	2018-12-13 15:41:13 -08:00
Johannes Rieken	c6c7edaa9f	debt - asThenable -> asPromise because it returns a promise	2018-12-13 11:45:48 +01:00
Johannes Rieken	653280d133	debt - Thenable -> Promise	2018-12-13 11:31:54 +01:00
rebornix	9eb6d908e3	remove unused method	2018-11-29 10:38:42 -08:00
rebornix	e877e5c820	comment thread can be updated by draft mode change.	2018-11-29 10:27:27 -08:00
rebornix	8d78edddaa	render pending comment	2018-11-28 16:05:16 -08:00
rebornix	11d48f122e	first cut	2018-11-27 16:02:39 -08:00
Rachel Macfarlane	af1b4ebded	Refactoring comment service to not be keyed on handle	2018-11-08 14:13:43 -08:00
Rachel Macfarlane	36dc10c9f7	Add log for registering workspace comment provider	2018-10-29 15:16:18 -07:00