Commit Graph
27567 Commits
Author SHA1 Message Date
SteVen Batten aac4d208bf fixes #52505 2018-06-26 19:48:28 -07:00
Ramya Achutha Rao 52a0574939 Shorten msg Fixes #53037 2018-06-26 13:24:13 -07:00
Rob Lourens 3d688527f9 Settings editor - fix editing settings during search 2018-06-26 13:21:15 -07:00
Daniel Imms e38de7201d Use ReadonlyArray for window.terminals
Fixes #52888
2018-06-26 12:52:56 -07:00
Daniel Imms 8608692417 Merge remote-tracking branch 'origin/master' into 52882_api_names 2018-06-26 12:46:29 -07:00
Daniel Imms 8237445753 Rename cols to columns
Fixes #52885
2018-06-26 12:45:36 -07:00
Matt Bierner 2ed5aee8f0 Move webview serializer api out of proposed 2018-06-26 11:38:46 -07:00
Rob Lourens 90b1beeb5b Fix #52872 - settings editor breaks on search 2018-06-26 10:15:12 -07:00
Daniel Imms f3e89cad5f Rename terminal ext APIS to match convention
Fixes 52882
2018-06-26 07:50:51 -07:00
Daniel Imms 8adcb8b45b More tweaks to texture setting comment
Fixes #52890
2018-06-26 07:42:47 -07:00
Daniel Imms 396ca1f36f Improve experimentalTextureCachingStrategy comment
Fixes #52890
2018-06-26 07:29:39 -07:00
Martin Aeschlimann 923e9ccb3f [json] fix test failures 2018-06-26 14:48:15 +02:00
Martin Aeschlimann d8c767b4d1 [themes] report theme loading problems when switching themes 2018-06-26 12:53:47 +02:00
Martin Aeschlimann 31a0961ced remove unnecessary try catch aroud json.parse 2018-06-26 12:53:47 +02:00
Martin Aeschlimann 91b3e3e8d5 [json] allow trailing comma by default 2018-06-26 12:53:47 +02:00
Martin Aeschlimann 45eb2dcc4a [json] problem with comment after literal. For #52523 2018-06-26 12:53:47 +02:00
Benjamin Pasero 22d3686280 fix #52893 2018-06-26 11:37:37 +02:00
Rob Lourens 51e0ad1ac7 Settings editor - fix setting float values. #50249 2018-06-25 22:29:26 -07:00
Leonardo Braga 1ec986b06b Fixed the creation of UNC 'file' URIs from 'untitled' ones (#52518) 2018-06-26 07:02:14 +02:00
Benjamin Pasero 368ab9c31b use systemPreferences.setUserDefault() to workaround #35361 2018-06-26 06:56:23 +02:00
Ramya Rao 6a5918165d Experiments (#52848)
Infrastructure to run experiments
2018-06-25 21:49:06 -07:00
Jackson Kearl a474fe9e2d Fix bug disallowing modifying a config enjtry that didnt already exist (#52851) 2018-06-25 17:58:09 -07:00
Rob Lourens 082918976e #52815 - Settings editor - 'enter' edits setting 2018-06-25 16:59:31 -07:00
Rob Lourens 065a100052 #52815 - Better settings editor KB navigation 2018-06-25 16:59:31 -07:00
Jackson Kearl 3ec9470f07 Add "Add to Recommendations (Workspace)" (#52837)
* Add "Add to Recommendations (Worksapce)"

in addition ot the existing "Add to Recommendations (Workspace Folder)"

* Add commands to add extensons to unwanted recommendations
2018-06-25 16:48:51 -07:00
SteVen Batten 2523a160e0 supporting #51954 2018-06-25 16:29:48 -07:00
SteVen Batten 9247a3f231 Merge branch 'master' of https://github.com/Microsoft/vscode 2018-06-25 15:59:50 -07:00
SteVen Batten e663710ffa fixes #52284 2018-06-25 15:59:01 -07:00
Jackson Kearl 1662556340 Fix race bug (#52843)
* Fix race bug

* replace the fix with a fix that actualy fixes

* Remove unused import
2018-06-25 15:21:49 -07:00
Rob Lourens 0b07936244 Settings editor - fix refreshing when settings target changes.
Add right-padding to setting
2018-06-25 14:44:31 -07:00
Rob Lourens 2ece4b2ca4 Settings editor - add "workbench/settings" group 2018-06-25 14:44:31 -07:00
Rob Lourens 66a8535e19 Settings editor - shorter bool rows 2018-06-25 14:44:31 -07:00
Rob Lourens 04cda4357f #52810 - Tweak settings editor header padding 2018-06-25 13:32:57 -07:00
Jackson Kearl d88b3dd55b UX Changes to ignore recommendations (#52514)
* UX Changes to ignore recommendations

* Fix missed negation when changing to shouldRecommend

* Update restored recommendation wording

* Update wording again

* Remove unused field
2018-06-25 12:46:03 -07:00
SteVen Batten 65c3b9e9b8 Submenus for Menu Widget (#52780)
* submenu registration, ignore && mnemonic rendering for now

* clean up ActionItems for Menu Widget and submenu

* clean up the update actions logic in menubar

* fix keyboard navigation for submenus

* add terminal menu and update submenu labels

* fix missing separator issue

* updating some aria labels

* bring back action runner to hide menu before running

* address feedback from @bpasero
2018-06-25 12:33:10 -07:00
Ramya Achutha Rao c9b7b4d9e0 Case insensitive check to avoid recommending multiple times Fixes #52753 2018-06-25 12:23:45 -07:00
Rob Lourens f86e10a45f Fix #52808 - remove 'reset' button 2018-06-25 11:59:57 -07:00
Rob Lourens b3e816ed61 Settings editor settings should be 'window' scope 2018-06-25 11:59:57 -07:00
Rob Lourens d66d3dd7a0 Fix #52809 - add setting to hide TOC entirely 2018-06-25 11:29:25 -07:00
Rob Lourens b577ccebe7 Fix #52817 - also consider settings tree selection when syncing with the TOC 2018-06-25 11:29:25 -07:00
Benjamin Pasero 26af5f5392 fix #52807 2018-06-25 20:15:40 +02:00
Matt Bierner 946ff76af6 Fix jsdoc comment being on wrong type 2018-06-25 11:09:05 -07:00
Daniel Imms fdb62c52ff Ensure terminal scrollbar is visible when find widget is focused
Fixes #29670
2018-06-25 11:06:32 -07:00
Rob Lourens b0fb72f766 Remove 'absolute path' search service test which is now obsolete 2018-06-25 10:28:19 -07:00
Rob Lourens cc311ee122 Merge pull request #52649 from Microsoft/roblou/extSettings
Track which settings were contributed by extensions
2018-06-25 10:27:05 -07:00
Benjamin Pasero 9719d316ca Revert "Fix #35361: fix native tabs on macOS 10.13 (#52775)"
This reverts commit 8e03e03131.
2018-06-25 19:03:21 +02:00
Rob Lourens 1df0be9fc8 #51597 - PR feedback 2018-06-25 09:34:56 -07:00
Rob Lourens 0a23bfb68f Fix #51597 - move searching with absolute path queries out of search service and into openFileHandler 2018-06-25 09:33:13 -07:00
zhuowei 8e03e03131 Fix #35361: fix native tabs on macOS 10.13 (#52775)
* Fix #35361: fix native tabs on macOS 10.13

macOS 10.13 mistakenly enables a compatibility option on VS Code
and VS Code Insiders because their bundle IDs begin with
"com.microsoft.". This breaks native tabs.

Explicitly disable the compatibility patch using NSUserDefaults.

Note that Code-OSS is not affected by the bug, since its bundle ID
is "com.visualstudio.code.oss". To test this behaviour, change
darwinBundleIdentifier in product.json.

* set NSUseImprovedLayoutPass only when window.nativeTabs: true
2018-06-25 18:30:59 +02:00
Sandeep Somavarapu 3669afe7e9 Fix #48656 2018-06-25 18:20:20 +02:00