Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-26 04:34:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
92,667 Commits 3,046 Branches 347 Tags
aad33b60cc8baacbbdccf968096b4ccd4e40b7d3
Commit Graph

111 Commits

Author SHA1 Message Date
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler Leonhardt
c68d433ac8 copy & continue. Fixes microsoft/vscode-internalbacklog#2613 2022-01-27 16:55:27 -08:00
Logan Ramos
c047af40b2 Fix compilation 2022-01-19 16:18:14 -05:00
svennergr
22e45e9f88 Add proper error message on getUserInfo (#140277) 
* Add proper error message on getUserInfo

* improved error message on getUserInfo

either display the response message or the http status text

Co-authored-by: Sven Grossmann <mail@grossmann.dev>
 2022-01-10 11:35:20 -08:00
Tyler Leonhardt
e8a26d3ebf ensure we treat scopes sorted and we only return a single session since GH only supports a single log in 2021-12-20 17:12:53 -05:00
Tyler James Leonhardt
f67a8b753f Use device flow over PAT when we are running in a server full environment but not in a supported uri (#139255) 
* initial attempt

* use github-authentication instead

* rework error handling

* update copy

* explain why Workspace
 2021-12-15 22:07:49 -05:00
Tyler Leonhardt
a3e60d2dff Add messages for rejected promises 2021-12-07 16:23:04 -08:00
Johannes Rieken
68e819043c use tsconfig.json#include for vscode.d.ts and vscode.proposed.d.ts, enables to remove most ref.d.ts-files 2021-11-09 15:53:35 +01:00
Johannes Rieken
9254a8cd27 move vscode.d.ts and vscode.proposed.d.ts into src/vscode-dts-folder, https://github.com/microsoft/vscode/issues/131165 2021-11-09 15:00:03 +01:00
Tyler Leonhardt
4d496f61bc remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201 2021-10-25 11:16:37 -07:00
Joyce Er
b97ab80c18 Fix typo in PAT auth flow error message 2021-10-20 16:37:02 -07:00
João Moreno
a390f81744 no hack is better hack 
Co-authored-by: Tyler <TylerLeonhardt@users.noreply.github.com>
 2021-10-11 18:02:36 +02:00
Tyler Leonhardt
5364c56768 include insiders.vscode in nocors 2021-10-08 11:32:28 -07:00
Tyler Leonhardt
ab184912e6 make sure we splice the sessions if they have the same set of scopes for github authentication 2021-09-23 16:46:31 -07:00
Logan Ramos
420436d4c4 Fix #133493 2021-09-21 13:36:30 -04:00
Tyler Leonhardt
520fa49e68 refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck. 2021-08-16 16:34:21 -07:00
Tyler Leonhardt
a8332b75e4 delete extra afterTokenLoad 2021-08-03 16:24:28 -07:00
Tyler Leonhardt
37a8fe959c no longer call /user to verify tokens 2021-08-03 14:50:07 -07:00
Tyler Leonhardt
c7e45c4fa4 Add a bunch of logging to github-authentication 
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
 2021-07-23 15:28:06 -07:00
Tyler Leonhardt
c1b4cf00b9 update auth extensions to use packageJSON property instead 2021-07-23 11:48:39 -07:00
Tyler Leonhardt
8a4ace6ebf maintain promise instead in github-auth to ensure the exp service doesn't get created twice 2021-07-23 09:24:40 -07:00
Tyler Leonhardt
a8134002cd lazily load experimentation service in github-authentication 2021-07-23 09:07:41 -07:00
Tyler Leonhardt
54a2e15f6b remove unused variable 2021-07-22 17:40:13 -07:00
Tyler Leonhardt
3ed425bef9 Rework github authentication extension to make less HTTP requests. 
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
 2021-07-22 17:25:59 -07:00
VocalTrance
715798221b Fix typo in github-authentication/github.ts (#129100) 2021-07-21 06:30:45 -07:00
Tyler James Leonhardt
87d692b7bf Add scopes property to login telemetry (#128261) 
* Add scopes property to login telemetry
 2021-07-08 21:48:44 -07:00
Tyler Leonhardt
1d1b9961d7 sort scopes on filter for getSessions in the github auth provider. Fixes https://github.com/github/codespaces/issues/3109 2021-06-30 10:15:24 -07:00
Tyler Leonhardt
6b6be7efe1 just return if the acceptedStates don't match fixes #126084 2021-06-28 17:12:06 -07:00
Tyler Leonhardt
4a011b5297 add additional logging around github auth 2021-06-28 16:27:52 -07:00
Kai Maetzel
c200dc4909 fix isNoCorsEnvironment (#126718) 2021-06-18 17:36:59 -07:00
Oleg Demchenko
61f34055fa Auth session API fix (#125792) 
* Adjust "provider is not registered" exception behavior

* Process cancellation in GH auth provider

`e.message` is always `undefined`
 2021-06-10 20:14:08 +00:00
Matvii Hodovaniuk
67561036cf Replace map with forEach (#115378) 
The callback provided to the map call on this array should return a value, otherwise map will always return an array of undefined values. If the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.
 2021-06-07 11:01:10 -07:00
Tyler Leonhardt
e0c8a76b7a don't sort scope list. Fixes Microsoft/vscode-pull-request-github#2751 2021-05-27 16:45:59 -07:00
João Moreno
0637663fcf fix isNoCorsEnvironment 2021-05-27 11:45:12 +02:00
João Moreno
25a12c75c5 use dummy uri 2021-05-19 20:40:07 +02:00
Benjamin Pasero
159479eb5a Allow to show status bar entries with an id and name (fix #74972) 2021-05-19 14:03:37 +02:00
Kevin Abel
4978a1891e Implement GitHub Enterprise authn provider (#115940) 2021-05-07 14:13:11 -07:00
João Moreno
87a33e998d disable edu telemetry on nocors 2021-04-27 16:03:57 +02:00
João Moreno
034157dea8 gh auth: back to prod auth 2021-04-21 15:00:24 +02:00
João Moreno
d60dbbf646 gh auth: fetch json 2021-04-21 10:48:01 +02:00
João Moreno
3668a573ad gh auth: fix staging server selection 2021-04-21 10:06:26 +02:00
João Moreno
820e70a460 gh auth: don't reach out to product.json 2021-04-21 09:31:06 +02:00
Rachel Macfarlane
c67ac5d083 Remove path from github-authentication 2021-04-20 16:49:23 -07:00
João Moreno
7b23ff442e more staging detection (#121769) 
* more staging detection

* check for scheme
 2021-04-20 13:19:06 -07:00
João Moreno
ad3e7ea1c0 gh auth: look at staging query param (#121768) 2021-04-20 13:04:56 -07:00
Rachel Macfarlane
94589129a2 Add experimentation service to github auth extension 2021-04-20 09:25:01 -07:00
João Moreno
a09d640311 github auth: improve test env detection 
cc @RMacfarlane
 2021-04-14 08:59:55 +02:00
Rachel Macfarlane
5b5dd90655 Fix manually providing PAT for GitHub auth, fixes #118675 2021-03-10 14:48:33 -08:00
Rachel Macfarlane
6a6b9a5cc8 Possible fix for #115918 2021-02-22 15:44:38 -08:00
Rachel Macfarlane
78707e2d79 Fix #117098 2021-02-19 14:57:06 -08:00