Commit Graph

121 Commits

Author SHA1 Message Date
Matt Bierner
21ba436c51 Fix one more case of #81320
The markdown link people write may be uri encoded. We need to decode these before trying to open them
2019-10-09 13:01:30 -07:00
Matt Bierner
36aa903d5a Rewrite how we handle links in the md preview
Try to simplify how we resolve links:

- Move most logic out of the preview itself.
- Simplify the amount of rewriting we do in the markdown engine
2019-10-04 17:57:33 -07:00
Matt Bierner
ef698fa6cd Make markdown refresh more stable
Fixes #80680

- Always sync the current preview line number with the editor, even when `scrollEditorWithPreview` is false

- If the md file is focused and refresh is called, do not try resetting the current line to match the editor file. This mainly effects the case where `scrollEditorWithPreview` is false
2019-10-03 13:46:31 -07:00
Konstantin Solomatov
316fd807fe remove docIndex in markdown language extension (#80933) 2019-09-16 10:50:20 -07:00
Johannes Rieken
9aab002dea push workaround for ts-loader weirdness 2019-09-12 09:59:31 +02:00
Matt Bierner
153e063486 Fix markdown preview refresh command potentially resetting preview scroll position to top if focused on preview
Fixes #80680
2019-09-11 20:50:52 -07:00
Konstantin Solomatov
5db460d2fe Fix activation of linters on unopened files caused by markdown plugin (#80506)
* Fix bug causing a large number of linters to be activated due to the markdown extension opening TextDocuments during indexing

* indentation problem

* code review by @OmarTawfik

* revert changed file

* Code review: use nodejs' Buffer

* fix ineffcient code
code review comments

* introduce SkinnyTextLine

* refactor redundant code

* revert changed files

* formatting

* remove empty line
2019-09-11 11:39:08 -07:00
Matt Bierner
2fe62e7dfe Use the document that contains the md link as the resource for getting config, not the target document 2019-09-10 16:31:53 -07:00
Matt Bierner
7a00ddf9f8 Format files for 3.6
Fixes #80118
2019-09-02 21:29:05 -06:00
Matt Bierner
a66e9d4835 Don't dispose markdown preview emitters before firing events
Fixes #79827
2019-08-26 13:40:07 -07:00
Matt Bierner
646d4ddb75 Use _register 2019-08-20 15:07:25 -07:00
Matt Bierner
c5dc9d16be Finalize asWebviewUri api
Fixes #79242

As discussed, renames `toWebviewResource` to `asWebviewUri` to be consistent with the `asAbsolutePath` api naming
2019-08-19 20:18:26 -07:00
Salvador Cabrera
34339f92c4 Fix: Markdown Preview scroll remains same after clicking on some other link #78465
Improves the behavior on how markdown preview behaves when clicking a link
2019-08-19 09:35:06 -05:00
Matt Bierner
1bbf3b3fa6 Add telemetry+warning for webviews that don't have a content security policy
Fixes #79248
2019-08-15 15:16:39 -07:00
Matt Bierner
e1d3dd53d1 Mark static readonly 2019-07-22 16:24:53 -07:00
Matt Bierner
b850405aa6 Merge pull request #76647 from masliu/master
Save resourceColumn for previews, fixes #74008
2019-07-17 16:01:46 -07:00
Matt Bierner
4c07744817 Make sure we handle loading of markdown resources from UNC workspace correctly
Fixes #48403
2019-07-09 15:52:43 -07:00
Matt Bierner
c01a3a718d Use clearer name for csp webview element
#76489
2019-07-09 11:45:20 -07:00
Matt Bierner
a558a9504a Adding toWebviewResource api
For #76489
2019-07-08 18:38:47 -07:00
masliu
173d010b0a Rename sourceViewColumn to resourceColumn 2019-07-04 22:29:23 -04:00
masliu
47f9ed5d22 Save source viewColumn for previews, fixes #74008 2019-07-04 21:37:28 -04:00
Miguel Solorio
05ee90f7fd Merge remote-tracking branch 'origin/master' into misolori/new-icons 2019-06-28 11:05:33 -07:00
Matt Bierner
be41fd02a2 Show document link tooltip first and put click instructions in parens
Fixes #76077

This change also update our standard link hovers to follow this format
2019-06-25 16:38:50 -07:00
Matt Bierner
8119b4aee7 Move the webviewResourceRoot property to be set on each webview instead of as a global property
For #72155

This allows  us to potentially change the resource root per webview
2019-06-24 17:07:06 -07:00
Miguel Solorio
e998949260 Update markdown icons 2019-06-20 11:53:01 -07:00
Matt Bierner
7f3d3d835f Add vscode.env.webviewResourceRoot api
Fixes #72155

Adds a constant to the api that tracks the root path for resources inside of webviews. This is required because we will not be able to use `vscode-resource:` uris on the web. Our current approach is to rewrite the html we are given but there are almost certainly going to be cases where we don't get this quite right.

Adopts the new api for the markdown preview
2019-06-18 22:29:37 -07:00
Matt Bierner
18ba826e67 Markdown previews should be able to load resources from next to where they are running
Add `'self'` to some content security policies for the preview
2019-06-17 11:20:19 -07:00
Matt Bierner
2ad085b5bd Merge pull request #75357 from Olovan/fix_35245
Fix for issue #35245
2019-06-12 16:56:13 -07:00
Micah Smith
01f7276b7e Fix for issue #35245 2019-06-12 14:30:54 -04:00
Matt Bierner
8de74d9255 Extracting common webview elements
Minimizing diff with the iframe based webview branch
2019-06-11 22:45:55 -07:00
Matt Bierner
f3b8d15b0d Add DocumentLink.tooltip api proposal
For #72824
2019-05-23 17:57:04 -07:00
Matt Bierner
71deb5b6ee Extend disposable 2019-05-22 15:25:48 -07:00
Matt Bierner
519eb3690c Extract duplicated escaping code 2019-05-22 15:25:48 -07:00
Matt Bierner
f250d19bb5 Use relative size for markdown code font size
Fixes #74125
2019-05-22 10:53:49 -07:00
Matt Bierner
4470b868a3 Check pending version before updating markdown preview content
For #72671
2019-04-29 13:49:36 -07:00
Matt Bierner
312b09cc6b extract setContent 2019-04-12 14:43:14 -07:00
Matt Bierner
74103c4c8d Don't change preview when click fails but do show an alert 2019-04-12 14:43:14 -07:00
Matt Bierner
3b58a011da Only try/catch openTextDocument 2019-04-12 14:43:14 -07:00
Matt Bierner
c79f1cd8e3 Styling 2019-04-12 14:43:14 -07:00
pkoushik
bda2870db9 fix-71570 Fixed localize string issue 2019-04-06 12:19:10 +05:30
pkoushik
10a4ebf006 Merge remote-tracking branch 'upstream/master' into fix-71570
* upstream/master: (34 commits)
  Fix markdown.styled regression caused by Uri.parse changes
  Process explorer refactoring
  fix compile error
  fix open workspace uri from cli
  Delete deprecated search provider stub
  test dependenices are devDependencies
  Fix default uri when scheme is file
  disable flaky test, #71801
  use `readonly T[]` instead of `ReadonlyArray<T>`
  simplify protocol check
  Let enablment service handles local workspace extensions in remote window
  debt - make ext host init data more complete
  Fix colorization tests
  fixes #71671
  Update grammars
  Add yes-no choice for overwriting existing file for save as
  update distro
  ExtensionEnablementService: - Remove getDisabledExtensions and instead use isEnabled or getEnablementState methods
  Simplify reload action and fix test
  Update distro hash
  ...
2019-04-06 12:17:00 +05:30
Matt Bierner
f44e51ed38 Fix markdown.styled regression caused by Uri.parse changes
Fixes #71802

Uri.parse now defaults to a `file` scheme, which broke this code
2019-04-05 16:05:32 -07:00
pkoushik
3cef5067be fix-71570 Added logic to handle markdown preview update on file rename and delete 2019-04-05 11:38:18 +05:30
Matt Bierner
86fe4b3b1c 💄 2019-04-03 11:37:19 -07:00
Matt Bierner
0ec326531e Use flatten array helper 2019-04-02 17:16:10 -07:00
Matt Bierner
fe01a19db1 Revert change accidentially include in check in 2019-02-20 13:56:58 -08:00
Matt Bierner
178327770c Add lightbulb badge when a preferred fix is available
Fixes #66702
2019-02-20 13:36:44 -08:00
Matt Bierner
038e8d3904 Make markdown extension points dynamic
For #67574

Blocked by #67958
2019-02-05 17:45:11 -08:00
Matt Bierner
8f10101dd4 Create base class for disposable objects 2019-02-05 17:45:11 -08:00
Matt Bierner
476d7fe0ab Refactor markdown contributions
Reducing code duplication and reducing state
2019-02-05 16:56:45 -08:00