Commit Graph

791 Commits

Author SHA1 Message Date
Andre Weinand
ac46ca2a5e make caching more robust; fixes #69534 2019-03-08 17:08:08 +01:00
Daniel Imms
0d9f226bfe Merge pull request #66819 from GabeDeBacker/user/gabrield/extensionCallbackAsTask
User/gabrield/extension callback as task
2019-03-07 13:00:44 -08:00
Peng Lyu
75e711f8a6 seperate acceptInputCommand and additional commands. 2019-03-07 11:34:43 -08:00
Rob Lourens
a09e7bd128 Fix #64575 - delete FileIndexProvider 2019-03-07 05:33:35 +00:00
Peng Lyu
b64a7295b2 Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement 2019-03-06 14:54:42 -08:00
Peng Lyu
ce1cb8a9fc replace draft properties with labels in CommentThread and Comment 2019-03-06 14:29:02 -08:00
Gabriel DeBacker
d5e4009ae9 Remove need for acquiring dimensions for terminal from main thread 2019-03-06 11:47:57 -08:00
Gabriel DeBacker
99cf5e4881 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-03-06 10:30:14 -08:00
Peng Lyu
42194d82a1 Callback for creating new comments 2019-03-06 10:15:51 -08:00
Gabriel DeBacker
8b1b0763a3 Merge with master 2019-03-06 07:44:35 -08:00
Johannes Rieken
763ae0943d eng - some extHost strict-null work 2019-03-06 16:44:15 +01:00
Joao Moreno
e6bc6699a4 strict null checks: extHostSCM 2019-03-06 10:50:07 +01:00
Alex Dima
1d345f0737 URI always needs to be revived after crossing ipc boundaries 2019-03-06 10:19:17 +01:00
Rob Lourens
0710a009f8 Fix #69875 2019-03-05 19:17:54 -08:00
Matt Bierner
db9a994ded Strict null check extHostDiagnostics 2019-03-05 16:53:40 -08:00
Matt Bierner
14c4fde6d6 Strict null check extHostQuickOpen 2019-03-05 16:53:40 -08:00
Matt Bierner
13e394ff45 Strict null fixes for tests 2019-03-05 11:25:32 -08:00
Peng Lyu
e78c2e2a21 less verbose comment controller api 2019-03-04 17:27:19 -08:00
Peng Lyu
e42c30a294 CommentController. 2019-03-04 11:37:18 -08:00
Peng Lyu
15d782f4a4 Update comment range 2019-03-01 10:06:54 -08:00
Gabriel DeBacker
ca923da1d4 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-02-27 10:17:22 -08:00
Peng Lyu
e5dbd34dd3 Merge pull request #69253 from Microsoft/rebornix/commentscontrol
Comments API refactor
2019-02-22 16:54:39 -08:00
Peng Lyu
bb62f5036d Support new comment thread creation. 2019-02-22 16:46:49 -08:00
Peng Lyu
4f249529e8 Commenting Ranges API 2019-02-22 12:05:08 -08:00
Martin Aeschlimann
14f25a6102 "--extensionTestsPath" does not accept uris 2019-02-22 16:22:10 +01:00
isidor
835458245d labelService: register formatters via API. Also expose getSeperator 2019-02-21 10:01:52 +01:00
Peng Lyu
de52daea94 edit/delete command 2019-02-20 16:45:50 -08:00
Peng Lyu
38e0c3f2c2 accept input commands. 2019-02-20 16:45:14 -08:00
Gabriel DeBacker
d728d3dca8 Merge with master 2019-02-20 09:59:44 -08:00
Alex Dima
43f6bf8ff7 Address some null errors (#60565) 2019-02-20 12:05:33 +01:00
Matt Bierner
e9a1cea1fd Strict null fixes in extHost 2019-02-19 16:29:01 -08:00
Gabriel DeBacker
5d1720321d Code review updates 2019-02-19 14:33:25 -08:00
Gabriel DeBacker
f8f8f519d9 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-02-19 10:11:23 -08:00
Sandeep Somavarapu
36e3c88fa4 #68658 Strict null check - ExtHostConfiguration 2019-02-19 12:06:08 +01:00
Alex Dima
b164459bf8 Tweaks for #62079 2019-02-18 16:41:01 +01:00
David Lechner
5f70fddbfa Add editor.indentSize option
This is an attempt to address issue #10339.

Background:

Currently, the `editor.tabSize` option does two things - it specifies the width of the tab character and it specifies how many columns to advance when the tab key is pressed. However, there is code in the wild that has a mix of spaces and tabs that expects these two values to be different.

These generally use and indent size of 2 or 4 and spaces are used for indentation until the indent becomes >= 8. The tab character size is excpected to be 8 and groups of 8 spaces are replaced with a tab character. Indent levels end up looking like 2 spaces, 4 spaces, 6 spaces, 1 tab, 1 tab + 2 spaces, and so on.

Implementation:

In the editor options, a new option, `editor.indentSize` is added. This, in conjunction with `editor.tabSize` has the same semantics as `indent_size` and `tab_width` in the well known [EditorConfig specification][1].

> indent_size: a whole number defining the number of columns used for each indentation level and the width of soft tabs (when supported). When set to "tab", the value of tab_width (if specified) will be used.
>
> tab_width: a whole number defining the number of columns used to represent a tab character. This defaults to the value of indent_size and doesn't usually need to be specified.

[1]: editorconfig.org

The new `indentSize` option takes a numeric value or "tab" just as EditorConfig's `indent_size`. The default value is set to "tab" so that current default behavior of VS Code does not change and existing user settings will not break.

When getting the new `indentSize` option programatically, it always returns a numeric value (just as `tabSize` does when set to the deprecated "auto" value).

In the text editor model, a new property is added for `indentSize`. Unlike the configuration options where the value of one property influences the other, In this code `tabSize` now should only mean "the width of the tab character" and `indentSize` should only mean "how may columns is one indent".

The cursor operations and shift command are updated to reflect these new semantics.
2019-02-18 12:17:13 +01:00
Gabriel DeBacker
a7565721ba Clean up comments, fix some code review issues, and make the exit code optional throughout to make it clear that it isn't always a number 2019-02-17 09:18:41 -08:00
Gabriel DeBacker
fc6f637899 Remove C/CPP tools from built-in extensions 2019-02-17 08:39:00 -08:00
Peng Lyu
67ad526371 comment control. active thread, comment, input update. 2019-02-15 17:48:03 -08:00
Matt Bierner
52f8705214 Strict null work for quick input 2019-02-14 14:33:56 -08:00
Martin Aeschlimann
dd40499fda Use URI for linkDTO 2019-02-14 18:24:32 +01:00
Johannes Rieken
3283483974 add formatter call, use it for no-formatter-case for now #41882 2019-02-14 11:16:32 +01:00
Peng Lyu
54c75aa50b support icons 2019-02-13 19:34:35 -08:00
Johannes Rieken
a45fb4099c make insets fit into layering scheme 2019-02-13 16:23:52 +01:00
Johannes Rieken
ac03e62afc last round of making changes smaller 2019-02-13 15:20:29 +01:00
Johannes Rieken
58d2b5be06 disable event for now, remove extension location from provider 2019-02-13 14:46:31 +01:00
Johannes Rieken
44b7588362 remove getNamedCustomer, connect MainThreadWebview with CodeInsetController 2019-02-13 12:47:46 +01:00
Johannes Rieken
8246c1648f workbenchs/parts became workbench/contrib 2019-02-13 12:47:46 +01:00
Johannes Rieken
ace73c05b7 move rest code code inset to workbench out of (monaco) editor 2019-02-13 12:47:46 +01:00
Rob DeLine
066dfef8f7 Add Code Inset Feature 2019-02-13 12:46:25 +01:00