Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 11:49:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
43,202 Commits 2,494 Branches 340 Tags
ad8d18edf30852403e053d25b51d796b883ea7e4
Commit Graph

492 Commits

Author SHA1 Message Date
Matt Bierner
ad8d18edf3 Match signature context field name to type name 2018-12-04 17:06:59 -08:00
Matt Bierner
5010af1171 Hide infer type suggestions when using broken versions of ts 
Fixes #64395
 2018-12-04 16:18:30 -08:00
Matt Bierner
f264e8f33b Make sure our temp ts directory really exists 
Fixes possible cause of #64132

Some system operations or users may clear out this folder. This should not prevent TS from launching
 2018-12-03 16:24:27 -08:00
Matt Bierner
64117e8fb5 Rename TriggerReason -> TriggerKind 
Fixes #64216
 2018-12-03 13:53:53 -08:00
Matt Bierner
e42d74ce9a Fix completions for intellicode 
IntelliCode uses `insertText`  on all of its suggestions. When completing properties, we were incorrectly assuming that only bracket suggestions would use `insertText`
 2018-12-02 11:53:15 -08:00
Matt Bierner
e39a97deb7 Fix snippet function call completions for intellicode 2018-12-02 11:53:15 -08:00
Matt Bierner
a3378e4342 Add pinning test for bracket completions 2018-11-29 17:09:48 -08:00
Matt Bierner
c5afb50a5b Added test for #63100 2018-11-29 17:09:48 -08:00
Matt Bierner
06a64b097f Extract joinLines 2018-11-29 17:09:48 -08:00
Matt Bierner
beb5998ea3 Correctly sort bracket accessor completions in js/ts completion list 
Fixes #63100

As suggested in  #63100, always set the range for member completions and overwrite the dot
 2018-11-29 15:09:44 -08:00
Matt Bierner
e42051996b Don't trigger parameter hints when completing empty method 
Fixes #64023
 2018-11-29 12:03:36 -08:00
Matt Bierner
3f33ef2593 Support whitespace after dot for bracket completions 
Fixes #64002
 2018-11-29 10:44:27 -08:00
Matt Bierner
cd5b4d1bb3 Use insertText as filterText for js/ts completions by default 
For some completions—such as those provided
 by IntelliCode—the label results in the incorrect sort order. IntelliCode prefixes completion labels with a unicode star, which means they appear after the normal completions

This fix make sure we use the actual text to be inserted for filtering by default instead of the label
 2018-11-28 19:05:40 -08:00
Matt Bierner
364824a864 use simpler typeof check 2018-11-28 19:01:22 -08:00
Peng Lyu
63710859e6 Merge pull request #63792 from vim88/fix_typo_in_comments 
Fixes typo and occurrences of double words in comments.
 2018-11-28 10:54:52 -08:00
Matt Bierner
9d2251469f Do not display errors in editor for cancelled js/ts code lenses 
Fixes #63884

Resolving a code lenses may be cancelled if the document changes. This is normal and should not be displayed as an error in the editor
 2018-11-27 17:11:07 -08:00
Matt Bierner
42145f1f0c Interupt TS references and implementations requests 
Fixes #60213

These are low priority UI elements and should not block user ui requests that come in, such as completions
 2018-11-27 16:48:11 -08:00
Matt Bierner
1a1987dee6 Revert "Delegate js/ts code lenses back to vs code" 
This reverts commit dc47417f54.

We need finer control over how code lenses are resolved. This is required for #60213. Showing all references in the references code lense now requires using ts plugin instead
 2018-11-27 16:48:11 -08:00
Matt Bierner
9461f661f0 Interupt geterror requests for signature help requests 
See 7eed623657 for more details
 2018-11-27 15:12:10 -08:00
Matt Bierner
7eed623657 Interupt geterror requests for getting completion entry details 
UI actions like this should interup potentially long running getError requests on the server. This is because the getErr request must be fully processed before the completion entries can be returned. Explicit user actions in the UI are more important and should be computed as soon as possible
 2018-11-27 14:56:07 -08:00
Matt Bierner
f685215dd4 Adding version info for ts non-code dependencies 
Fixes  #63577
 2018-11-27 11:40:27 -08:00
Matt Bierner
336db91acb Use switch case 2018-11-27 11:40:27 -08:00
Matt Bierner
9531a7c380 💄 2018-11-27 11:40:27 -08:00
Matt Bierner
0c126b0608 Extract display part kinds to constants files 2018-11-27 11:40:27 -08:00
Matt Bierner
bab1ea6c27 💄 2018-11-27 11:40:27 -08:00
Matt Bierner
ca7f6c2cf2 Move snippetForFunctionCall to own file 2018-11-27 11:40:27 -08:00
Matt Bierner
77454b24bc Extract append joined placeholders 2018-11-27 11:40:27 -08:00
Matt Bierner
0aef227bbf Try splitting up parameter list extraction from snippet building 2018-11-27 11:40:27 -08:00
Matt Bierner
61ad185759 Make it clearer that insert text snippets override the rest snippet generation 2018-11-27 11:40:27 -08:00
Matt Bierner
d5843e550f Fix bug for generating snippet if the object type contained a method signature 2018-11-27 11:40:27 -08:00
Matt Bierner
1755715a13 Fix bug where return type containing function type could be merged with normal parameters 2018-11-27 11:40:26 -08:00
Matt Bierner
86d7fd923a Adding pinning test for inline types 2018-11-27 11:40:26 -08:00
Matt Bierner
af05b65331 Adding plnning test for rest paramters 2018-11-27 11:40:26 -08:00
Matt Bierner
e8f00e763a Adding pinning test for getting parameters 2018-11-27 11:40:26 -08:00
Matt Bierner
ece1bad312 Adding basic pinning tests for insert text 2018-11-27 11:40:26 -08:00
Matt Bierner
ec3cba2661 Add test for using insert text 2018-11-27 11:40:26 -08:00
Matt Bierner
ecce9249cb Extract snippetForFunctionCall so that it can be tested 2018-11-27 11:40:26 -08:00
vim88
510d90d11e Fixes typo and occurrences of double words in comments. 2018-11-26 19:57:48 +02:00
isidor
1e3efda93c polish cgmanifest.json 2018-11-20 17:02:09 +01:00
isidor
085f4656ed add some commit hashes and versions to cgmanifest.json 2018-11-20 16:31:08 +01:00
Isidor Nikolic
ec98c79d44 Merge pull request #63497 from Microsoft/isidorn/cgmanifest 
Start using component governance for oss tracking
 2018-11-20 12:54:47 +01:00
isidor
9edd984da8 delete OSSREADME.json 2018-11-20 12:54:22 +01:00
Matt Bierner
02a59c3015 Make CachedResponse generic 2018-11-19 18:48:36 -08:00
Matt Bierner
fabc627634 Move getSymbolRange out of class 2018-11-19 18:46:09 -08:00
Matt Bierner
1f1618d280 Remove extra conditional 
This should always be true
 2018-11-19 18:41:26 -08:00
Matt Bierner
f953906c74 Remove un-needed any cast 2018-11-19 18:24:59 -08:00
Matt Bierner
26cd646618 Remove unnessisary conditional 
The body of these specific events are always non-null
 2018-11-19 16:34:15 -08:00
Matt Bierner
277b96327f Enable loading indicator for subsequent js/ts project loads 
Fixes #62978
 2018-11-19 16:34:15 -08:00
Matt Bierner
b115d8860c Extract loadingIndicator to class 2018-11-19 16:34:15 -08:00
Matt Bierner
300f1b8d98 Extract lazy activation logic 2018-11-19 16:34:15 -08:00