Commit Graph

37 Commits

Author SHA1 Message Date
Benjamin Pasero
7027856936 sessions - allow callback scheme in auth (#298270) 2026-02-27 15:27:08 +00:00
Christof Marti
f5f2ea58fc Rerun fallbacks (#260297) 2025-09-08 16:55:43 +02:00
Tyler James Leonhardt
191be39e5a Make sure the same GitHub account is used until we support multiple GH accounts (#206847)
Fixes https://github.com/microsoft/vscode/issues/203850
2024-03-04 15:01:51 -08:00
Tyler James Leonhardt
5134662139 Remove CredentialsService & keytar (#192224)
* Remove CredentialsService & keytar

ref https://github.com/microsoft/vscode/issues/115215
fixes https://github.com/microsoft/vscode/issues/143395

* compile

* remove imports

* rip the bandaid
2023-09-05 17:47:30 -07:00
Tyler Leonhardt
ac27273e48 Try to revoke tokens that are getting deleted
Best effort.

Fixes https://github.com/microsoft/vscode/issues/152055
2023-07-17 14:12:10 -07:00
Tyler James Leonhardt
013132a5cd Re-work auth flows into separate file (#186939)
The flows are crucial to the extension and I wanted to be able to declare which can be used when in a declarative way. This reworks the flows into that model.

Additionally, it pulls in the Client ID and secret from a config which will allow us to not rely on the vscode.dev proxy on Desktop (because we can make a distro change that includes the secret... which isn't a real secret, says GitHub)... unfortunately we still need to rely on it for Web due to CORS but we're in a position where it will be easy to rip the proxy out when GH supports it.
2023-07-03 15:06:42 -07:00
Tyler James Leonhardt
06eb374137 Improve GHES flow (#172959)
* Improve GHES flow

It's clear to me now that a lot of users of the GHES flow have auth behind a VPN. Something that we cannot support in the OAuth flow because we require making a request to vscode.dev who makes a request to the GHES instance.

In light of this, we will remove the OAuth flow for GHES. Fear not, though... because both the Device Code Flow and the PAT flow are there and the PAT flow has been improved in 1.75... so in conclusion, I think GHES is handled as best we can with this PR.

Additionally, there is some "Hosted GitHub Enterprise" scenarios popping up, and this future proofs that by allowing "Hosted GitHub Enterprise" experiences to go through the OAuth flow because we know for a fact that they will be accessible from vscode.dev.

Fixes #169619
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3398

* Use api. sub domain and update telemetry logic
2023-01-31 13:25:12 -08:00
Tyler James Leonhardt
b9b93f2b45 Depend on platform implementations for common features (#165950)
* don't depend on externals

* remove unneeded externals
2022-11-09 14:29:21 -08:00
Sandeep Somavarapu
35c7ee9d02 Support log output channels for extensions (#161249)
* introduce log api in extension context

* separate registering output vs log channel

* Separate extension log channels in show logs command

* add logging error to embedder logger

* show extension log in the extension editor

* configure log level per extension

* change the order of log entries

* introduce logger

* align with output chanel

* revert changes

* fixes
2022-09-19 09:03:41 -07:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Tyler Leonhardt
5919378269 don't surface error on gets and remove microsoft secret migration. Fixes #146553 2022-04-14 12:18:33 -07:00
Tyler Leonhardt
62866e4fa5 use URL class in a few places 2022-03-29 16:20:08 -07:00
Tyler Leonhardt
b1fb11e18c have code-oss use device code flow 2022-03-28 09:05:28 -07:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler James Leonhardt
f67a8b753f Use device flow over PAT when we are running in a server full environment but not in a supported uri (#139255)
* initial attempt

* use github-authentication instead

* rework error handling

* update copy

* explain why Workspace
2021-12-15 22:07:49 -05:00
Tyler Leonhardt
a3e60d2dff Add messages for rejected promises 2021-12-07 16:23:04 -08:00
Tyler Leonhardt
4d496f61bc remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201 2021-10-25 11:16:37 -07:00
Tyler Leonhardt
520fa49e68 refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck. 2021-08-16 16:34:21 -07:00
Tyler Leonhardt
4a011b5297 add additional logging around github auth 2021-06-28 16:27:52 -07:00
Kevin Abel
4978a1891e Implement GitHub Enterprise authn provider (#115940) 2021-05-07 14:13:11 -07:00
Rachel Macfarlane
78707e2d79 Fix #117098 2021-02-19 14:57:06 -08:00
Rachel Macfarlane
650906c369 Pass scopes through to authentication providers 2021-02-11 14:15:36 -08:00
Rachel Macfarlane
93ae815ba1 Feedback on secrets API #112249 2021-01-20 09:24:48 -08:00
Rachel Macfarlane
ced3bb4bb9 Secrets API feedback 2021-01-05 10:17:05 -08:00
Rachel Macfarlane
7db413d4c1 Move secrets API to extension context 2021-01-04 22:04:40 -08:00
Rachel Macfarlane
31419adc34 Polish onDidChangePassword changes 2020-10-12 10:31:16 -07:00
Rachel Macfarlane
4c0811c9c2 Removing polling from auth extensions, fixes #107480 2020-10-09 16:33:53 -07:00
Rachel Macfarlane
dafce599a6 Add getPassword, setPassword, and deletePassword APIs, #95475
Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2020-10-06 14:57:16 -07:00
Matt Bierner
50cc1d0e97 Update to use TS 4.1 for building VS Code 2020-09-16 11:58:01 -07:00
Eric Amodio
774c4baa8f Adapts extension to work on the web/serverless 2020-06-08 18:13:26 -04:00
Rachel Macfarlane
a6c47beb1b Remove unused code in github auth provider 2020-05-27 09:37:54 -07:00
Rachel Macfarlane
8c50263c35 Show notification when writing to keychain fails, #92972 2020-03-25 16:25:44 -07:00
Rachel Macfarlane
d9d90a0d3d Use GitHub app for VSO, closes #92675 2020-03-23 07:52:22 -07:00
Rachel Macfarlane
d21cadb83f Use fs to read github auth config file 2020-03-23 07:52:22 -07:00
Rachel Macfarlane
bf0a32e729 Add support for other vscode environments for github auth 2020-02-24 11:14:11 -08:00
Rachel Macfarlane
167c422e4b Handle no github auth config 2020-02-20 14:38:10 -08:00
Rachel Macfarlane
eed39324b6 Add GitHub authentication provider extension, closes #90384 2020-02-20 10:56:16 -08:00