Tyler Leonhardt
520fa49e68
refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck.
2021-08-16 16:34:21 -07:00
Tyler Leonhardt
a8332b75e4
delete extra afterTokenLoad
2021-08-03 16:24:28 -07:00
Tyler Leonhardt
37a8fe959c
no longer call /user to verify tokens
2021-08-03 14:50:07 -07:00
Tyler Leonhardt
c7e45c4fa4
Add a bunch of logging to github-authentication
...
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com >
2021-07-23 15:28:06 -07:00
Tyler Leonhardt
c1b4cf00b9
update auth extensions to use packageJSON property instead
2021-07-23 11:48:39 -07:00
Tyler Leonhardt
8a4ace6ebf
maintain promise instead in github-auth to ensure the exp service doesn't get created twice
2021-07-23 09:24:40 -07:00
Tyler Leonhardt
a8134002cd
lazily load experimentation service in github-authentication
2021-07-23 09:07:41 -07:00
Tyler Leonhardt
54a2e15f6b
remove unused variable
2021-07-22 17:40:13 -07:00
Tyler Leonhardt
3ed425bef9
Rework github authentication extension to make less HTTP requests.
...
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com >
2021-07-22 17:25:59 -07:00
VocalTrance
715798221b
Fix typo in github-authentication/github.ts ( #129100 )
2021-07-21 06:30:45 -07:00
Tyler James Leonhardt
87d692b7bf
Add scopes property to login telemetry ( #128261 )
...
* Add scopes property to login telemetry
2021-07-08 21:48:44 -07:00
Tyler Leonhardt
1d1b9961d7
sort scopes on filter for getSessions in the github auth provider. Fixes https://github.com/github/codespaces/issues/3109
2021-06-30 10:15:24 -07:00
Tyler Leonhardt
6b6be7efe1
just return if the acceptedStates don't match fixes #126084
2021-06-28 17:12:06 -07:00
Tyler Leonhardt
4a011b5297
add additional logging around github auth
2021-06-28 16:27:52 -07:00
Kai Maetzel
c200dc4909
fix isNoCorsEnvironment ( #126718 )
2021-06-18 17:36:59 -07:00
Oleg Demchenko
61f34055fa
Auth session API fix ( #125792 )
...
* Adjust "provider is not registered" exception behavior
* Process cancellation in GH auth provider
`e.message` is always `undefined`
2021-06-10 20:14:08 +00:00
Matvii Hodovaniuk
67561036cf
Replace map with forEach ( #115378 )
...
The callback provided to the map call on this array should return a value, otherwise map will always return an array of undefined values. If the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.
2021-06-07 11:01:10 -07:00
Tyler Leonhardt
e0c8a76b7a
don't sort scope list. Fixes Microsoft/vscode-pull-request-github#2751
2021-05-27 16:45:59 -07:00
João Moreno
0637663fcf
fix isNoCorsEnvironment
2021-05-27 11:45:12 +02:00
João Moreno
25a12c75c5
use dummy uri
2021-05-19 20:40:07 +02:00
Benjamin Pasero
159479eb5a
Allow to show status bar entries with an id and name ( fix #74972 )
2021-05-19 14:03:37 +02:00
Kevin Abel
4978a1891e
Implement GitHub Enterprise authn provider ( #115940 )
2021-05-07 14:13:11 -07:00
João Moreno
87a33e998d
disable edu telemetry on nocors
2021-04-27 16:03:57 +02:00
João Moreno
034157dea8
gh auth: back to prod auth
2021-04-21 15:00:24 +02:00
João Moreno
d60dbbf646
gh auth: fetch json
2021-04-21 10:48:01 +02:00
João Moreno
3668a573ad
gh auth: fix staging server selection
2021-04-21 10:06:26 +02:00
João Moreno
820e70a460
gh auth: don't reach out to product.json
2021-04-21 09:31:06 +02:00
Rachel Macfarlane
c67ac5d083
Remove path from github-authentication
2021-04-20 16:49:23 -07:00
João Moreno
7b23ff442e
more staging detection ( #121769 )
...
* more staging detection
* check for scheme
2021-04-20 13:19:06 -07:00
João Moreno
ad3e7ea1c0
gh auth: look at staging query param ( #121768 )
2021-04-20 13:04:56 -07:00
Rachel Macfarlane
94589129a2
Add experimentation service to github auth extension
2021-04-20 09:25:01 -07:00
João Moreno
a09d640311
github auth: improve test env detection
...
cc @RMacfarlane
2021-04-14 08:59:55 +02:00
Rachel Macfarlane
5b5dd90655
Fix manually providing PAT for GitHub auth, fixes #118675
2021-03-10 14:48:33 -08:00
Rachel Macfarlane
6a6b9a5cc8
Possible fix for #115918
2021-02-22 15:44:38 -08:00
Rachel Macfarlane
78707e2d79
Fix #117098
2021-02-19 14:57:06 -08:00
Rachel Macfarlane
4e19a9f16a
Update telemetry classification type for isEdu check
2021-02-17 11:36:29 -08:00
Rachel Macfarlane
2f277cb41e
Add github session telemetry event
2021-02-12 15:39:04 -08:00
Rachel Macfarlane
14669c2e45
Make scopes parameter optional to getSessions and remove getAllSessions
2021-02-12 09:13:11 -08:00
Rachel Macfarlane
eceff53351
Rename login/logout to createSession/removeSession
2021-02-11 16:46:47 -08:00
Rachel Macfarlane
650906c369
Pass scopes through to authentication providers
2021-02-11 14:15:36 -08:00
Rachel Macfarlane
9118a3461c
Make onDidChangeSessions event for auth providers fire complete session
2021-02-11 10:14:28 -08:00
Rachel Macfarlane
93ae815ba1
Feedback on secrets API #112249
2021-01-20 09:24:48 -08:00
Rachel Macfarlane
c85297669e
Move id, label, and options to authentication provider registration
2021-01-11 10:53:17 -08:00
Rachel Macfarlane
ced3bb4bb9
Secrets API feedback
2021-01-05 10:17:05 -08:00
Rachel Macfarlane
998e5e2ea6
onDidChangePassword -> onDidChange in secrets API
2021-01-04 22:20:07 -08:00
Rachel Macfarlane
7db413d4c1
Move secrets API to extension context
2021-01-04 22:04:40 -08:00
Rachel Macfarlane
03c38e6702
Add more logging to github auth provider
2020-11-06 15:10:09 -08:00
Rachel Macfarlane
4059ff428f
Allow cancelling GitHub sign in, fixes #109101
2020-11-05 16:39:25 -08:00
Alex Ross
04863391e9
Fix scope checking mismatch ( #109665 )
2020-10-29 17:05:21 -07:00
Rachel Macfarlane
928e79f838
Verify GitHub tokens on auth provider start, fixes #108680
2020-10-26 16:01:58 -07:00
