Commit Graph

9 Commits

Author SHA1 Message Date
Matt Bierner b0dccbcf75 Marking a bunch of static variables as readonly
Readonly helps out with TS's type guards and is also a good best practice. Specifically, readonly strings/numbers have their literal type instead of a generic `string` | `number` type, which can help catch dead code and some common programming mistakes
2019-10-07 15:40:02 -07:00
Benjamin Pasero 3e439112ba debt - clean up platform/electron-main (part 1) 2019-09-17 15:30:00 +02:00
Benjamin Pasero 64c3f1a93e debt - reduce explicit any or casts 2019-04-01 08:11:11 +02:00
Benjamin Pasero 622b3d62dd paths - paths.node.ts => path.ts 2019-02-12 20:36:23 +01:00
SteVen Batten 5ebd625b40 use new path implementation (#68538)
* adopt paths.node over path

* fix strict null

* remove hacky typing inlabel.test.ts
2019-02-12 20:14:50 +01:00
Matt Bierner 087629786a Mark private service properties declarated in ctors as readonly 2019-01-04 12:03:24 -08:00
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Benjamin Pasero f38b0ca033 fix build 2018-11-21 10:11:20 +01:00
Benjamin Pasero 2c9722a4c8 Clean up unused empty workspace storage folders (#63554)
* wip

* 💄
2018-11-21 09:41:24 +01:00