Matt Bierner
b4f6130fe4
Fix some compile errors resutling from readonly change
2019-06-12 16:54:16 -07:00
Matt Bierner
a6a376e933
Merge pull request #75092 from microsoft/dev/mjbvz/readonly-diagnostics-api
...
Use readonly arrays for the vscode.DiagnosticCollection api
2019-06-12 14:46:17 -07:00
Joao Moreno
718f19e8ab
💄
2019-06-12 12:40:16 +02:00
Joao Moreno
fee4ee0df8
Merge commit 'refs/pull/69763/head' of github.com:Microsoft/vscode into pr/69763
2019-06-12 12:35:24 +02:00
Joao Moreno
b485ffb756
fix git nls
2019-06-12 12:02:58 +02:00
Joao Moreno
4a3c056e9a
use --follow-tags instead of --tags when pushing
...
fixes #70081
fixes #75240
2019-06-12 11:06:54 +02:00
Joao Moreno
13d0dad699
fix #41085
2019-06-12 10:38:35 +02:00
Matt Bierner
8de74d9255
Extracting common webview elements
...
Minimizing diff with the iframe based webview branch
2019-06-11 22:45:55 -07:00
Matt Bierner
1f4e2a21fc
Add support for loading contributed TS version
...
Fixes https://github.com/microsoft/vscode/issues/75222
Fixes https://github.com/microsoft/TypeScript/issues/31623
2019-06-10 15:42:35 -07:00
Matt Bierner
a1c33c6c12
Don't try creating untitled files in a refactoring
...
Fixes #75132
2019-06-10 11:11:12 -07:00
Matt Bierner
8448512143
Use readonly arrays for the vscode.DiagnosticCollection api
...
## Problem
The diagnostic collection object is set up so that it does not mutate the arrays of diagnostics you pass to it. It also does not expect or allow mutation of diagnostics that it returns.
However it it currently typed using normal arrays. This means that if an extension (such as JS/TS) wishes to use readonly diagnostics intnernally, it cannot do so without casting.
## Proposed Fix
Use `ReadonlyArray` in diagnostic collection. This should be a safe change for the `set` type methods. The changes to `get` and `forEach` have the risk of breaking the typing of some extensions, but `get` already returned a frozen array of diagnostic so trying to mutate the array itself would have resulted in runtime error.
2019-06-07 11:41:33 -07:00
Matt Bierner
dc2245f164
Use readonlyArray for diagnostics
2019-06-07 11:25:16 -07:00
Matt Bierner
dc8e21138f
Extend disposable
2019-06-07 11:23:14 -07:00
Matt Bierner
69a7b7ef24
Extract areLanguageDiagnosticSettingsEqual
2019-06-07 11:22:06 -07:00
Matt Bierner
a87c73527e
Remove extra work in DiagnosticSettings ctor
...
The langauges map is written so that it is lazy. We do not need to pre-populate it
2019-06-07 11:21:22 -07:00
Matt Bierner
5b01e094c2
Use includes instead of indexOf
2019-06-07 11:12:54 -07:00
Martin Aeschlimann
af4221b242
Git Diffs in Solarized Light have inappropriate colours. Fixes #75037
2019-06-07 14:39:53 +02:00
Martin Aeschlimann
b994c2d38d
test resolver polish
2019-06-07 13:08:25 +02:00
Martin Aeschlimann
7af0fa1cf8
update test-resolver
2019-06-07 12:44:32 +02:00
Martin Aeschlimann
39ec656916
minimize distro deltas
2019-06-07 11:30:24 +02:00
Martin Aeschlimann
64d254c9bd
adopt test resolver
2019-06-07 09:33:17 +02:00
Aurélien Pupier
7a5bca9faf
Add License field to package.jsons #68423 ( #68771 )
...
it should avoid to have "warning XXX: No license field" during yarn
build
Signed-off-by: Aurélien Pupier <apupier@redhat.com >
2019-06-06 11:44:50 +02:00
Martin Aeschlimann
3ce5cb0e02
[css] enable tests ( fixes #74937 )
2019-06-06 09:49:55 +02:00
Martin Aeschlimann
29daecda2e
[css] add test resources
2019-06-06 09:30:58 +02:00
Benjamin Pasero
fc294b683d
Comment out failing test
2019-06-06 07:42:18 +02:00
Matt Bierner
b33f52a46e
Update highlightjs version
2019-06-05 15:41:45 -07:00
Matt Bierner
809386b670
Working on getting ts server class in a testable state
2019-06-05 15:41:45 -07:00
Alex Ross
2472084ffc
Remove .desktop from ini extention
...
Fixes #74866
2019-06-05 16:08:26 +02:00
Waldir Pimenta
f3e4e47164
Fix spelling of the example abbreviation (e.g.)
2019-06-05 16:00:26 +02:00
Martin Aeschlimann
8f72934706
[css] resolve modules without require
2019-06-05 13:04:58 +02:00
Johannes Rieken
97ce638677
unblock webpack build
2019-06-05 11:57:56 +02:00
Joao Moreno
a83c9a4756
fixes #74844
2019-06-05 10:22:48 +02:00
Joao Moreno
afa4faa587
fix git extension tests
2019-06-05 10:22:48 +02:00
Benjamin Pasero
d78a75973c
update @types/node ( #74881 )
2019-06-05 10:20:01 +02:00
Martin Aeschlimann
be547e26fc
fixes for remote smoke tests against a build
2019-06-05 09:38:02 +02:00
Benjamin Pasero
d7977c880f
debt - use @types/node: 10 for all extensions
2019-06-05 09:32:36 +02:00
Rob Lourens
20ec76e47b
Merge pull request #74802 from remcohaszing/xdg-basedir-git-config
...
mark .config/git/config as properties file
2019-06-04 14:14:16 -07:00
Alex Ross
676368aa81
Update C, C++, Objective-C, and Objective-C++ grammars
...
Also includes corresponding theme changes
Fixes #74450
2019-06-04 16:20:40 +02:00
Christof Marti
21aa8afdd0
Git-UI extension for Git credentials ( #74461 )
2019-06-04 16:14:34 +02:00
Martin Aeschlimann
f256ab1c1e
[css] fix test
2019-06-04 11:26:30 +02:00
Martin Aeschlimann
ae6be63698
[css server] link tests
2019-06-04 10:35:58 +02:00
Martin Aeschlimann
df9b668167
Merge pull request #70693 from penx/feature/node-module-resolution-for-css-import
...
Node module resolution for CSS import
2019-06-04 09:53:47 +02:00
Matt Bierner
5ce891fae1
Merge pull request #74646 from mjbvz/dont-update-js-ts-diagnostics-if-they-have-not-changed
...
Don't update js ts diagnostics if they have not changed
2019-06-03 11:35:48 -07:00
Remco Haszing
dc20cfcc4f
mark .config/git/config as properties file
...
Git suppots the XDG base directory standard for its global configuration file.
This defaults to ~/.config/git/config. Now VSCode also highlights this file
properly as long as it’s in the default location.
2019-06-03 20:27:35 +02:00
Alex Ross
96410ff870
Update grammars
2019-06-03 12:01:42 +02:00
Matt Bierner
76e774e4bd
Add arrays.empty
...
This helps with `a === b` checks in arrays.equals
2019-05-30 17:22:38 -07:00
Matt Bierner
015f1c7909
Use array prototype instead of creating instance
2019-05-30 17:13:10 -07:00
Matt Bierner
a8a0fa763f
Use every for equals
2019-05-30 17:01:10 -07:00
Matt Bierner
55d6317a4f
Don't update js/ts diagnostics if they have not changed
...
Fixes #74633
This was the indirect cause of #74633 . See that issue for an explaination of why it was problematic. In summary, updating diagnostics can retrigger code actions even if the user facing diagnostics have not actually changed
2019-05-30 16:59:32 -07:00
Matt Bierner
e9c5066315
Pick up TS 3.5.1 final
2019-05-29 21:41:46 -07:00