Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
102,429 Commits 2,500 Branches 340 Tags
b9b93f2b45aa90e4d5f3b80351145d6f61203922
Commit Graph

66 Commits

Author SHA1 Message Date
Tyler James Leonhardt
b9b93f2b45 Depend on platform implementations for common features (#165950) 
* don't depend on externals

* remove unneeded externals
 2022-11-09 14:29:21 -08:00
Tyler James Leonhardt
9b3e147d6d GitHub Enterprise Auth improvements (#165082) 
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
  * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  * misc style (`private` usage, better `disposable` handling)
 2022-10-31 12:18:54 -07:00
Tyler James Leonhardt
0091bcae20 Fixes #164073 (#164384) 
Fixes #164073
 2022-10-23 17:47:27 +02:00
Tyler James Leonhardt
6684350a58 Onboard GitHub & Microsoft auth extensions to l10n (#163662) 
* onboard github-auth completely to l10n

* onboard microsoft-authentication entirely on to l10n
 2022-10-14 08:41:21 -07:00
Tyler James Leonhardt
2457d9eb46 Plumbing for desktop to pick up strings from language packs (#163494) 
Web will come in the next PR (hence the TODO)

Also this includes the smallest translation change which will be the ultimate test that this is all working.
 2022-10-12 17:08:27 -07:00
Tyler James Leonhardt
fc1ef74eb0 GHES oauth flow support (#160679) 
* GHES oauth flow support

* update server number

* delete testing line
 2022-09-14 11:26:02 -07:00
Tyler James Leonhardt
13066d79e3 up timeout to 5min (#156846) 2022-08-01 17:15:52 -07:00
Logan Ramos
3a8b1fe03e More telemetry comments (#150303) 
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
 2022-05-24 16:00:55 -07:00
Tyler Leonhardt
842a41c8ab add additional log statement 2022-04-27 15:38:56 -07:00
Tyler Leonhardt
a900709990 better handling of prompting and ensure PAT doesn't show up in supported products 2022-04-25 17:27:26 -07:00
Tyler Leonhardt
ed6d360182 add fallback auth server for github auth and better fallback logic 2022-04-15 15:48:29 -07:00
Tyler Leonhardt
62866e4fa5 use URL class in a few places 2022-03-29 16:20:08 -07:00
Tyler Leonhardt
bee517564c remove leading / so that local dev would work 2022-03-23 16:03:26 -07:00
Tyler Leonhardt
39c6779828 depend on stable vscode.dev for auth extensions 2022-03-21 09:35:34 -07:00
Tyler James Leonhardt
18df55c4d4 Use vscode.dev for GH auth (#145424) 
* Use vscode.dev for GH auth

* use correct urls and fix URLSearchParams typing
 2022-03-18 15:58:44 -07:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler Leonhardt
c68d433ac8 copy & continue. Fixes microsoft/vscode-internalbacklog#2613 2022-01-27 16:55:27 -08:00
svennergr
22e45e9f88 Add proper error message on getUserInfo (#140277) 
* Add proper error message on getUserInfo

* improved error message on getUserInfo

either display the response message or the http status text

Co-authored-by: Sven Grossmann <mail@grossmann.dev>
 2022-01-10 11:35:20 -08:00
Tyler James Leonhardt
f67a8b753f Use device flow over PAT when we are running in a server full environment but not in a supported uri (#139255) 
* initial attempt

* use github-authentication instead

* rework error handling

* update copy

* explain why Workspace
 2021-12-15 22:07:49 -05:00
Joyce Er
b97ab80c18 Fix typo in PAT auth flow error message 2021-10-20 16:37:02 -07:00
João Moreno
a390f81744 no hack is better hack 
Co-authored-by: Tyler <TylerLeonhardt@users.noreply.github.com>
 2021-10-11 18:02:36 +02:00
Tyler Leonhardt
5364c56768 include insiders.vscode in nocors 2021-10-08 11:32:28 -07:00
Logan Ramos
420436d4c4 Fix #133493 2021-09-21 13:36:30 -04:00
Tyler Leonhardt
520fa49e68 refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck. 2021-08-16 16:34:21 -07:00
Tyler Leonhardt
a8134002cd lazily load experimentation service in github-authentication 2021-07-23 09:07:41 -07:00
Tyler Leonhardt
6b6be7efe1 just return if the acceptedStates don't match fixes #126084 2021-06-28 17:12:06 -07:00
Tyler Leonhardt
4a011b5297 add additional logging around github auth 2021-06-28 16:27:52 -07:00
Kai Maetzel
c200dc4909 fix isNoCorsEnvironment (#126718) 2021-06-18 17:36:59 -07:00
João Moreno
0637663fcf fix isNoCorsEnvironment 2021-05-27 11:45:12 +02:00
João Moreno
25a12c75c5 use dummy uri 2021-05-19 20:40:07 +02:00
Benjamin Pasero
159479eb5a Allow to show status bar entries with an id and name (fix #74972) 2021-05-19 14:03:37 +02:00
Kevin Abel
4978a1891e Implement GitHub Enterprise authn provider (#115940) 2021-05-07 14:13:11 -07:00
João Moreno
87a33e998d disable edu telemetry on nocors 2021-04-27 16:03:57 +02:00
João Moreno
034157dea8 gh auth: back to prod auth 2021-04-21 15:00:24 +02:00
João Moreno
d60dbbf646 gh auth: fetch json 2021-04-21 10:48:01 +02:00
João Moreno
3668a573ad gh auth: fix staging server selection 2021-04-21 10:06:26 +02:00
João Moreno
7b23ff442e more staging detection (#121769) 
* more staging detection

* check for scheme
 2021-04-20 13:19:06 -07:00
João Moreno
ad3e7ea1c0 gh auth: look at staging query param (#121768) 2021-04-20 13:04:56 -07:00
Rachel Macfarlane
94589129a2 Add experimentation service to github auth extension 2021-04-20 09:25:01 -07:00
João Moreno
a09d640311 github auth: improve test env detection 
cc @RMacfarlane
 2021-04-14 08:59:55 +02:00
Rachel Macfarlane
5b5dd90655 Fix manually providing PAT for GitHub auth, fixes #118675 2021-03-10 14:48:33 -08:00
Rachel Macfarlane
6a6b9a5cc8 Possible fix for #115918 2021-02-22 15:44:38 -08:00
Rachel Macfarlane
78707e2d79 Fix #117098 2021-02-19 14:57:06 -08:00
Rachel Macfarlane
4e19a9f16a Update telemetry classification type for isEdu check 2021-02-17 11:36:29 -08:00
Rachel Macfarlane
2f277cb41e Add github session telemetry event 2021-02-12 15:39:04 -08:00
Rachel Macfarlane
4059ff428f Allow cancelling GitHub sign in, fixes #109101 2020-11-05 16:39:25 -08:00
Alex Ross
04863391e9 Fix scope checking mismatch (#109665) 2020-10-29 17:05:21 -07:00
Rachel Macfarlane
928e79f838 Verify GitHub tokens on auth provider start, fixes #108680 2020-10-26 16:01:58 -07:00
Rachel Macfarlane
102e0e6d84 Handle incomplete login requests gracefully, fixes #109102 2020-10-23 09:45:50 -07:00
Rachel Macfarlane
64d64c70ff Check token scopes for manually provided tokens 2020-10-06 16:16:57 -07:00