Commit Graph
5 Commits
Author SHA1 Message Date
Ulugbek Abdullaev bc199fbbe9 completions: keep instantiated ghost text provider in a service such that it can be shared between joint and normal providers (#2405)
because ghost text provider leaks and creating two of them results in a leak
2025-12-04 20:20:41 +00:00
Ulugbek AbdullaevandCopilot ebe02c12e5 nes: joint: tweakable yielding strategies where NES yields to completions (#2397)
nes: simplify handling of NES endOfLife

nes: joint provider: yield to NES if last suggestion was NES and it agrees with users edits

Update src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

nes: dispose JointCompletionsProvider

nes: rework logic

this has a bug that completions gets triggered along with NES on cursor move -- it's very bad for completions because it has no debounce AND it would get cancellation on cursor move

nes: remove unused setting

nes: update lastNesSuggestion only if latest invocation

nes: fix imports

nes: remove unused param

nes: remove redundant check

nes: fix: correctly cancel completions when NES is picked
2025-12-04 19:29:51 +00:00
cba24cc26d nes: joint provider: yield to NES if last suggestion was NES and it agrees with users edits (#2386)
* nes: joint: tweakable yielding strategies

* nes: simplify handling of NES endOfLife

* nes: joint provider: yield to NES if last suggestion was NES and it agrees with users edits

* Update src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-12-04 14:05:55 +00:00
Henning Dieterichsandulugbekna 6f28b3e7d4 JointInlineCompletionProvider fixes (#2291)
* JointInlineCompletionProvider fixes

* careful to not error if nes provider is undefined

---------

Co-authored-by: ulugbekna <ulugbekna@gmail.com>
2025-12-01 12:05:19 +00:00
Ulugbek Abdullaev 89db6859e2 nes: implement JointCompletionsProvider (#2249)
* nes: refactor: separate InlineEditFeature from its contribution

I want to have `InlineEditFeature`'s code as reusable pieces such that a SingularCompletionsProvider can reuse those

* completions-core: use a more precise return type for provide method

* nes: implement JointCompletionsProvider
2025-11-28 10:38:16 +00:00