Commit Graph

25773 Commits

Author SHA1 Message Date
Rachel Macfarlane f1dcaaea48 Some styling tweaks, fix status calculation 2018-05-21 16:17:07 -07:00
Rachel Macfarlane f86589cd3f Workaround for comments panel not opening 2018-05-21 15:11:29 -07:00
Rachel Macfarlane 072e970249 Some small fixes to overview page, fix remaining build errors 2018-05-21 14:12:24 -07:00
Peng Lyu afc5558f7e fix build error for upstream merging 2018-05-21 12:08:20 -07:00
Peng Lyu 777075998b fix failure for api change 2018-05-18 17:03:12 -07:00
Peng Lyu 9acfd66aa0 Merge remote-tracking branch 'upstream/master' into rebornix/review 2018-05-18 10:16:19 -07:00
Peng Lyu 5d6cca6013 update comments in editor when a data provider is registered. 2018-05-18 10:03:59 -07:00
isidor 19a13966ec show debug actions bar also while initatising
fixes #47863
2018-05-18 15:35:30 +02:00
isidor 416f24c4ad allow to stop an initialising session
fixes #47863
2018-05-18 15:33:21 +02:00
isidor b6a508818f minor polish 2018-05-18 15:00:00 +02:00
Isidor Nikolic c3e6a8e198 Merge pull request #49971 from Krzysztof-Cieslak/addIsPanelVisible
Add activePanel context key
2018-05-18 14:58:28 +02:00
Sandeep Somavarapu 186eb2a582 Fix #50041 2018-05-18 09:57:09 +02:00
Rob Lourens be48c9e2fe Remove unneeded file search test helper 2018-05-17 22:01:48 -07:00
Rob Lourens 912fff91ac Change File search result API to only return a string relative path to the search folder 2018-05-17 21:51:10 -07:00
Rob Lourens 707a20f4af Change TextSearchResult API to only return a string relative path to the search folder 2018-05-17 21:25:47 -07:00
Rob Lourens 501502c5c1 Add "showLoading" option to tree to allow trees to opt out of the loading indicator, since setTimeout/clearTimeout has a large perf impact 2018-05-17 18:49:57 -07:00
Rob Lourens 7a14a0d046 Settings editor - left-align "open in settings.json" button 2018-05-17 18:49:57 -07:00
mkavidas c0ec198cbe grammer fix (#50063) 2018-05-17 17:57:31 -07:00
DongWei fc4f4b550c Fix doc comments and remove duplicate number in an array (#50072) 2018-05-17 17:56:44 -07:00
Matt Bierner fb11a4dd1f Fix webview contents not getting focus
Fixes #49997
2018-05-17 17:17:25 -07:00
Matt Bierner c49ed9cc50 Mark unused parameters 2018-05-17 17:01:55 -07:00
Matt Bierner 76da7baa4f _private 2018-05-17 16:25:58 -07:00
Matt Bierner 8bb27cd255 Add unused diagnostic subtype (#49646)
* Add unused diagnostic subtype

Fixes #15710

Adds a new `DiagnosticTag` class that provide additional information about a diagnostic. Introduce `DiagnosticTag.Unnecessary` to mark when a diagnostic is for unused / unnecessary code

The design comes from Rosyln's diagnostic object and allows us to modify how a diagnostic is rendered without changing its serverity.

Hooks up JS and TS to use this new tag. This is controlled by the `javascript.showUnused.enabled` setting which is enabled by default

- Introduce a new diagnostic severity for unused.

    However, using this approach, if a user sets `noUnusedLocals` in their `tsconfig.json`, the resulting diagnostic could only show the squiggly OR be grayed out. Using `customTags` allows us to support both graying out and showing the squiggly

- Custom JS/TS implementation using decorators

    Not themable. We want a standard experience across languages.

* - Move to proposed
- Use numeric enum
2018-05-17 15:43:59 -07:00
Rob Lourens a9d3a477dd EH search - remove slow ES5 async/await from inner loop 2018-05-17 11:56:05 -07:00
Rob Lourens 9b4656e6bc EH search - send limitHit result back to frontend 2018-05-17 11:56:05 -07:00
Rob Lourens fcd601053f EH search - add simple search duration log 2018-05-17 11:56:05 -07:00
Rob Lourens cf06508603 EH search - implement max results for text search on the ExtHostSearch side 2018-05-17 11:56:05 -07:00
Daniel Imms 2dc157b477 Merge pull request #50060 from Microsoft/tyriar/dom_render_notification
Terminal DOM render notification
2018-05-17 11:17:02 -07:00
Peng Lyu b2300ee2da dispose empty comment widget and hide others. 2018-05-17 11:06:02 -07:00
Peng Lyu 31acdf58db remove duplicate comment editor background. 2018-05-17 10:38:45 -07:00
Daniel Imms e75c664977 Add link, restore old render function 2018-05-17 10:34:12 -07:00
Rachel Macfarlane 414bc2c081 Render comments as markdown in comments panel 2018-05-17 10:21:19 -07:00
Daniel Imms e48a7d8946 Tweak dom renderer message 2018-05-17 10:21:09 -07:00
Peng Lyu ca4f18dca9 remove unsed command service and reorder constructor paramaters. 2018-05-17 10:18:55 -07:00
Daniel Imms 84eb4778f1 Show notification for DOM renderer
Part of #46954
2018-05-17 10:18:41 -07:00
Sandeep Somavarapu fbf1fefaae Merge pull request #49970 from Microsoft/sandy081/treeViewApi
Add following to TreeView
2018-05-17 16:48:45 +02:00
Sandeep Somavarapu 58064599c5 Call selected elements - selection 2018-05-17 16:48:09 +02:00
Sandeep Somavarapu 3fbd21a593 Fix jumping viewlet header when single view 2018-05-17 16:44:36 +02:00
Sandeep Somavarapu 7ed2a1d3d7 #47262 Fix tests 2018-05-17 15:50:15 +02:00
Johannes Rieken 6152160e86 wait a little when between edits the ratio of symbols and lines changes by more than half, #49975 2018-05-17 15:19:25 +02:00
Isidor Nikolic 19bf185257 Merge pull request #50003 from Krzysztof-Cieslak/prefixFileNameIncremenr
Add prefix case for incrementFileName
2018-05-17 14:41:17 +02:00
Krzysztof Cieslak 5044744abc Add more separators and support for trailing zeros 2018-05-17 14:29:51 +02:00
Sandeep Somavarapu aa54908ca2 FIx #47262 2018-05-17 12:58:33 +02:00
Johannes Rieken 5ec3672559 debounce at 150ms rate, #49975 2018-05-17 12:03:35 +02:00
Johannes Rieken cc83c18dd9 fix #49582 2018-05-17 12:00:30 +02:00
Krzysztof Cieslak a707e00fea Add tests for incrementFileName 2018-05-17 11:18:09 +02:00
Krzysztof Cieslak 42ab584032 Add case for prefix version for folder 2018-05-17 11:15:41 +02:00
Benjamin Pasero 8835c06e1a editor - move some workbench specific commands to workbench 2018-05-17 11:00:44 +02:00
Johannes Rieken 49323b3798 explore Hierarchy<T> idea, #34968 2018-05-17 10:40:08 +02:00
Johannes Rieken 72e6a7d66e fix #50024 2018-05-17 09:02:58 +02:00