Commit Graph

29 Commits

Author SHA1 Message Date
Copilot 0231690206 Fix ipynb deserialization crash when cells lack metadata field (#282878)
* Initial plan

* Fix ipynb deserialization when cells lack metadata field

Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>

* Fix test

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
2025-12-12 05:36:03 +00:00
Don Jayamanne dd2c3af375 Remove as any from ipynb (#277057)
* Remove `as any` from ipynb

* Fixes

* updates
2025-11-13 09:30:35 +01:00
Matt Bierner 360c9fd134 Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Ladislau Szomoru 4d7c56ee82 Engineering - Add GitHub action for pull requests (#254056)
* Test - handle running tests as part of a GitHub action

* Add GitHub action files
2025-07-04 08:21:56 +00:00
Aaron Munger fa298e0de0 skip flaky test (#251158) 2025-06-10 15:50:26 -07:00
Aaron Munger 10066c9ec3 more certainty for resuming the paused emitter (#251130) 2025-06-10 12:30:54 -07:00
Don Jayamanne 509cc674f2 Skip failing nb test untill resolved (#248472) 2025-05-09 15:15:05 +10:00
Aaron Munger e65a9a3d46 check one more async op (#248225) 2025-05-06 17:46:21 +02:00
Aaron Munger d6fb62df0d diagnostic message (#248151) 2025-05-05 20:22:41 +02:00
Aaron Munger e5ac650981 bump default nb format version (#242741)
* bump default nb format version

* update tests

---------

Co-authored-by: amunger <>
2025-03-07 20:58:55 +01:00
Don Jayamanne 8cc255e03a Ensure execution_count is cleared when clearing outputs (#237301) 2025-01-05 19:58:34 -08:00
Don Jayamanne 27d99fbee7 Set execution_count to null when clearning notebook outputs (#231806)
* Set execution_count to null when clearning notebook outputs

* Fix tests
2024-10-21 06:56:16 +02:00
Don Jayamanne 9b2e9634aa Remove code used to store metadata in custom property for notebooks (#227418)
* Remove code used to store metadata in custom property for notebooks

* oops
2024-09-03 09:24:35 +02:00
Don Jayamanne e3cf2530e6 Include execution count in jupyter notebook diff (#208292)
* Include execution count in notebook diff

* Fix tests

* Misc changes

* Fix tests

* Fix more tests
2024-03-21 14:14:33 +01:00
Don Jayamanne 55d6f3050d Drop custom metadata property from notebooks behind setting (#208065)
* Drop custom metadata property behind setting

* Do not update existing object
2024-03-19 19:37:59 +11:00
Don Jayamanne 1e95cb902e Keep notebook model in sync with the ipynb json (#208052) 2024-03-18 20:17:46 -07:00
Matt Bierner 57dd298b47 Add typings for test runner scripts (#169196) 2022-12-15 02:19:24 +01:00
Peng Lyu 6e8bc02be4 Cell attachment cleanup tool improvement in diff editor (#161132)
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Matt Bierner 68912bd844 Use 'import type' for '@jupyterlab/nbformat' (#157153)
This is a type only dev dep so we should prevent referencing it as a value
2022-08-04 23:46:53 +02:00
Johannes 0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
rebornix 998ee04a72 update nbformat typings 2022-03-01 12:59:58 -08:00
Johannes Rieken 7ccb868835 make sure to use .eslintignore when running yarn eslint, this will ensure that cli failure and editor squiggles are always equal 2022-02-02 12:37:29 +01:00
Don Jayamanne 7bbd66c2d2 Fixes with tests 2021-08-24 17:17:48 -07:00
Don Jayamanne 31abc3784e Revert "Merge pull request #131592 from DonJayamanne/revertPerfFixes2"
This reverts commit 52baabff07, reversing
changes made to 6e930fb6d4.
2021-08-24 17:16:44 -07:00
Don Jayamanne c397afa3bd Revert "Merge pull request #131035 from DonJayamanne/issue129370"
This reverts commit b23486ef7a, reversing
changes made to 9e0732389b.
2021-08-24 16:27:10 -07:00
Don Jayamanne 9347bc5c24 More perf fixes after review 2021-08-19 12:20:39 -07:00
Don Jayamanne 09f68d545d Optimize indentation detection 2021-08-17 14:51:53 -07:00
Don Jayamanne 0882f1e571 Perf improvements to the ipynb serializer 2021-08-17 12:52:59 -07:00
Rob Lourens 190a89dd1b Port unit tests from vscode-jupyter to ipynb extension
#129446
2021-08-03 11:19:22 -07:00