Commit Graph

16 Commits

Author SHA1 Message Date
Matt Bierner
e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Benjamin Pasero
7031abadea debt - less explicit any 2021-03-29 10:30:03 +02:00
Matt Bierner
98354ad7cc Add comment about localization string
Fixes #115781
2021-02-11 15:50:28 -08:00
Matt Bierner
bcf14260d2 Make sure contibuted openers are cleaned up if they are renamed for an extension that is not uninstalled 2021-02-02 18:19:30 -08:00
Matt Bierner
d9ff550d02 Add intellisense for onOpenExternalUri activation and rename event
Fixes #115131

Also renames the activation event to `onOpenExternalUri`
2021-02-01 19:57:54 -08:00
Matt Bierner
0ede524326 Reword multiple external opener error
Fixes #115163
2021-01-26 16:13:14 -08:00
Matt Bierner
500d514ecf Add fall back to default option for when external uri opener fails 2021-01-25 16:21:44 -08:00
Matt Bierner
cc5e8b22fa Continue work on url opener api
For #109277

- Add `option` opener priority. This means the oper will only be shown if requested but will not replace the default opener
- Persist registered openers for IntelliSense suggestions
2021-01-14 17:06:14 -08:00
Matt Bierner
5d6cba5cbc Reworking external opener implementation to allow configured openers to be called directly without a canOpen check
If the user has configured a specific external uri opener, we should always try to use that without first calling `canOpen` to filter down the list of openers.

This change also adds `ExternalUriOpenerEnablement` which allows an opener to mark itself as the preferred opener for a given uri. If only a single preferred opener is returned, it will be used automatically for that uri (although user configuration can override this)
2021-01-14 10:37:00 -08:00
Matt Bierner
47aa3ad09a Continue work on opener service
- Add error notification if opener throws an exception
- Add public facing id to openers. This is used in settings
- Add intellisense for the opener id setting
2021-01-13 12:53:18 -08:00
Matt Bierner
47a135e715 Rework opener api proposal
For #109277

- Add more explicit two phase structure to api
- Make opener pass along label when registered
2021-01-12 16:14:42 -08:00
Matt Bierner
0227681492 Add new external uri opener service
This workbench service handles opening external uris. Unlike the core OpenerService, it also has logic for configuring a default opener and prompting if multiple openers are availble for a given uri
2021-01-12 12:41:15 -08:00
Matt Bierner
acda4aed82 Make the external opener a two phase process
This changes makes a few changes to the openers:

- Move the opener prompting from the extension host into the main thread
- Make the external opener process two phases: get openers and then open. This would let us skip the trusted domain validation for extension handled links if we want to in the future
- Add lifecycle to commands used by the uri opener

For #109277
2021-01-07 17:42:12 -08:00
Matt Bierner
e2c305f3a3 Allow registering additional external uri openers
This change moves the extension uri opener contribution point to instead use the internal `IExternalOpener` api instead of the more generic `IOpener` api. This is required since external uri openers should see the resolved uri that has gone through port forwarding, not the raw uri that the user clicked on
2021-01-07 11:41:07 -08:00
Matt Bierner
423076ab49 Pass schemes to main thread 2020-12-16 15:32:08 -08:00
Matt Bierner
6d3c2e6835 Adding proposed external uri opener API
For #109277
2020-12-15 16:26:47 -08:00