Matt Bierner
c109d319fe
Second pass converting for index based looping to for-of loops
...
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Matt Bierner
cd88417f49
Enabling a few more tslint rules in the codebase
2019-01-03 17:39:12 -08:00
Matt Bierner
9e4daf6069
Prefer using explicit function types instead of Function
2019-01-03 17:39:12 -08:00
Rob Lourens
ef2547d547
replace void 0 with undefined
2019-01-03 11:20:19 -08:00
Rob Lourens
7805023eaa
Fix #65933
2019-01-02 21:20:14 -08:00
bissonex
36ac195d16
fix typo ( #65740 )
...
fix typo for Editor Find, terminalSupport.ts, terminals.ts, extHostDebugService.ts
2018-12-28 12:13:31 -08:00
Johannes Rieken
195fd560a5
undo unneeded change
2018-12-27 11:57:16 +01:00
Johannes Rieken
96d2413a4e
Tweak ctor of SelectionRange, https://github.com/Microsoft/language-server-protocol/issues/613
2018-12-27 10:07:23 +01:00
Josh Goldberg
d659000852
Converted about 25 *.test.ts files to --strictNullChecks (mostly automatically) ( #65581 )
...
* Manually added strict null checks in around 70 files
* Fixed tsconfig.strictNullChecks.json merge fail
* Touched up a few unnecessary type changes
* Removed files already in other PRs
2018-12-23 20:28:51 -08:00
Daniel Imms
fedf2f8771
Rename experimentalUseConpty to windowsEnableConpty
2018-12-21 12:00:35 -08:00
Daniel Imms
dceb815558
Merge remote-tracking branch 'origin/master' into tyriar/conpty
2018-12-21 10:49:44 -08:00
Alex Dima
25417553be
Adopt case insensitive extension identifiers
2018-12-21 12:41:41 +01:00
Matt Bierner
6422adaffe
Remove redundant type annotations for generic emitter properties
...
Code like:
```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```
Does not need to repeat the `Emitter<LanguageId>` type annotation
2018-12-19 17:10:39 -08:00
Andre Weinand
5fece3f30e
do not ignore debggers that lack a label; fixes #61649
2018-12-19 16:03:17 +01:00
Daniel Imms
58f6dc5185
Merge remote-tracking branch 'origin/master' into tyriar/conpty
2018-12-18 17:13:35 -08:00
Rachel Macfarlane
c5c15eb75f
Add document parameter to draft methods on comments provider
2018-12-18 14:57:50 -08:00
Johannes Rieken
27fd58c206
refine SelectionRangeKind #63935
2018-12-18 10:57:56 +01:00
Daniel Imms
e110245f13
Merge branch 'master' into kieferrm/terminal-cwd
2018-12-17 11:21:20 -08:00
Johannes Rieken
514ec620de
add SelectionRange and SelectionRangeKind, #63935
2018-12-17 15:10:18 +01:00
Daniel Imms
ece3a90fb5
Tweak setLocaleVariables setting
...
- False now really means false
- The default is true for all platforms
Fixes #65037
2018-12-13 18:07:20 -08:00
Matt Bierner
986f924ad5
Prefer using Array<T> for complex array types
...
Use `Array<T | U>` when dealing with union types instead of `(T | U)[]`
2018-12-13 16:40:44 -08:00
Matt Bierner
d40fa4a27e
Review uses of Promise.resolve(null)
...
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
2018-12-13 15:41:13 -08:00
Matt Bierner
68a4e01246
Use resolve(void 0) instead of resolve(null) for void promises
...
Fixes a common type error
2018-12-13 15:20:46 -08:00
Daniel Imms
e6254db320
Recreate pid promise when reusing terminals
2018-12-13 10:02:17 -08:00
Daniel Imms
461bf7207b
Merge remote-tracking branch 'origin/master' into pr/g-arjones/60111
2018-12-13 09:33:42 -08:00
Daniel Imms
e7102b1824
Send terminal name with id when it's ready
...
Fixes #64390
2018-12-13 08:07:55 -08:00
Dirk Baeumer
51f7beb40c
Fixes #64918 : Remove old task conversion code
2018-12-13 14:45:51 +01:00
Johannes Rieken
c6c7edaa9f
debt - asThenable -> asPromise because it returns a promise
2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133
debt - Thenable -> Promise
2018-12-13 11:31:54 +01:00
Alex Dima
29dd4e77de
Keep track of activating extensions
2018-12-13 11:22:26 +01:00
Matt Bierner
0b1d0da7af
Prefer to use .then(void 0, ..) over .then(null, ..)
...
ES6 promises like using undefined as their first argument instead of null. Both should behave the same behavior
2018-12-11 21:59:32 -08:00
Daniel Imms
e417e07b4b
Add use conpty setting
2018-12-11 11:46:39 -08:00
Johannes Rieken
48a452dcee
towards strict null and completion model, #63454
2018-12-11 17:00:19 +01:00
Joao Moreno
408e03220c
event namespace consolidation & docs
2018-12-11 10:14:38 +01:00
Matt Bierner
100adeb3e9
Use more generic word pattern for markdown
...
Try to better support handle of unicode in markdown by using a word definition that use unicode character class
Fixes #15177
2018-12-10 18:24:10 -08:00
Matt Bierner
0928a6d348
Prefer coalesce over filter
...
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Matt Bierner
e2cf8ebc5d
Enable strictBindCallApply for VS Code
...
Fixes #64633
2018-12-07 14:25:14 -08:00
Rob Lourens
9be224980c
Make LogLevel converters safer and consistent with other converters, from @jrieken feedback
2018-12-06 11:02:09 -08:00
kieferrm
f8d555167e
allow terminal.cwd to be a URI
2018-12-05 14:48:18 -08:00
Rob Lourens
514217add5
Fix #64273 - EH log levels start at 1
2018-12-05 13:29:38 -08:00
Rob Lourens
6f9b2d7593
Fix #59922 - changes needed to support a cache in a FileSearchProvider
2018-12-03 16:19:37 -08:00
Matt Bierner
64117e8fb5
Rename TriggerReason -> TriggerKind
...
Fixes #64216
2018-12-03 13:53:53 -08:00
Johannes Rieken
3bb5ce5d52
remove sample function proposed api
2018-12-03 18:14:43 +01:00
Johannes Rieken
daae50ab21
ensure a range contains its previous range, #63935
2018-12-03 12:05:50 +01:00
Johannes Rieken
2baa14fcf2
tests and api command for smart select api, #63935
2018-12-03 11:51:53 +01:00
Johannes Rieken
07be58bbad
add proposed api for smart select, #63935
2018-12-03 11:29:12 +01:00
Johannes Rieken
253a4f6d17
log provider failure as errors, #63831
2018-12-03 08:47:39 +01:00
Alex Dima
aa3ea85b0a
Explorations
2018-11-30 15:54:40 +01:00
Alex Ross
e16c62b315
Move rerun behavior api out of proposed ( #63511 )
...
Fixes #62789
2018-11-30 15:31:13 +01:00
Andre Weinand
f168d88224
final tracker API; for #62843
2018-11-30 15:17:40 +01:00
