Commit Graph
1405 Commits
Author SHA1 Message Date
Benjamin Pasero f729419f57 add _workbench.enterWorkspace (#54129) 2018-07-13 11:31:19 +02:00
Johannes Rieken 19f25e4801 add telemetry appender that writes to log (#53603)
* add log-telemetry-appender and wire it up in the shell

* enable log-only-telemetry in scripts/code.[sh|bat]

* Reduce noise, separate log file for telemetry

* Print telemetry events from shared process to corresponding log channel

* Telemetry events for cli go to the log file for cli

* Merge cli telemetry with all data with cli log

* Use LogAppender when running from source

* Skip check on isBuilt as the same is done in the shared process

* Telemetry events from main process go to corresponding log file

* Telemetry events from issue reporter go to corresponding log file

* Cleanup to reduce diff amount as I have OCD

* More cleanup

* Open telemetry log file via the Open Log File command

* Use regex to strip out common data

* Tests
2018-07-11 12:21:40 -07:00
Benjamin Pasero e90cc0bd33 Regroup view menu (#54077)
* introduce a submenu "Appearance"

* appearance menu for custom menus

* menu variant @kai

* mockup: new tools menu

* Revert "mockup: new tools menu"

This reverts commit be74df80fe.

* move appearance up
2018-07-11 18:16:36 +02:00
Joao Moreno d4b310ea01 fix UI calls from shared process
fix #54070
2018-07-11 17:24:15 +02:00
Rob Lourens 8e4b4b8f3d Settings editor - change keybinding and actions to open new editor by default (for insiders) 2018-07-09 10:53:41 -07:00
Sandeep Somavarapu e89b02b448 Fix #53872 2018-07-09 15:12:20 +02:00
Daniel Imms 9b876381cb Use m for Terminal menu mnemonic
Fixes #53828
2018-07-09 06:10:57 -07:00
Benjamin Pasero 10e683de01 fix #53713 2018-07-06 16:36:38 +02:00
Alex Dima 027d346483 Go through error handling for unhandled rejection errors 2018-07-04 11:10:59 +02:00
Joao Moreno 0f851d0fd5 ipc events should not use TPromise 2018-07-04 08:49:10 +02:00
Daniel Imms ebe5f2630f Merge pull request #53238 from Microsoft/tyriar/enable_terminal_menu
Re-enable terminal menu
2018-07-03 11:42:07 -07:00
Dirk Baeumer 3c0abb8d8a Add support to regenerate nsl cache if corrupted. 2018-07-03 12:13:30 +02:00
Johannes Rieken 35f7a7b817 avoid async and winjs.promise, #53442 2018-07-03 09:22:10 +02:00
SteVen Batten 7f02ffaab3 remove auto save ipc 2018-07-02 12:55:29 -07:00
Joao Moreno dd6dc96d20 clean more async
related to #53442
2018-07-02 18:26:42 +02:00
Joao Moreno ba7b1cb0d5 cleanup more promises
related to #53442
2018-07-02 16:49:11 +02:00
Sandeep Somavarapu 1624b81855 #45072 Add a prompt to update the extension 2018-07-02 15:52:51 +02:00
Sandeep Somavarapu 6bf20cc217 Merge pull request #45533 from oriash93/oriash93/45072
Support for updating extensions from CLI
2018-07-02 15:06:07 +02:00
Benjamin Pasero 4d0b3d025e debt week code cleanup
- avoid public modifier
- use Disposable where applicable
- fix some event handler leaks
- clean up some TODO@ben
2018-07-02 10:55:26 +02:00
SteVen Batten db2f851c8c fixes #53254 2018-06-29 17:39:08 -07:00
Daniel Imms a4e6bdc6fd Rename integrated terminal to terminal in view menu
Fixes #53158
2018-06-28 06:37:40 -07:00
Daniel Imms 262787a4f2 Re-enable terminal menu
Part of #53158
2018-06-28 06:36:02 -07:00
Daniel Imms 013a59dd32 Disable terminal menu
Part of #53158
2018-06-28 06:34:20 -07:00
Benjamin Pasero 368ab9c31b use systemPreferences.setUserDefault() to workaround #35361 2018-06-26 06:56:23 +02:00
Benjamin Pasero 9719d316ca Revert "Fix #35361: fix native tabs on macOS 10.13 (#52775)"
This reverts commit 8e03e03131.
2018-06-25 19:03:21 +02:00
zhuowei 8e03e03131 Fix #35361: fix native tabs on macOS 10.13 (#52775)
* Fix #35361: fix native tabs on macOS 10.13

macOS 10.13 mistakenly enables a compatibility option on VS Code
and VS Code Insiders because their bundle IDs begin with
"com.microsoft.". This breaks native tabs.

Explicitly disable the compatibility patch using NSUserDefaults.

Note that Code-OSS is not affected by the bug, since its bundle ID
is "com.visualstudio.code.oss". To test this behaviour, change
darwinBundleIdentifier in product.json.

* set NSUseImprovedLayoutPass only when window.nativeTabs: true
2018-06-25 18:30:59 +02:00
Sandeep Somavarapu 3669afe7e9 Fix #48656 2018-06-25 18:20:20 +02:00
Sandeep Somavarapu 4d93f9cc37 Fix #51145 2018-06-25 16:38:21 +02:00
Benjamin Pasero e47a9c9eef revert electron 2.0.x update 2018-06-25 09:28:34 +02:00
isidor 67e1e11845 remove centered editor layout from layout menu 2018-06-20 09:31:19 +02:00
Alex Dima 6e088a7162 Minor edits 2018-06-19 17:45:25 +02:00
Joao Moreno e43ab4e4c4 portable mode 2018-06-18 20:04:03 +02:00
Joao Moreno 19753e49e5 fix portable in linux 2018-06-18 17:03:48 +02:00
Benjamin Pasero cf88c4f0ae 💄 2018-06-18 16:53:25 +02:00
Joao Moreno 2e332cc894 fix portable env state propagation in linux 2018-06-18 16:07:10 +02:00
Benjamin Pasero b5ac96b5a9 Merge pull request #51422 from sbatten/titlebarplus
Custom Menubar Implementation
2018-06-18 11:01:10 +02:00
Benjamin Pasero aaff78b996 fix #52045 (#52160) 2018-06-18 09:59:51 +02:00
Benjamin Pasero 11c186f184 some cleanup and 💄 2018-06-17 12:14:35 +02:00
SteVen Batten 329d38e658 fallback to old menubar when using macOS or native title 2018-06-15 13:32:11 -07:00
SteVen Batten f4e55b76d3 move maximized into getUrl 2018-06-14 20:22:54 -07:00
Peng Lyu d94ae55ab6 replace experimental resizeobserver with mutation observer 2018-06-14 11:50:57 -07:00
rebornix f83a748a8e show comments in diff view sidebyside. 2018-06-13 15:48:25 -07:00
SteVen Batten 179eae8352 fix from merge and make titlebar position more reliable 2018-06-13 11:44:59 -07:00
SteVen Batten a83a51484c merge master 2018-06-13 11:25:46 -07:00
isidor edc16f0dc9 fix build 2018-06-13 12:30:41 +02:00
isidor 6683ba1574 getPathLabel clients pass contextService when possible unles you explicitly want an absolute path 2018-06-13 12:01:07 +02:00
Alex Dima 8810c8e74a Have ICommandAction use URIs for the icon location 2018-06-13 10:45:56 +02:00
SteVen Batten f08cdae1e4 maximize window in window configuration 2018-06-12 12:06:04 -07:00
SteVen Batten a68a9750fd add editor layout menu, localize top levels 2018-06-12 10:00:47 -07:00
isidor 9a7535c820 getPathLabel: make only rootProvider optional 2018-06-12 18:22:08 +02:00