Johannes Rieken
aa36c6211b
move duplicated code into central place
2020-11-30 14:51:54 +01:00
Benjamin Pasero
630e706ad2
Add open context to certain commands ( #110475 )
...
* editor commands - move API commands to workbench core
* rename EditorViewColumn => EditorGroupColumn
* mixin context to open commands
* address some feedback
* add comment
2020-11-12 17:01:13 +01:00
Benjamin Pasero
6e022766d1
debt - adopt defaultUriScheme over hardcoded vscode-remote in toLocalResource
2020-09-10 18:03:51 +02:00
Alex Dima
802572340b
Fixes #101956
2020-07-09 12:35:58 +02:00
Johannes Rieken
28cb90be8c
chore - ES6, use for-of instead of forEach
2020-06-12 16:20:23 +02:00
Johannes Rieken
b662583062
chore - more ES6 iteration
2020-06-12 13:55:31 +02:00
Johannes Rieken
48a2d3e863
if needed , read clipboard inside MainThreadEditors#insertText, https://github.com/microsoft/vscode/issues/98497
2020-06-08 12:03:01 +02:00
Johannes Rieken
b0d056202b
Use canonical uri for openTextDocument api, #93368
2020-05-29 18:16:31 +02:00
Benjamin Pasero
a23d4daefa
Dangling text file models of deleted files hanging around in memory ( #98154 )
...
* Dangling text file models of deleted files hanging around in memory (fix #98057 )
* address feedback
2020-05-26 16:29:12 +02:00
Benjamin Pasero
418d1974ca
Workbench editor renames ( #91943 )
...
* IEditor => IEditorPane
* More panes:
* IVisibleEditor => IVisibleEditorPane
* ITextEditor => ITextEditorPane
* ITextDiffEditor => ITextDiffEditorPane
* imports - remove type alias
* More pane renames
* IEditorService#activeControl => activeEditorPane
* IEditorService#visibleControls => visibleEditorPanes
* More editor renames
* activeTextEditorWidget => activeTextEditorControl
* visibleTextEditorWidgets => visibleTextEditorControls
2020-03-03 10:47:50 +01:00
Johannes Rieken
6829e20b19
es6 - replace some usages of values/keys utils with destructuring
2020-03-03 10:35:19 +01:00
Benjamin Pasero
3d9d1f9f2a
text files - allow to work with untitled from text file service directly
2020-01-16 12:45:13 +01:00
Benjamin Pasero
87064db103
debt - untitled editor => untitled text editor
2019-11-06 12:44:59 +01:00
Matt Bierner
029009eafd
Marking most private emitters as readonly
...
Emitters should generally not be reassigned as their corresponding event would also be lost. Marking these as readonly just to enforce this
2019-09-23 17:31:18 -07:00
Johannes Rieken
06701f533d
add a bunch of strict field initializations
2019-07-31 12:30:30 +02:00
Matt Bierner
afe2da7ed6
Use a map instead of a object to store editors
2019-07-15 11:47:29 -07:00
Matt Bierner
ae2cc878f8
Using DisposableStore in mainThread class
...
#74250
2019-07-02 16:37:35 -07:00
Johannes Rieken
2cd36100c4
Revert "Update more places where we are using an IDispoable[]"
...
This reverts commit 869e5921d8
2019-06-06 15:31:23 +02:00
Matt Bierner
869e5921d8
Update more places where we are using an IDispoable[]
...
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Matt Bierner
0f32f0ef5f
Clean up some usages of IDisposable[]
...
Part of #74250
- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Benjamin Pasero
7211226222
fix compile errors
2019-04-09 11:37:29 +02:00
Johannes Rieken
1d3215d100
move mainThread[D,E], #70319
2019-03-20 11:29:03 +01:00
