Commit Graph

64 Commits

Author SHA1 Message Date
Rob Lourens
c26d6e6c93 Refactor text seach
To allow better code sharing between EH and search proc
2018-10-15 16:28:31 -07:00
Rob Lourens
ee40fa3e0d Text search in EH 2018-10-15 16:28:31 -07:00
Rob Lourens
3d3df21a92 Fix #50676 - unreponsive window for some searches in EH 2018-10-12 16:48:35 -07:00
Rob Lourens
38a2c24ca2 Merge pull request #59717 from skprabhanjan/fix-59364
Fix #59364 : Respect global .gitignore when searching
2018-10-04 11:40:23 -07:00
Matt Bierner
f7456ebf90 Switch to use standard @types/node types instead of our customized version
Using a custom version of the node typings is causing a lot of pain while trying to upgrade our build to use `@types` instead of the `d.ts` files we have to maintain. I believe we primarily maintain our own version for two reason:

- Custom require function
- setTimeout and other timer functions return NodeJs.timer instead of a number

These can both be delt with, the first by using interface augmentation and the second by switching to use any types for timer. I believe that the pain of maintaining our own node `d.ts` outweighs the benefits here

This change switches us to use the standard @types/node package for our node typings
2018-10-03 14:18:36 -07:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
pkoushik
c4928076b7 fix #59364 - Review #2 2018-10-02 19:35:18 +05:30
Rob Lourens
f3654c59e0 Fix #55790 - allow extensions to return a hitLimit flag 2018-09-17 22:48:12 -07:00
Rob Lourens
b7e684c508 Fix TPromise#cancel in FileIndexProvider #56137 2018-09-10 11:21:47 -07:00
Rob Lourens
44dc55b9fc Fix #57951 - remove $cancelSearch 2018-09-05 16:51:16 -07:00
Johannes Rieken
670719d22a use CancellationToken over cancel-callback and cancel-calls 2018-09-05 15:02:15 +02:00
Rob Lourens
497ea886b7 #56137 - remove more TPromise#cancel from search 2018-09-03 17:06:46 -07:00
Johannes Rieken
3c727a6d01 uri - replace usages of default export with named export (part 2) 2018-09-03 11:04:26 +02:00
Rob Lourens
de70176d06 Fix #57186, Fix #31551 - implement previewOptions for text search API 2018-08-24 20:37:08 -07:00
Rob Lourens
34b3302bb4 #56950 - add details to text search telemetry 2018-08-22 18:45:43 -07:00
Rob Lourens
dd13d47e02 #56950 - add search telemetry for EH-based search 2018-08-21 19:58:55 -07:00
Rob Lourens
00649474f2 #55883 - remove some TPromise#cancel from extHostSearch 2018-08-19 21:22:31 -07:00
Rob Lourens
c86cab2211 SearchProvider - fix NPE when searching extraFileResources 2018-08-01 21:27:18 -07:00
Rob Lourens
49bbb88160 Fix FileSearchProvider unit tests for progress change 2018-08-01 13:39:21 -07:00
Rob Lourens
e69e4d3a47 Search provider - Fix FileSearchProvider to return array, not progress 2018-08-01 11:44:51 -07:00
Rob Lourens
866bc0aa4c Fix #55224 - use different cacheKeys per folder in FileIndexProvider 2018-07-27 11:26:04 -07:00
Rob Lourens
aff77d278b SearchProvider - clean up FileSearchProvider, remove cacheKey 2018-07-26 12:28:15 -07:00
Rob Lourens
28fd1cc007 Search provider - clean up file index search, remove PPromise 2018-07-26 12:28:15 -07:00
Rob Lourens
d36a3d2395 Search provider - implement FileIndexProvider 2018-07-26 12:28:15 -07:00
Rob Lourens
9999dac541 SearchProvider - split out separate TextSearchProvider #47058 2018-07-26 12:28:15 -07:00
Rob Lourens
c4f336d1d6 Fix #53887 - remove remaining PPromise usage in search 2018-07-23 14:07:50 -07:00
Matt Bierner
a6885b48cd Use toDisposable in more places in workbench and platform 2018-07-20 14:16:28 -07:00
Christof Marti
0fc6b638e1 Avoid repeated scanning of siblings array (#47187) 2018-07-12 09:26:40 +02:00
Rob Lourens
e60cf6b0ee Search provider - remove file pattern checking code from extHostSearch 2018-07-11 15:02:48 -07:00
Rob Lourens
d30631dea8 Fix #53510 - remove relative pattern matching from file search 2018-07-10 17:02:33 -07:00
Rob Lourens
0215f30d9b Search Provider - implement clearCache 2018-07-03 20:08:53 -07:00
Rob Lourens
824a3e9298 Search provider - remove absolute path checks from extHostSearch to match fileSearch.ts 2018-07-03 16:03:43 -07:00
Rob Lourens
21082bf9ef Search provider - give different cacheKeys for different folders 2018-07-03 14:46:41 -07:00
Rob Lourens
0ef1c31b06 Change SearchProvider to be URI-based, not string-based. #50788 2018-07-02 19:24:14 -07:00
Rob Lourens
e0e9c3d455 Search provider - some clean up 2018-07-02 19:24:14 -07:00
Rob Lourens
ea5620dd8d SearchProvider invoked on every keypress 2018-07-02 19:24:13 -07:00
Rob Lourens
8f8ed32e73 Search provider pattern switches should not be optional - #45000 2018-06-07 21:38:21 -07:00
Rob Lourens
4eaf58348b Fixes and 💄 around maxResults for search providers 2018-05-26 12:19:40 -07:00
Rob Lourens
a015dc90f9 EH search - fix search providers using non-file schemes 2018-05-25 20:06:58 -07:00
Rob Lourens
3038f429da Fix #50175 2018-05-21 10:28:42 -07:00
Rob Lourens
d0b06a638a Change EH search back to use URIs between EH and renderer process 2018-05-20 22:42:26 -07:00
Rob Lourens
912fff91ac Change File search result API to only return a string relative path to the search folder 2018-05-17 21:51:10 -07:00
Rob Lourens
707a20f4af Change TextSearchResult API to only return a string relative path to the search folder 2018-05-17 21:25:47 -07:00
Rob Lourens
a9d3a477dd EH search - remove slow ES5 async/await from inner loop 2018-05-17 11:56:05 -07:00
Rob Lourens
9b4656e6bc EH search - send limitHit result back to frontend 2018-05-17 11:56:05 -07:00
Rob Lourens
cf06508603 EH search - implement max results for text search on the ExtHostSearch side 2018-05-17 11:56:05 -07:00
Rob Lourens
0fb960478e EH search - add fileSearch telemetry 2018-05-16 21:59:42 -07:00
Rob Lourens
3de1e91694 EH search - respect sibling clauses in text search 2018-05-16 17:07:13 -07:00
Rob Lourens
e3d54a7101 EH search - simplify code that handles excludes across multiple folders in a workspace 2018-05-16 11:10:35 -07:00
Rob Lourens
9be64e3602 EH search - fix max results in file search, add tests 2018-05-16 11:10:35 -07:00