Commit Graph
1223 Commits
Author SHA1 Message Date
Benjamin Pasero 3fb8967173 fix some TS 4.1 errors (#106358) 2020-09-10 08:49:08 +02:00
Matt Bierner ec8016f7d1 Cache webview view title across reloads
Fixes #105867
2020-09-09 21:51:22 -07:00
rebornix 03960a5aa1 re #105735. no more udpateMetadata api. 2020-09-09 16:45:00 -07:00
rebornix 73a3c9ded3 re #105735. 2020-09-09 16:45:00 -07:00
Matt Bierner 80b1a775d6 Enable webview commands for webview views
Fixes #105670

Previously our webview commands assumed that webviews were always going to be in an editor. This is no longer true with webview views.

To fix this, I've added an `activeWebview` to the `IWebviewService`. This  tracks the currently focused webview.
2020-09-09 14:44:46 -07:00
rebornix 889fe1787b 💄 2020-09-09 14:40:44 -07:00
rebornix 69f26324d4 initialize notebook text model data only through ctor. 2020-09-09 14:40:44 -07:00
rebornix 8bc3145bc5 move dirty state to NotebookEditorModel. 2020-09-09 12:04:21 -07:00
rebornix eb05b79e9b do not need isUntitled. 2020-09-09 12:04:20 -07:00
Johannes Rieken e40d854df6 debt - IMainNotebookController#removeNotebookDocument 2020-09-09 20:01:35 +02:00
Matt Bierner c348165cc0 Adding more explicit typings for promises
This gets us ready for TS 4.1
2020-09-09 09:21:56 -07:00
Johannes Rieken dcef262f4e chore - move appyWorkspaceEdit from extHostTextEditors to (new) extHostBulkEdits and mainThreadBulkEdits 2020-09-09 11:18:14 +02:00
Johannes Rieken 420aa32929 add replaceNotebookMetadata, https://github.com/microsoft/vscode/issues/105283 2020-09-09 10:44:45 +02:00
Johannes Rieken 951dd140b8 add replaceNotebookMetadata (should become replaceMetadata) to NotebookEditorEdit, https://github.com/microsoft/vscode/issues/105283 2020-09-09 10:44:45 +02:00
Matt Bierner f79540dc65 Add show method to webview view
Fixes #106085
2020-09-08 17:19:11 -07:00
Peng Lyu 93a0c99f18 Merge pull request #106313 from microsoft/rebornix/nbdebt
notebook text model debt
2020-09-08 15:41:38 -07:00
Matt Bierner 4c7071e9ab Add WebviewView.description
Allow configuring the description for webview views.

This is rendered next to the title in a less prominently in the title
2020-09-08 15:23:43 -07:00
rebornix 1870a1c47e Merge remote-tracking branch 'origin/master' into rebornix/nbdebt 2020-09-08 14:10:32 -07:00
Johannes Rieken 8b0a7c9582 debt - remove _unInitializedDocuments 2020-09-08 19:56:24 +02:00
rebornix 17d779cfd2 unified onDidChangeContent 2020-09-08 08:57:16 -07:00
rebornix 8ebad589d5 deprecate onDidChangeCells 2020-09-08 08:36:06 -07:00
Johannes Rieken 44b1737a9c chore - when target might be undefined use target?.dispose() over dispose(target) 2020-09-08 17:34:53 +02:00
Johannes Rieken ce19502cdd chore - tweak onDidAddNotebookDocument, onDidRemoveNotebookDocument event, use ResourceMap and fix confusion between models and editors 2020-09-08 16:33:48 +02:00
Johannes Rieken 1c3d3ae3ac notebooks - don't allow anyone to call unregisterNotebookProvider, add names to TODO-tags 2020-09-08 15:44:29 +02:00
Johannes Rieken 53ffabab80 debt - remove unused INotebookModelAddedData#handle 2020-09-07 11:52:50 +02:00
rebornix 313fb760fe make changeMetadata private 2020-09-04 10:02:30 -07:00
rebornix 8503905a7c remove clear outputs api. 2020-09-04 09:21:45 -07:00
rebornix 11158cc1d1 re #105735. selections as NotebookEditor properties. 2020-09-03 20:28:28 -07:00
Rachel Macfarlane 74c0ce02ce Add new github browser extension id to allow list 2020-09-03 09:59:43 -07:00
rebornix f6831c1b81 * cell languages. 2020-09-01 18:00:44 -07:00
Rachel Macfarlane c7c6c5cde1 Fix #105503 2020-09-01 17:31:05 -07:00
Matt Bierner 1dd6b285f9 Restrict webview views to make sure proposed api is enabled
Fixes #105824
2020-09-01 13:16:49 -07:00
rebornix c887ae1b6d remove legacy registerKernel 2020-08-31 12:00:21 -07:00
rebornix 2518d2c44d update kernel per document. 2020-08-31 11:49:19 -07:00
rebornix d3a5dd9d4b re #102503. reveal range 2020-08-28 13:23:28 -07:00
rebornix 637d782c7b re #102503. visible range change events. 2020-08-28 12:06:21 -07:00
Johannes Rieken a3f414cf5a add some integration tests for notebook editing, https://github.com/microsoft/vscode/issues/105283 2020-08-28 17:59:10 +02:00
Matt Bierner f542ed32c1 Rename 2020-08-27 13:51:11 -07:00
Matt Bierner 08be66406f Make context the first arugment to constructors 2020-08-27 13:51:11 -07:00
Matt Bierner 9b117bbb1d Move custom editor activation into mainThreadCustomEditors 2020-08-27 13:51:11 -07:00
Daniel Imms 47ecd45eaa Merge branch 'master' into tyriar/welcome 2020-08-27 12:47:59 -07:00
Daniel Imms aa6b2f163d Initial terminal welcome support 2020-08-27 12:38:33 -07:00
rebornix b2693bb7ed remove legacy kernel on content provider 2020-08-27 12:01:25 -07:00
Rachel Macfarlane 650197b991 Add authentication contribution point, #103507 2020-08-27 11:51:18 -07:00
Johannes Rieken fdf5b95a51 replace ICellInsertEdit, ICellDeleteEdit with ICellReplaceEdit, https://github.com/microsoft/vscode/issues/105283 2020-08-27 11:25:41 +02:00
Johannes Rieken 860a68747f WorkspaceEdit#replaceCells|CellOutput|CellMetadata, https://github.com/microsoft/vscode/issues/105283 2020-08-27 10:25:17 +02:00
Rob Lourens b58f4549b2 Implement notebook cell status bar item contributions
Fix #104958
2020-08-26 17:07:10 -07:00
Matt Bierner 72cbf699d8 Split out main thread webview panels into own class/file 2020-08-26 16:46:26 -07:00
Matt Bierner 7e4ccf1676 Rename WebviewPanelHandle -> WebviewHandle 2020-08-26 16:46:25 -07:00
Matt Bierner 79d7a9569d Undoing exthost side of the webview serializer split 2020-08-26 16:46:25 -07:00