Commit Graph
47 Commits
Author SHA1 Message Date
SteVen Batten c58e437830 remove unnecessary listeners for built-in views 2020-02-13 08:15:49 -08:00
SteVen Batten 47813a3e40 run and debug views can move
refs #90468
2020-02-11 09:15:36 -08:00
Joao Moreno 9aa9ea752b Merge branch 'master' into joao/empty-views 2020-02-11 12:49:45 +01:00
Matt Bierner ee430f9d2a Adding casts for creation of generic workbench trees with strict function types
For #81574

Based on https://stackoverflow.com/questions/59384319/typescript-get-typeof-generic-constructor
2020-02-10 15:28:12 -08:00
Joao Moreno d4c1acf6cc add opener and theme services to ViewPane 2020-02-10 16:06:59 +01:00
Joao Moreno dc464e62bf Merge branch 'master' into joao/empty-views 2020-02-10 11:34:32 +01:00
Benjamin Pasero c6750ffa87 debt - careful with dispose() and assignments 2020-02-04 08:53:23 +01:00
SteVen Batten 481923c44e migrate search to use new setting (#89190)
* migrate search to use new setting

* rename

* add getViewLocation api to vds for search

* remove unreferenced location option
2020-01-24 08:23:34 -08:00
Joao Moreno 7c30a1b05e wip: empty view content 2020-01-23 20:10:29 +01:00
Joao Moreno df179bf564 rename TreeResourceNavigator2 to TreeResourceNavigator 2020-01-22 16:34:34 +01:00
Andre Weinand 3bdb031a5d fix searching by return proper value for compressed node; fixes #88526 2020-01-16 16:54:19 +01:00
Joao Moreno 9a2874e954 loaded scripts: support filtering across all expanded items 2020-01-16 15:07:08 +01:00
Joao Moreno a2ced2fda7 Merge branch 'master' into aweinand/compressedtree 2020-01-16 14:15:07 +01:00
Joao Moreno 5e6d6f7105 loaded scripts: fix collapsible 2020-01-16 14:05:32 +01:00
Joao Moreno 46a8410015 loaded scripts: adopt object tree 2020-01-16 14:05:21 +01:00
Andre Weinand 2636cfa7ac make LoadedScriptsView's model sync 2020-01-15 18:14:59 +01:00
Joao Moreno ab5986603a Merge branch 'master' into aweinand/compressedtree 2020-01-15 11:34:36 +01:00
Andre Weinand 6278e4ff51 use WorkbenchCompressibleAsyncDataTree 2020-01-15 11:25:32 +01:00
Johannes Rieken 1665beab9e move TitleMenus from customView to ViewPane, also fixes #88557 2020-01-14 16:28:42 +01:00
SteVen Batten cabcace4b5 Viewlet Refactor (#85566)
* wip 2

* use viewlet stubs

* fix layering issue

* fix saveState and contextmenus

* move context menu logic into panecomposite

* revert tasks.json

* tasks again

* add showHeaderInTitleWhenSingleView values

* patch tests

* some cleanup

* more cleanup

* start view

* merging conflicts

* fix title and dnd

* adding missing api surface to pane composite

* additional merge resolution
2019-12-09 15:30:46 -08:00
SteVen Batten 8eaf2a3742 rename splitview panels to panes (#85166)
* rename splitview panels to panes

* rename files

* customViewPane
2019-11-20 10:59:22 -08:00
isidor 8eaf977b90 List, Tree: Make sure sub-pixel antialiasing works across all lists and trees
#84715
2019-11-18 15:31:54 +01:00
Matt Bierner 7d0267f49e Make createInstance stricter (#83472)
Part of #81574

Makes the `createInstance` function signature more strict. Previously it inferred the argument types based on the actual argument values passed to `createInstance`. Instead, we now infer them from the constructor signature itself
2019-10-28 14:30:54 -07:00
Andre Weinand 14d5671058 use session ID instead of session name for ID calculation; fixes #80379 2019-10-23 12:10:18 +02:00
Matt Bierner b0dccbcf75 Marking a bunch of static variables as readonly
Readonly helps out with TS's type guards and is also a good best practice. Specifically, readonly strings/numbers have their literal type instead of a generic `string` | `number` type, which can help catch dead code and some common programming mistakes
2019-10-07 15:40:02 -07:00
Isidor Nikolic 97a05cec1b Merge pull request #80122 from dgozman/fix-79583
Make DebugSession.name writable; fixes #79583
2019-09-05 11:30:30 +02:00
Dmitry Gozman cb6b17d6f3 Make DebugSession.name writable; fixes #79583 2019-09-04 15:06:26 -07:00
Joao Moreno defb2320c1 fixes #80097 2019-08-30 17:36:48 +02:00
isidor 31cd6aea84 strictPropertyInitialization
#78168
2019-08-06 10:50:29 +02:00
Sandeep Somavarapu 2063f65485 Fix #76881 2019-07-29 10:52:45 +05:30
Joao Moreno 105f843840 💄 remove unnecessary list/tree casts 2019-07-23 18:04:56 +02:00
isidor df9ad66def loaded scripts view: add type to not be an array of any 2019-06-06 11:25:13 +02:00
isidor 31221e6299 debug: map polish
#74948
2019-06-06 11:21:24 +02:00
isidor 683d774ed0 loaded scripts: use Map
#74948
2019-06-06 11:21:06 +02:00
Matt Bierner 3132d26813 Have Panel extend Disposable
The panel currently exposes a `disposables` protected member. In order to catch possible leaks of disposables, we should extend `Disposable` instead
2019-06-05 15:42:25 -07:00
Benjamin Pasero 64c3f1a93e debt - reduce explicit any or casts 2019-04-01 08:11:11 +02:00
Benjamin Pasero 2699f06fb9 less implicit any (#70352) 2019-03-22 08:08:16 +01:00
Andre Weinand b206480e2c use LabelService in LoadedScriptsView 2019-03-21 17:35:11 +01:00
isidor de288947bc debt: create tree using instatationService 2019-03-14 17:49:24 +01:00
isidor b4d347d9f6 debug: move debugContentProvider to common 2019-03-14 16:45:57 +01:00
Andre Weinand 8b6c0c5ae5 strict null: loadedScriptsView 2019-03-12 10:38:50 +01:00
isidor aca0a5ed9a Avoid using Object.create(null) to create objects
fixes #67973
2019-02-19 16:24:48 +01:00
Benjamin Pasero 622b3d62dd paths - paths.node.ts => path.ts 2019-02-12 20:36:23 +01:00
Benjamin Pasero f63494e93c debt - clean up sep/nativeSep 2019-02-12 15:19:44 +01:00
Benjamin Pasero 757b99c62d debt - remove vs/base/paths#isAbsolute() 2019-02-12 12:56:28 +01:00
Benjamin Pasero 35523f6c51 debt - workbench/parts => workbench/contrib (update imports and scripts) 2019-02-07 11:48:58 +01:00
Benjamin Pasero 87c5072ab0 debt - workbench/parts => workbench/contrib 2019-02-07 11:46:07 +01:00