Benjamin Pasero
c5b6ef14e6
esm - more cleanup ( #230285 )
2024-10-02 11:55:17 +02:00
Connor Peet
8a32f69162
refactor: cleanup debt for hashing ( #230174 )
...
* refactor: cleanup debt for hashing
- Adds a type to avoid direct usage of sync `hash()` for consumers
working with binary input.
- Moved the previous browser-only `sha1Hex` to `hash.ts` now that
webcrypto is quite universal, including in Node.js since 19.
- Cleaned up some code that is replaced with modern built-in functions
like `TypedArray.fill` and `padStart`.
- The `NotebookSimpleWorker` was manually calculating the hash for
its binary data (probably to avoid the same issue as #229619 ), so
I swapped that to use webcrypto as well which is much speedier for
large inputs (125ms vs 8ms for 10MB of data) @rebornix
Closes https://github.com/microsoft/vscode/issues/229845
* update layer checker
2024-09-30 20:56:03 -07:00
Benjamin Pasero
1d219d75ef
esm - fix layer checker
2024-09-27 08:58:11 +02:00
Sandeep Somavarapu
ebc02af2d8
rename electron-node to electron-utility ( #227672 )
2024-09-05 00:49:23 -07:00
Sandeep Somavarapu
01fcf004a6
Use electron net directly in shared process ( #227553 )
...
* Use electron net directly in shared process
* add built file
* introduce shared electron-node layer
* remove electron-utility layer
* fix (overlook): move back cli files to node
2024-09-04 07:26:43 -07:00
Benjamin Pasero
6b924c5152
ESM merge to main ( #227184 )
...
Co-authored-by: Johannes Rieken <jrieken@microsoft.com >
Co-authored-by: Alexandru Dima <alexdima@microsoft.com >
2024-08-30 10:31:46 +02:00
Matt Bierner
84607a2fe2
Fix some always true/false errors in codebase ( #223359 )
...
* Fix some always true/false errors in codebase
Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase
Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases
* Bump TS version
* Fix unreachable in build scripts
* Bump versions
* restore intent
* Revert package.json change
* Fixing a few new layer checker errors
These are global in node now
* Skip lib check in integration project
* One more skiplibcheck
* More skip lib
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com >
2024-07-30 15:37:27 -07:00
Benjamin Pasero
83f03bbb7b
debt - enlist most JS files in tsconfig.json ( #216566 )
2024-06-19 08:35:55 +02:00
Robo
5216c04428
chore: update to electron 29 ( #209818 )
...
* chore: update electron@29.1.0
* chore: update typings to 20.x
* chore: bump electron@29.1.5
* ci: fix crash in compiling extensions-ci
* chore: disable .d.ts check for build/
$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
Found 2 errors in 2 files.
Errors Files
1 node_modules/@types/chokidar/index.d.ts:21
1 node_modules/chokidar/types/index.d.ts:8
Refs a0f9e09f64eacec5f490tree-sitter-typescript@0.20 .5
* chore: bump electron@29.3.0
* chore: bump electron@29.3.1
* chore: update rpm deps-list for x86_64
* ci: disable io_uring UV backend on linux
* ci: disable io_uring backend for oss as well
* chore: update typings to 20.x
* ci: add TODO for io_uring workaround
* chore: bump distro
* chore: update preinstall node version checks
* chore: update @types/gulp
Refs https://github.com/microsoft/vscode/issues/212442
* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Benjamin Pasero
f9b5584b73
aux window - reduce direct setInterval uses ( #197741 )
2023-11-08 16:09:30 +01:00
Benjamin Pasero
38db856f35
debt - use globalThis and remove deprecated globals ( #197712 )
...
* debt - use `globalThis` and remove deprecated `globals`
* fix build
2023-11-08 09:13:03 +01:00
Benjamin Pasero
3453c4f9f0
aux window - avoid/flag more globals ( #197614 )
...
* aux window - avoid/flag more globals
* fix access from worker
* allow `queueMicrotask`
* more adoptions
* fix build
* avoid $globalThis
2023-11-07 12:52:20 +01:00
Benjamin Pasero
912c2d98e3
aux window - ensure native host service is properly typed in all contexts ( #197527 )
2023-11-06 12:00:24 +01:00
Robo
ea490e5545
chore: update to Electron 25 ( #188268 )
...
* chore: update electron@25.3.0
* ci: update NodeTool version
* chore: update @types/node
* add more common types to layers checker
* chore: update debian dependencies
* chore: update rpm dependencies
* fix: use legacy dns result order of Node.js
* ci: remove deprecated always-auth npm config
Refs npm/cli@72a7eeb
* chore: update deb and rpm dependencies
* chore: update armhf rpm dependencies
* chore: update x64 debian dependencies
* chore: update x64 rpm dependencies
* chore: update electron@25.3.1
* chore: update electron@25.4.0
* chore: bump distro
* chore: bump distro
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2023-08-07 21:46:27 +09:00
Robo
e5f61433b5
chore: update to Electron 22 ( #177600 )
...
* Revert "chore: revert to Electron 19 (#175851 )"
This reverts commit 3a11b47eee#178919 )
* Revert "chore: revert to Electron 19 (#175851 )"
This reverts commit 3a11b47eee💄
* compile
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2023-04-03 09:09:31 +02:00
Robo
3a11b47eee
chore: revert to Electron 19 ( #175851 )
...
* Revert "Update to min supported version of node (#175723 )"
This reverts commit f749e6be2d#175663 )"
This reverts commit f2a822fbe9#175659 )"
This reverts commit 2551af21f8#166430 )"
This reverts commit 6e85d2b51e
2023-03-02 02:58:46 -08:00
Robo
6e85d2b51e
chore: update to Electron 22 ( #166430 )
...
* chore: bump electron@22.0.0-beta.5
* chore: bump electron@22.0.0-beta.7
* chore: update libc++ flags
* chore: switch to c++17
* chore: bump electron@22.0.0
* chore: bump electron@22.0.2
* chore: cleanup build config for linux
* chore: update debian dependencies
* chore: update rpm dependencies
* chore: update electron@22.0.3
* chore: bump electron@22.2.0
* chore: remove deprecated utility process invoker
* chore: bump electron@22.2.1
* chore: remove unused methods
* chore: update internal electron version
* chore: bump electron@22.3.0
* temp: update electron with default PGO
* chore: bump electron@22.3.1
* cleanup
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2023-02-28 07:04:00 -08:00
Benjamin Pasero
9bbce647b3
debt - strict layer rules for more services ( #175411 )
2023-02-25 15:49:47 +01:00
Matt Bierner
99e126b0b2
Pick up latest TS version for building VS Code ( #162786 )
...
Pick up latest TS for building VS Code
2022-10-06 12:08:45 -07:00
Benjamin Pasero
0895639566
debt - mention our wiki when putting out layer errors ( #157768 )
2022-08-10 15:37:21 +02:00
Matt Bierner
a43e9acd68
Add AbortController to core types
2022-08-04 16:26:18 -07:00
Benjamin Pasero
f4f1b04d87
Add a setting to enable sandbox: true for windows ( #154062 )
...
* sandbox - allow enabled sandbox in a full build
* sandbox - reduce `electron-browser` in workbench
* sandbox - reduce `electron-browser` in platform
* sandbox - add a setting to enable sandbox mode for window
* fix lint
* Revert "sandbox - reduce `electron-browser` in workbench"
This reverts commit 36a5167cf96f49d704a5
2022-07-05 09:54:28 +02:00
Benjamin Pasero
be376cfef0
debt - improve ipc validation code
2022-04-12 07:46:21 +02:00
Benjamin Pasero
95c2a71018
Revert "ipcMain validation ( #147071 )"
...
This reverts commit 508b173177
2022-04-11 19:34:12 +02:00
Benjamin Pasero
508b173177
ipcMain validation (#147071 )
...
* first cut ipc validation
* clean up
* comment
2022-04-11 18:11:19 +02:00
João Moreno
d06e16b59a
layer checker: follow parent symbols
2022-04-04 15:05:34 +02:00
Benjamin Pasero
693b2fdbaf
debt - make URL available as core type
2022-04-04 11:21:57 +02:00
Alex Dima
79e83ab7fa
Go back to using buitlin URL
...
This reverts commit 014814146e
2022-03-25 09:25:49 +01:00
Benjamin Pasero
066b362943
fix layers checker to support trace
2022-03-15 21:06:22 +01:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450c3e948aa30
2022-03-11 00:51:37 +09:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c1846301339b7benjamin.pasero@microsoft.com >
2022-02-24 17:49:49 +01:00
Benjamin Pasero
ae0864d995
fix valid layers checker
2022-02-14 08:41:24 +01:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f#136264 )"
This reverts commit af261488f8💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37ca7f1b73951https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com >
2022-02-08 20:09:00 +01:00
João Moreno
5e630c145f
Enable IPC API for web ( #138054 )
...
* wip: ipc api
* wip: send message ports upfront
* address both inside and outside iframe
* fix build
* relay MessagePort to worker
* address api discussion feedback
* check for proposed api
* fix layer breakage
Co-authored-by: Alex Dima <alexdima@microsoft.com >
2022-01-05 02:11:12 -08:00
Benjamin Pasero
70489f2c90
layers - add trimStart and trimEnd
2021-12-14 12:32:10 +01:00
Logan Ramos
76c3eb94c9
On the fly tab model construction ( #133025 )
...
* Enrich the change event
* Initial tab model building
* Work in progress model construction
* Add pauseable emitter
* Attempt using microtask
* Make tests pass
* Update active tab logic
* Fix layering issue
* event rename
* PR feedback
* Remove stray new line
* Add test for microtask emitter
* Add move event
* Add mmerge functionality to Microtask emitter
* Fix compilation errrors
* Fix tests
* Add tests to address feedback
* Change editor change event to an array
* Add array support to editorsChangeEvent
* Update src/vs/workbench/common/editor/editorGroupModel.ts
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com >
* Switch to a less efficient array method
* Add console.log for debugging
* Test with different notebook
* Fix notebook URI
* For now split up file open for better debugging
* Don't use notebook in test for now
* Cleanup event
* Fix tests
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com >
2021-09-16 14:34:54 -04:00
Benjamin Pasero
8f1b7a36de
sandbox - allow to reuse environment service in sandbox
2021-03-15 11:27:31 +01:00
Benjamin Pasero
a6946159d4
💄 layers checker
2020-12-08 09:29:16 +01:00
Benjamin Pasero
50ee84f780
debt - btoa/atob is not core
2020-10-15 13:55:18 +02:00
Benjamin Pasero
01472963d7
sandbox - rename electron service => native host service
2020-09-17 16:20:23 +02:00
Benjamin Pasero
82d30d49b2
sandbox - add electron service to layers checker
2020-09-17 15:43:15 +02:00
Benjamin Pasero
b2acd8fa72
sandbox - make layers checker fit to complain about native things definedin common layer
2020-09-04 10:32:00 +02:00
Benjamin Pasero
3514e96bf5
sandbox - add rules for new electron-sandbox layer
2020-05-22 12:21:25 +02:00
Benjamin Pasero
2095810809
layers check - make sure to test editor contrib as well
2020-02-05 11:19:00 +01:00
Benjamin Pasero
d59de94ba1
💄
2020-01-07 11:19:01 +01:00
Benjamin Pasero
9b6b25112e
💄
2020-01-07 11:10:01 +01:00
Benjamin Pasero
078b82d428
debt - rewrite layers checker to catch more cases
2020-01-07 11:04:05 +01:00
