Commit Graph

126 Commits

Author SHA1 Message Date
Benjamin Pasero c827bd9838 editors - fix API comments around ViewColumn (#158273) 2022-08-16 14:37:06 +01:00
Benjamin Pasero dced70bbf3 Create editor groups from ViewColumn as needed (refs #123270) (#157640)
* make `createTextEditor` async and create editor groups (refs #123270)

* API docs update
2022-08-10 06:51:07 +02:00
Daniel Imms 1a50091667 Finalize TerminalExitReason API
Fixes #130231
2022-08-09 08:10:10 -07:00
Matt Bierner d949bdfb48 Clarify wording in api (#156500)
Clairify wording in api

Fixes #156376
2022-07-27 14:52:17 -07:00
Matt Bierner be910fd929 Use clearer parameter name (#156479)
Fixes #156431
2022-07-27 11:12:45 -07:00
Matt Bierner ead6a6f34f Revert "Temporarily comment out tuple type annotations (#156213)" (#156478)
This reverts commit 8f10b21033.
2022-07-27 19:52:03 +02:00
Alex Ross 3cd638046c Quick Diff editor gutter decoration hidden by comment gutter icon (diamond) (#156448)
* Quick Diff editor gutter decoration hidden by comment gutter icon (diamond)
Fixes #156264

* Update doc
2022-07-27 18:05:02 +02:00
Matt Bierner 9cf2fabdd6 Rename editor.dropIntoEditor.enabled setting (#156381)
Fixes #156344
2022-07-27 06:44:44 +02:00
Matt Bierner 8f10b21033 Temporarily comment out tuple type annotations (#156213)
These seem to be breaking out api generation for the website. Commenting them out for now
2022-07-25 16:32:23 -07:00
Jan Bicker f3b174ef7d Fixed wrong SignatureInformation.activeParameter comment (#155279)
Fixed SignatureInformation.activeParameter comment
2022-07-15 17:38:04 +00:00
Matt Bierner 50056f3e78 Finalize drop into editor api (#155102)
Fixes #142990
Fixes #149779
2022-07-13 12:54:52 -07:00
Johannes Rieken 2e247a1162 tweak event-naming rule and remove disable-pragma from vscode.d.ts, (#154914)
fixes https://github.com/microsoft/vscode/issues/154526
2022-07-12 14:28:07 +02:00
Matt Bierner 290210f496 Allow tree to specify 'files' as drop type (#153751)
For https://github.com/microsoft/vscode/issues/153404#issuecomment-1170400253

This special type indicates that the tree wants to recieve any type of file that is dropped. This matches how the dom drop apis work
2022-06-29 16:30:08 -04:00
Matt Bierner 64305a732e Better handling of text/uri-list in built-in extensions (#153163)
- When splitting `text/uri-list`, we should split on `\n` to handle against spec versions of `text/uri-list`
- However when constructing a `text/uri-list`, we should use `\r\n` to align with the spec
2022-06-24 15:24:16 -07:00
Matt Bierner 001d52cf6b Add Symbol.iterator functions for vscode.d.ts collection types (#151806)
* Add entries functions for vscode.d.ts collection types

Fixes #151802

* Spelling

* Enable lib.iterable in vscode.d.ts

* Switch to use `Symbol.iterator` instead of `entries`

* Use extends Iterable in more places

* Fixing testItemCollection types

* Fixing exthost testing
2022-06-15 16:29:50 +00:00
Matt Bierner 354e1a0595 Finalize data file reading API (#152127)
Fixes #147481
Also reverts #150963 since the `kind` field is not being finalized
2022-06-15 07:56:02 -07:00
Ladislau Szomoru 03be93691c SourceControlInputBox API finalization (#152171) 2022-06-15 15:14:28 +02:00
Matt Bierner 1aa08c988f Pass collection as third paramter to DataTransfer.forEach (#152101)
For #151657

This aligns the signature with our other `forEach` functions

Also fixes `callbackfn` not actually using `thisArg`
2022-06-14 14:39:20 -07:00
Matt Bierner a15d6b41a1 Mark FileSystemWatcher properties as readonly (#152098)
These properties cannot be modified: https://github.com/microsoft/vscode/blob/0656d21d11910e1b241d7d6c52761d89c0ba23a4/src/vs/workbench/api/common/extHostFileSystemEventService.ts#L29
2022-06-14 18:17:50 +00:00
Matt Bierner 5bb16df4b0 Use any instead of unknown for thisArg (#151762)
Standarizing on what TS does in its stdlib
2022-06-10 16:11:22 +00:00
Matt Bierner b331f811c1 Add thisArg to DataTransfer.forEach (#151658)
Fixes #151657

All of our other `forEach` functions take a `this` arg which is used when invoking the callback. This just aligns `DataTransfer.forEach`
2022-06-09 15:55:54 -07:00
Matt Bierner 070fb39a3c Document DataTransferItem (#151442)
This adds missing documentation to the `DataTransferItem` api type
2022-06-07 18:45:48 +00:00
Logan Ramos 84241b284d Fix accidental grammer mistake to .d.ts (#150991) 2022-06-01 17:09:00 +00:00
Tyler James Leonhardt d724243f20 better type docs for validation message (#150923) 2022-06-01 09:07:18 +02:00
Benjamin Pasero b0cfb974f5 showTextDocument is not respecting preview: true if user has enablePreview disabled (fix #149088) (#150552) 2022-05-27 16:32:25 +00:00
Henning Dieterichs 3ab95815b5 Fixes nits. 2022-05-24 14:57:08 +02:00
Henning Dieterichs 9ef07308ea Finalizes inline completions 2022-05-24 12:52:19 +02:00
Matt Bierner 45304da73d Finalize NotebookEditor api proposal (#149767)
* Finalize NotebookEditor api proposal

Fixes #149271

This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:

- The deprecated properties/functions
- A few contribution points such as `notebook/cell/executePrimary`

* remove extra quote
2022-05-23 23:27:17 +00:00
Tyler James Leonhardt 2d9244c330 Finalize InputBoxMessageSeverity API (#148961) 2022-05-06 14:37:40 -07:00
Johannes Rieken a7d1f3a91d Merge pull request #147926 from microsoft/joh/primitiveContext 2022-05-06 10:38:00 +02:00
Tyler James Leonhardt 6c8d8a2654 Have forceNewSession behave like createIfNone if no sessions are present (#148819)
* Have forceNewSession behave like createIfNone if no sessions are present

* include note in vscode.d.ts about forceNewSesssion behavior
2022-05-05 13:30:14 -07:00
Johannes Rieken 41804a8daa Merge branch 'main' into joh/primitiveContext 2022-05-04 08:48:39 +02:00
Logan Ramos d8d25af3ab Fix #148296 2022-04-27 13:53:16 -04:00
Logan Ramos d5a33a82b8 Spelling fixes 2022-04-27 09:54:19 -04:00
Johannes 41b739c68e allow for primitve arrays and primitive objects 2022-04-25 14:26:42 +02:00
Logan Ramos fccec519f8 Address some grammar 2022-04-22 09:26:57 -04:00
Logan Ramos aa69f3d762 Fix #15178 Finalize tabs API 🎉 2022-04-21 11:08:12 -04:00
Alex Ross 26f019d919 Comment API docs 2022-04-21 11:20:50 +02:00
Johannes 9530dca29d finalize notebookDocumentEvents-API, https://github.com/microsoft/vscode/issues/144662 2022-04-20 13:58:37 +02:00
Matt Bierner 973ebbcdd8 Better spelling 🪄 2022-04-19 19:32:19 -07:00
Matt Bierner 4a6a56a581 Spelling 2022-04-19 10:16:27 -07:00
Matt Bierner 56bc85e2df Add readonly to args 2022-04-19 10:14:39 -07:00
Benjamin Pasero e6d98a13fc watcher - allow relative patterns for include (#146335) 2022-04-16 07:22:33 +02:00
Greg Van Liew 4ebdb61c69 Switch to signal quotes (#147261) 2022-04-11 15:59:19 -07:00
Matt Bierner 21173541e1 Make postMessage's behavior more sane
Fixes #146253

Two parts to this change:

- Make postMessage return false if a message cannot be delivered to a webview

- Don't queue messages for hidden (and non-retained) webviews. This was potentially causing a huge flood of messages to be dumped into the webview once it becomes visible again
2022-04-11 15:18:41 -07:00
Benjamin Pasero b261d64b68 api - update watcher docs
//cc @lszomoru
2022-04-06 08:26:48 +02:00
Benjamin Pasero a5a81f9575 api - update watcher docs
//cc @lszomoru
2022-04-06 07:15:13 +02:00
Matt Bierner f8a64a1482 Adding readonly to a few more array arguments 2022-04-05 11:06:37 -07:00
Matt Bierner c60ec4e4ce Mark tree drag api arrays are readonly
This makes is more clear that you can't modify the drop/drop mime types arrays to update them
2022-04-05 11:06:36 -07:00
Matt Bierner 52a7f7a1f8 Clairify that provider should not modify input positions 2022-04-05 11:06:36 -07:00