Commit Graph

12525 Commits

Author SHA1 Message Date
Sandeep Somavarapu
c8ee8a25c5 adopt snippets with profile change (#153079)
* adopt snippets with profile change

* feedback
2022-06-24 10:10:22 +02:00
Benjamin Pasero
0dfbf42795 tests - skip all flaky webview tests (#153066) (#153067) 2022-06-23 22:51:58 -07:00
Matt Bierner
d6497d3db1 Use ResourceMap (#153051)
Replaces `Set` of uris with a `ResourceMap`
2022-06-24 01:00:05 +00:00
Matt Bierner
9b7696cc9c Fix notebook links to other docs in edited markdown cells (#153052)
Fixes #148199

This makes us resolve links in notebooks relative to the notebook document instead of relaitve to the cell
2022-06-23 20:55:08 -04:00
Matt Bierner
ab7bc9fb0b Split up MD link tests (#153048)
This splits the markdown link tests in two:

- Tests for detecting links in md files (`MdLinkComputer`)
- Tests for the actual vs code editor link provider

Also fixes a few cases splitting these tests up caught
2022-06-23 17:53:56 -07:00
Logan Ramos
4a7a6a597a Update extension telemetry modules (#153057) 2022-06-24 00:53:23 +00:00
Alex Dima
bae316c7ad Merge remote-tracking branch 'origin/main' into alexd/worrying-bandicoot 2022-06-23 22:45:59 +02:00
Ladislau Szomoru
25cc6c0dd0 Git - Remove git.branchProtectionIndicator setting (#153020)
Remove git.branchProtectionIndicator setting
2022-06-23 21:56:54 +02:00
Matt Bierner
385bf5036b Optimize NoLinkRanges lookup (#153010)
This switches us to use a map to check if a position exists inside the no link ranges
2022-06-23 11:38:13 -07:00
Benjamin Pasero
a9cacc5d9a skip flaky webview test (#150682) (#153006) 2022-06-23 17:43:04 +00:00
Daniel Imms
96ca51210f Merge pull request #152967 from microsoft/tyriar/152966
Fix initial compilation problem matching in tsc-watch
2022-06-23 10:31:51 -07:00
Henning Dieterichs
a2eccb109e Merge pull request #152865 from microsoft/3wm 2022-06-23 17:35:24 +02:00
Daniel Imms
e733f73119 Merge pull request #152973 from microsoft/tyriar/152780
Fix terminal selection contrast in solarized light
2022-06-23 08:28:13 -07:00
Ladislau Szomoru
1513f91ac2 Git - fix regression with creating an empty commit (#152974) 2022-06-23 16:06:06 +02:00
Raymond Zhao
70738ed4f2 Fix Emmet integration test warning, fixes #152827 (#152925) 2022-06-23 06:57:26 -07:00
Daniel Imms
fc7ba026bf Fix terminal selection contrast in solarized light
Fixes #152780
2022-06-23 06:05:06 -07:00
Daniel Imms
f0cf1ea129 Fix initial compilation problem matching in tsc-watch
Fixes #152966
2022-06-23 04:48:25 -07:00
Matt Bierner
07144d22c4 Rename types in the markdown extension (#152905)
Renames in the markdown extension

This renames some types and splits up some files as part of an exploration towards a proper LSP. Changes:

- `SkinnyTextDocument` -> `ITextDocument`
- Moved `ITextDocument` to own file
- `MdWorkspaceContents` -> `IMdWorkspace`
2022-06-22 14:12:48 -07:00
Raymond Zhao
5f0a3888b4 Fix command encoding. Fixes #151364 (#152896) 2022-06-22 14:12:32 -07:00
Ladislau Szomoru
b9484e8e16 SCM - Action button localization fix (#152903)
* Localization fix

* Fix typo in key
2022-06-22 19:27:27 +00:00
Miguel Solorio
901b2a0299 Add listActiveSelectionFocus color token (#152260)
* Add listActiveSelectionFocus color token (Refs #151577)

* Update colors

* Update color token name to `listFocusAndSelectionOutline` and re-order
2022-06-22 12:24:49 -07:00
Matt Bierner
be1ee5d9f1 Re-validate md files when a linked to file is created or deleted (#152520) 2022-06-22 19:02:46 +00:00
Sandeep Somavarapu
a1e1e307e3 introduce application config model (#152889)
* introduce application config model
- application configuration is active and used only in non default profiles
- read/write application scoped settings only from application layer and not from user layer
- extensions get application scoped values as global values
- settings editor does not show application scoped settings in non default profle
- added unit tests

* fix tests
2022-06-22 11:57:39 -07:00
Ladislau Szomoru
df0fc08407 Git - Fix configuration service warnings (#152867)
Fix configuration service warnings
2022-06-22 15:58:57 +02:00
Matt Bierner
321423db2b Standardize text/uri-list handling (#152756)
This creates a common set of functions for creating and parsing the `text/uri-list` mime type. As part of this, I also aligned us with the standard, which uses `\r\n` between lines instead of just `\n`
2022-06-22 13:53:37 +02:00
Ladislau Szomoru
08a46984d6 SCM - Add capability to disable the SCM action button (#152849)
Add capability to disable the SCM action button
2022-06-22 13:01:20 +02:00
Henning Dieterichs
b673b4274d Some 3wm cleanup. 2022-06-22 11:49:09 +02:00
Ladislau Szomoru
75362a6268 Git - add settings to control the branch protection indicator (#152469)
* Add settings to control the branch protection indicator

* Pull request feedback
2022-06-22 01:02:13 -07:00
Matt Bierner
5437480941 Enable md paste actions by default (#152810)
Turns on pasting of links for easier testing. However `editor.experimental.pasteActions.enabled` is still off by default so this won't be enabled by default
2022-06-22 08:19:52 +02:00
Benjamin Pasero
886c112cbd Merge branch 'main' into alexd/worrying-bandicoot 2022-06-22 06:48:39 +02:00
Rich Chiodo
f361c5b71d Halve the number of executions to speed up test (#152768) 2022-06-22 06:24:21 +02:00
Matt Bierner
c84655d123 Reduce recomputation of state in markdown extension (#152804)
* Reduce recomputation of state in markdown extension

- Use `getForDocument` more often to avoid refetching documents
- Debounce `MdTableOfContentsWatcher`. We don't want this to trigger on every keystroke :)

* Cache LinkDefinitionSet

* Add test file change

* Fix toc watcher for tests
2022-06-21 16:25:10 -07:00
Matt Bierner
389aa8a935 Fix MdDocumentInfoCache computing values twice (#152799)
* Fix MdDocumentInfoCache computing values twice

Fixes a race where values could be computed twice before being cached

* Remove only
2022-06-21 16:22:07 -07:00
Matt Bierner
d5a75f2ceb Add logging for MD language features (#152792)
This verbose logging will help track down inefficient calling patterns (such as recomputing stuff)
2022-06-21 14:18:36 -07:00
Matt Bierner
bbe7b54cf4 Remove custom editor tests (#152777)
These tests are not actively being run or maintained. Removing them for now
2022-06-21 15:37:19 -04:00
Matt Bierner
fa53aa6fec Cleanup pass for md extension (#152760)
Clean up names in md extension
2022-06-21 15:36:32 -04:00
Henning Dieterichs
467eef9270 Sets titles to yours and theirs in the git extension & swaps order. Fixes #150853 2022-06-21 17:23:21 +02:00
Alex Dima
617abbf3a1 Merge remote-tracking branch 'origin/main' into alexd/worrying-bandicoot 2022-06-21 14:55:00 +02:00
Henning Dieterichs
50255ca91e Merge pull request #152691 from microsoft/rzhao271/inline-completion-description 2022-06-21 14:24:40 +02:00
Matt Bierner
2249b171f4 Reduce number of times MD docs are re-tokenized (#152674)
This change reduces the number of times we retokenize a markdown file by doing the following:

- Use `MdTableOfContentsProvider` in more places
- Introduce a `IMarkdownParser` interface that lets us drop in a caching version of the tokenizer
2022-06-21 08:43:01 +02:00
Raymond Zhao
9ef049b089 Add note to description 2022-06-20 17:15:07 -07:00
Matt Bierner
369252a027 Skip diagnostics for non-open md files (#152687)
Currently we only show diagnostics for opened tabs. This means we shouldn't waste time computing diagnostics for these non open files
2022-06-20 16:39:01 -07:00
Matt Bierner
0bc3109761 Don't try parsing non-markdown files (#152661)
This fixes our references and rename provider to not try parsing non-markdown files as if they were markdown
2022-06-20 10:44:50 -07:00
Matt Bierner
4c72dedb4a Optimize markdown workspace scanning (#152563)
* Optimize markdown workspace scanning

- Adds cache for markdown file
- Avoid reading non-markdown files from disk (when we expect markdown files)
- Use `range.contains(pos)` instead of `range.intersects(range)`

* Don't remove cached document on change

We only want to invalidate the cached document when it is first opened (since the cached version is the one from disk). Otherwise we can use the live version of the doc
2022-06-19 09:40:10 -07:00
Matt Bierner
5a175207de Improve markdown link regexp (#152533)
* Improve markdown link regexp

This makes the markdown link regexp more readable and also combines the two regular expressions we were running

* Fixed backtracking
2022-06-19 06:25:54 +02:00
Benjamin Pasero
0203aabaa5 fix integration tests 2022-06-18 07:44:05 +02:00
Matt Bierner
78597fd026 Don't hardcode use of github slugifier (#152507)
Use `engine.slugifier` for this instead
2022-06-17 17:25:54 -04:00
Matt Bierner
dea813ff7c Add table of contents provider abstraction (#152504)
We currently re-compute the same table of contents for markdown files multiple times. This is because multiple language features all need table of contents

With this change, we introduce a new `TableOfContentsProvider` which maintains a cache of the table of contents per file. This provider is then passed into every caller that needs a toc
2022-06-17 18:20:02 +00:00
Martin Aeschlimann
083cf01e10 json indent pattern: handle escape characters (#152475) 2022-06-17 14:31:03 +00:00
Alex Ross
4e53b01452 Pull in cpp grammar fixes (#152449) 2022-06-17 11:17:09 +00:00