Commit Graph

1641 Commits

Author SHA1 Message Date
Benjamin Pasero
cbdfe4e0b4 Removal of feedback control (fix #188960) (#189027) 2023-07-28 10:12:52 +02:00
Aiday Marlen Kyzy
398e46ca68 Make content hover text use full possible width (#187597)
* combinging the setting of max dimensions on the container and on the contents dom node

* adding the css variable in order to be able to specify the max width of the content inside

* cleaning the code

* changing the name of the variable

* cleaning the code

* placing the hover max width variable into the others category of vscode-known-variables json file

* defining a fall back value of 500 pixels

* inlinging the code

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2023-07-26 08:54:48 +02:00
Michael Lively
28e972e496 initial stickyScroll support for notebooks (#188323)
* stickyscrool wip. dom node + filler static content

* headers rendering. todo: too early, multiple headers

* css file movement + outline rework

* kernel css move

* pop-in fixed // css cleaned // setting added

* fix override

* low hanging fixes

* refactor to remove unnecessary layer

* section transition logic cleanup + other misc fixes

* whoops changed a little too much. todo: linesToRender thinking

* finalized logic

* nits

* def false

* Update zindex

* Fix font size

---------

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2023-07-20 15:50:39 -07:00
weartist
2fd4a2523e remove unnecessary code 2023-07-19 09:25:48 +08:00
weartist
75f5fc5073 fix spell 2023-07-18 17:23:58 +08:00
Aiday Marlen Kyzy
e1becd2eb8 cleaning the code, it works now 2023-07-12 12:49:48 +02:00
Henning Dieterichs
6bbb128304 Merge pull request #178112 from mwerschy/rainbow-indent
Implement indent guide colorization options.
2023-07-05 18:20:29 +02:00
Johannes
eeae481e47 set emit-target and libs to ES2022, avoid static-blocks, fix Error#cause conflict
https://github.com/microsoft/vscode/issues/185991
2023-06-30 11:43:19 +02:00
isidor
d47a27cfe6 still register workbench.enableExperiments 2023-06-27 15:01:06 +02:00
Isidor Nikolic
4b5db322fd Merge branch 'main' into isidor/courageous-yak 2023-06-27 10:32:23 +02:00
Tyler James Leonhardt
8245737e93 Use setUsePlainTextEncryption properly and allow control of password-store via argv.json (#186207) 2023-06-26 14:23:30 -07:00
Jacek Kopecký
b97d99f428 Add tabSizingFixedMinWidth setting (#185766) (#186058)
* Add tabSizingFixedMinWidth setting (#185766)

* Add forgotten case for wrapping tabs

* address feedback

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-06-26 14:58:37 +00:00
Isidor Nikolic
6c24374696 Merge branch 'main' into isidor/courageous-yak 2023-06-26 15:46:13 +02:00
Johannes
56c917debf update SWC config to disable useDefineForClassFields 2023-06-23 12:55:32 +02:00
Benjamin Pasero
7190530d35 readonly - adopt readOnlyMessage for readonly mode (#185756) 2023-06-21 14:40:17 +02:00
Connor Peet
2138622b04 build: add watch/compile tasks for CLI (#182344)
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
2023-06-20 14:34:11 -07:00
isidor
6af591662a remove workbench/contrib/experiments 2023-06-20 14:36:56 +02:00
Henning Dieterichs
085399feff Merge pull request #185592 from microsoft/hediet/b/horizontal-ladybug
Diff Editor v2 Improvements
2023-06-19 18:53:59 +02:00
Henning Dieterichs
60b19b3dd8 Unchanged collapsed code improvements 2023-06-19 17:25:27 +02:00
Robo
4df3657b4e chore: add checksum for electron assets (#185568)
* chore: add checksum for electron assets

* chore: bump distro

* chore: add pdb checksums
2023-06-19 23:46:41 +09:00
Henning Dieterichs
b975405819 Diff Editor v2: Iterates on collapsed unchanged code feature. (#185499) 2023-06-19 12:41:17 +02:00
Robo
8fb5ea0142 feat: use custom tag instead of custom version for MS electron releases (#181309)
* feat: use custom tag instead of custom version for MS electron releases

* chore: bump @vscode/gulp-electron

* chore: move build id to .yarnrc

* chore: rename enableUNCAccessChecks => restrictUNCAccess

* chore: update electron@22.3.11

* chore: add build info to about dialog

* chore: simplify helper function

* chore: remove unused node.js checksums

* chore: bump nodejs internal version

* chore: bump distro

* fix: revert changes to sign.ts

* chore: bump distro
2023-06-17 03:03:35 +02:00
Johannes Rieken
72e2af69c9 joh/high loon (#185337)
* allow session creation to be cancelled

* define background colors, make sure to reshow after session is ready, reset selection style on hide
2023-06-16 16:45:44 +02:00
Matt Bierner
aa82bd59b2 Limit worker pool size (#185164)
Fixes #185079

Should fix OOM issues on build machines
2023-06-14 23:57:22 +02:00
Benjamin Pasero
8afb685c9b eng - add checksum validation support to nodejs and extensions (#184877)
* eng - add `checksum` validation support to `remote`

* eng - wire in more `checksum` support

* eng - renames for remote fetching

* eng - renames for remote fetching

* eng - disable verbose

* eng - always fetch verbose in CI

* eng - 💄

* eng - add checksums for node

* eng - report checksum matches

* eng - fix build

* eng - warn when not being able to check sum

* eng - support checksums for built in extensions

* eng - clear todo

* eng - add nodejs metadata to product.json

* 🆙 version

* 🆙 distro

* update distro

* eng - switch to checksum file

* cleanup alpine

* fix alpine

* fix bug

* eng - fetch all from remote

* eng - 💄

* eng - print checksums

* eng - fix missing import

* 🆙 distro

* undo version change
2023-06-14 16:57:06 +02:00
Benjamin Pasero
4b939d0a0e unc - fix path traversal bypass (#185048) 2023-06-13 19:56:46 +02:00
Matt Bierner
debcf16fcd Mangle exported symbols (#182935)
* Mangle exported functions

For #180461

This prototype tries to mangle exported functions, saving a further 440kb from the bundle size

* Fix missing call

* Also try mangling top level exported consts too

* Fixing errors

* Don't run on build files

* Skip a few more manglings and revert change to namespace

* Skip a few more monaco files

* Also mangle consts that shadow types

This increases savings up to 3325

* Also mangle exported classes

* Skip mangling more localization functions for now

* Opt out pfs

* Update build script

* Run find locations task in parallel

This should speed up compile

* Cleanup before close

* Limit workers to avoid hitting memory limit

* Limit pool size

* Skip one more mangling

* Exclude entrypoints from mangling

* Try to fix web build and clean up code

* Exempt a few more projects

* Exempt another file

* Also exempt html

* Skip mangling ext entrypoints

* Use prefix that can't be confused with rpc calls

* Fix max call stack error

* Switch prefixes

* Don't mangle ambient declarations

* Use correct way of checking modifier flags

* Workaround getCombinedModifierFlags not doing what I'd expect

Maybe needs the checker to be enabled too? Just check parent chain instead for now

* Clean up code and add logic showing how enum mangling could work

* Remove a few more skipMangles

Use entrypoints instead

* Fix entrypoint name
2023-06-13 08:18:05 +02:00
Sandeep Somavarapu
46041c9f0e Implement troubleshoot issue (#184901)
* implement troubleshoot issue action

* move issue troubleshooting to a service

* feedback

* fix stable check
2023-06-12 13:37:50 +02:00
Raymond Zhao
06ae4b61c2 Bump windows-mutex to 0.4.4 (#184366)
Also adds OS-specific .moduleignore files
2023-06-09 09:40:10 -07:00
Benjamin Pasero
eac16e9b63 eng - make fetchWithRetry more robust (#184716) 2023-06-09 14:05:38 +02:00
Aiday Marlen Kyzy
7dafe5df1d renaming the CSS variable names and the labels from interactive editor to inline chat 2023-06-08 14:41:41 +02:00
Johannes Rieken
d8dcdb924a Merge pull request #184575 from microsoft/joh/protective-cicada
joh/protective cicada
2023-06-08 12:15:04 +02:00
Johannes
978bb08619 add extensions-ci-pr task which does a full build without mangling 2023-06-07 16:36:02 +02:00
Aiday Marlen Kyzy
c529638000 renaming the content inside of inlineChat folder from IE to IC 2023-06-07 16:02:34 +02:00
Benjamin Pasero
e615a31faf eng - increase remote download retries (#184431) 2023-06-06 19:22:56 +02:00
Johannes Rieken
f70686c39e chore - rename interactiveEditor to inlineChat (#184422) 2023-06-06 16:34:55 +02:00
Henning Dieterichs
aa88e727da Implements initial version of moved code detection. (#184336)
* Implements initial version of moved code detection.

* Fixes monaco.d.ts

* Fixes tests.
2023-06-05 08:50:55 -07:00
Johannes
946cdaa03c stub out cropped/expanded as CSS variables 2023-06-05 14:58:04 +02:00
Connor Peet
ccc5e48e92 fix: breakpoints in extension subdirs on windows not working (#184195)
It did not normalize to forward slashes, so the empty sourcemap was
created with a source called `foo\\bar.js`. Then the build process was
adding a new source `foo/bar.js` since it didn't see it already in the
sourcemap, but `foo\\bar.js` was later normalized. This normalized
version came first in the mapping, but didn't have any mapped locations,
so breakpoints never got set.
2023-06-02 20:15:04 +02:00
Robo
0c1e34fa4e chore: update electron@22.5.5 (#184115) 2023-06-01 21:38:57 -07:00
Martin Aeschlimann
3f5def1cdc Add logging to node download (#184070)
Add logging to node download. For #182951
2023-06-01 16:42:36 +02:00
Robo
c26003f37a chore: update electron@22.5.4 (#183716) 2023-05-29 16:09:35 +02:00
Henning Dieterichs
46132523d0 Merge branch 'main' into rainbow-indent 2023-05-26 17:57:21 +02:00
Henning Dieterichs
397f2e7c34 First draft of diff editor v2. 2023-05-26 15:26:31 +02:00
Bhavya U
049ee36265 Initial welcome widget commit (#183446)
* Initial welcome widget commit

* Update i18n.resource.json for welcomeDialog

* Clean up code
2023-05-26 00:03:23 +02:00
Joyce Er
bc1090cc10 Initial share provider API and UI (#182999)
* Formalize share provider API

* i18n.resources.json

* Don't introduce a generic Success dialog severity
2023-05-22 15:32:43 -07:00
Jacek Kopecký
cbbd9220c2 Add settings for fixed-width tabs (#181729)
* Add settings for fixed-width tabs

This is meant at least partially to address #40290 and
is a continuation of the unfinished work from #40750.

* Only apply fixed width when the setting is on

* Implement chrome-like tab width behavior

Tabs shrink uniformly (down to a limit) but stay fixed-width
when the mouse is over the tab bar.

* Rename width setting to max width

* Make the ifs more readable

* Have event handlers only if the option is set

* 🎨

* Handle sizing artifacts present with wrapping tabs

To achieve this, it's best to remove the transition delay.

* Rename setting to apply only for fixed-sized tabs

* Set default fixed max tab width to 160px

* Minor code tweaks from review comments

* formatting

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Use disposable listeners

* Remove redundant check for last-in-row

* Apply fade gradient from shrink tabSizing to fixed

* Trying to make the code cleaner and understandable

* Remove transition

On advice of @bpasero, removed transition because
the editor doesn't really use transition that much.

* some cleanup

* fix typo

* Simplify workaround for the overflow issue

* 💄

* 💄

* Let the tabs fix their width before closing the editor

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-05-22 15:32:52 +00:00
Robo
ced29a4346 chore: update electron@22.3.10 (#183116) 2023-05-22 16:34:36 +02:00
Benjamin Pasero
487a08afe5 Investigate detecting slow network connections (#178553) (#182653) 2023-05-22 14:38:13 +02:00
Rob Lourens
d052d3190f More "chat" renames (#182990)
* More "chat" renames

* More renames
2023-05-19 16:14:43 -07:00