Commit Graph

1259 Commits

Author SHA1 Message Date
Andrea Mah
9ee1906718 pr feedback and combining prevEditor info for preview and non-preview 2021-05-19 16:57:12 -06:00
Henning Dieterichs
a1af8aa651 Refactors calls to languages.setLanguageConfiguration to declarative descriptions in language-configuration.json. This fixes #98621. 2021-05-17 09:12:01 +02:00
Andrea Mah
94498778fb cleanup 2021-05-13 15:24:56 -06:00
Andrea Mah
9731995d94 addressed ! nit 2021-05-13 12:39:52 -06:00
Andrea Mah
3dec3b3385 applied PR feedback 2021-05-13 12:30:10 -06:00
Matt Bierner
66fa5c41b3 First cut at unifying notebook renderers apis
This implements the api described in #123540. Major points:

- Instead of having the `markdown-it` renderer pull it its dependencies, instead the dependencies can call `getRenderer` to import the object returned by the `markdown-it` renderer

- We try to detect if a renderer is using the old or new api. Old renderers are still run as globals while new ones are loaded with `import`

- I have only hooked up the new API for markdown renderers so far
2021-05-12 19:32:57 -07:00
Andrea Mah
d2894562d5 fixing issue with static scroll alongside text editor 2021-05-12 17:59:00 -06:00
Andrea Mah
ee4510b4bf Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state 2021-05-12 17:01:41 -06:00
Andrea Mah
18950181eb scroll state persists while toggling between static preview and text 2021-05-12 16:59:57 -06:00
Matt Bierner
11a8c4b4bc Merge the notebookMarkupRenderer contribution point into the renderers contribition point
For #123540
2021-05-12 13:28:28 -07:00
Andrea Mah
927e791753 Fix Initial Scroll Position on Markdown Dynamic Preview (#123613)
* added semicolons to pass code check

* removed preliminary work for static preview

* cleanup

Co-authored-by: Andrea Mah <t-andreamah@microsoft.com>
2021-05-11 17:12:19 -07:00
Matt Bierner
13d81db250 Don't insert link element into the markdown cell preview body
Fixes #123012
2021-05-05 14:35:46 -07:00
Logan Ramos
656e1e6086 More deprecated assertion cleanup 2021-05-04 15:55:26 -04:00
Robo
bce4d71f64 chore: bump node@14.x in devDependencies (#122905) 2021-05-04 10:04:13 +02:00
Matt Bierner
7770708545 Reapply markup renderers change
Rewriting how we do replacements in the webviewPreloads function to hopefully handle optimization better
2021-04-28 10:44:25 -07:00
Matt Bierner
fe7c5aba01 Revert "Better notebook markup renderer api (#121882)"
This reverts commit 4cb27d2ec7.
2021-04-26 19:43:16 -07:00
Matt Bierner
4cb27d2ec7 Better notebook markup renderer api (#121882)
* Better notebook markup renderer api

For #121256

- Use js modules for notebook output renderers
- Rename apis from `markdown` to `markup`
- Use imports and exports for apis instead of globals for apis
- Use esbuild instead of webpack so we can emit js modules
- Clearly split top level markup renderes from renderers that extend other renderers

* Use constant instead of comment for replacement
2021-04-26 16:30:34 -07:00
Sandeep Somavarapu
ac151b40a5 enable virtual workspace capability 2021-04-23 10:20:23 +02:00
SteVen Batten
f9fc28d47d update ext manifest schema validation and built-in exts 2021-04-21 11:54:42 -07:00
Sang
e5c466f587 markdown-language-features: Fix Windows Preview Link Uri (#120090)
* markdown-language-features: fix windows file uri

* refactor: use Uri.joinPath instead
2021-04-19 17:31:07 -07:00
Benjamin Pasero
14981ce89d tests - enable colors for windows (CI supports it and the new Windows terminal too) 2021-04-19 09:29:20 +02:00
Matt Bierner
293061802c Add workspace trust for markdown extension 2021-04-14 20:33:20 -07:00
Matt Bierner
119581fc2a Use more standard name for shared extension tsconfig
This enables Intellisense in the `tsconfig.base` file
2021-04-12 15:58:38 -07:00
Matt Bierner
d5f4e119e0 Use Array.from's map directly instead of a second call to map 2021-04-12 14:42:39 -07:00
Matt Bierner
73ae56b82b Build with latest TS nightly (#120690)
* Pick up new TS 4.3

Also tests adding override keywords for extensions as part of #120675

* Update to daily TS and workaround TS 4.3 issue

Works around https://github.com/microsoft/TypeScript/issues/43578
2021-04-07 12:19:05 -07:00
Matt Bierner
d4412e708a Render markdown preview cells inside a shadow dom (#120137)
* Render markdown preview cells inside a shadow dom

Fixes #119971

This moves all markdown previews into shadow doms. This lets us prevent styles from outside the preview leak into the preview, and also prevents styles from the preview leak out into the rest of the notebook

* Use composedPath for handling events in webviews

This lets us handle clicks triggered inside of a shadow dom
2021-03-30 14:17:15 -07:00
Daniel Imms
06ce7bd297 Fix hygiene 2021-03-29 14:40:01 -07:00
William Desgardin
30ccdf6b6c feat: add typographer option for markdown preview (#119641)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2021-03-29 14:18:59 -07:00
gregvanl
975115a2cb Setting descriptions typos and formatting 2021-03-25 10:17:31 -07:00
Matt Bierner
e3e7fb0b2a Set explicit mode for markdown preview code
Fixes #119813
2021-03-24 12:30:37 -07:00
SteVen Batten
9c00242866 updating telemetry module for built-in exts 2021-03-22 16:28:08 -07:00
Matt Bierner
5c0c637a04 Make sure we ignore compiled media files 2021-03-19 12:12:59 -07:00
Matt Bierner
c0885dd0c4 Add task to build extension media (#119294)
This lets us avoid checking in the compiled js files that are used inside webviews and notebooks
2021-03-18 19:15:59 -07:00
Matt Bierner
581a659d42 Update markdown notebook scripts 2021-03-16 17:28:29 -07:00
Matt Bierner
9b2ee7fb7d Reduce size of Katex bundle
Only load woff2 fonts instead of including all fallback font types in the bundle
2021-03-10 19:56:46 -08:00
Benjamin Pasero
e916637528 tests - enable color output for integration tests 2021-03-01 15:10:15 +01:00
Manuel Thalmann
cdd7066f00 Allow Markdown-Rendering Without Providing an Env-Parameter (#117041)
* Add a rule for initializing the image-stabilizer

* Only use `containingImages` if the variable exists
2021-02-22 14:02:36 -08:00
Habib Karim
9f08368e92 Handle normalized absolute file paths on markdown preview link click (#116649)
* Handle normalized absolute file paths on markdown preview link click #115812

* Parse file path using vscode.Uri
2021-02-18 19:07:22 -08:00
Matt Bierner
96718c6fe8 Add back build-notebook script 2021-02-11 17:21:30 -08:00
Matt Bierner
9b4f1aff5d Enable inline html tags in notebook markdown
Fixes #113351
2021-02-11 17:21:30 -08:00
Matt Bierner
6dd156d04b Support drag and drop copy for markdown cells
For #116393

Also removes some logging and improves drag/drop responsiveness
2021-02-10 17:37:51 -08:00
Matt Bierner
35f855796b Add support for markdown notebook renderers (#115191)
* Use shared webpack version instead of installing locally for simple-browser

* Use npm for building markdown preview

* render markdown in webview.

* update markdown preview height and offset

* Add basic custom notebook renderer point

* update css

* style update.

* update markdown header padding left

* Add example of loading katex to extend the markdown-it renderer

* Rename global to make clear it only applies to markdown-in

* hide/remove markdown preview

* Add wait for initial markdown preview rendering before showing notebook

* Add double click to switch to editing mode

* Fix markdown cells not getting updated after editing

* style polish

* notebook.experimental.useMarkdownRenderer

* switch render strategy.

* Adding very intial drag drop support for notebook markdown cells

* Implement drag/drop stubs for test classes

* Revert unrelated file changes

* Move markdown notebook math to own extension

* Add missing imports

Co-authored-by: rebornix <penn.lv@gmail.com>
2021-02-10 16:41:53 -08:00
Matt Bierner
91a20c06b9 Use npm for building markdown preview 2021-02-09 17:47:32 -08:00
João Moreno
ec805db5ed add repository field to extensions package.json 2021-01-29 15:30:45 +01:00
João Moreno
9a5d14e307 run prettier over extensions json files 2021-01-29 15:19:18 +01:00
David Sanders
7b317afd93 Fix starting scroll for URIs with fragment (#111126) 2021-01-22 17:41:25 -08:00
Henning Dieterichs
1f8643ef76 Refresh Images In Markdown Preview On Change (#114083)
* Refresh Images In Markdown Preview On Change (implements #65258).

* Fixes tests.

* Implements etags.

* Adds tests for urlToUri.

* Updates doc comment.
2021-01-19 18:01:21 -08:00
Jean Pierre
7f4d67c94c Fix #110812 (#114553) 2021-01-19 14:21:02 -08:00
Matt Bierner
a68f1326e8 Update built markdown preview code 2021-01-15 10:38:50 -08:00
Takashi Tamura
a34e751b01 Fix scrolling of markdown preview. Close #65504 (#111094)
* Fix scrolling of markdown preview.

* Use scrollDisabledCount.

* Stop initializing scrollDisabledCount.

* Make scrollTo enough large to occur scroll events.

* Should resolve when the error event occurs.
2021-01-14 17:24:08 -08:00