Commit Graph
56 Commits
Author SHA1 Message Date
isidor caa19dc534 debug: use .find not .filter .pop() 2020-05-05 15:35:47 +02:00
isidor aa0f90749f aria labels: use comma as separator
fixes #96046
2020-05-04 18:07:07 +02:00
isidor 86161ffb98 list: introduce accessibilityProvider.getWidgetAriaLabel 2020-04-22 15:27:42 +02:00
João Moreno 15c02dca3a fixes #95508 2020-04-17 11:01:34 +02:00
isidor 39ebbba9a8 fix collapse all not working
fixes #95440
2020-04-17 09:09:10 +02:00
João Moreno 9e9ee4d3dd fixes #94544 2020-04-08 10:52:04 +02:00
isidor c033ceaa24 debug: smarter scope id computation so expansion state is more preserved. Also if all collapsed, expand first non expensive scope
fixes #93230
2020-03-24 18:59:38 +01:00
Connor Peet 9610d997af fixup! more pr comments 2020-03-12 08:36:31 -07:00
Connor Peet c3a5ad4f73 fixup! pr comments 2020-03-10 11:21:40 -07:00
Connor Peet b737cc0861 debug: show errros from scopes request 2020-03-10 08:41:32 -07:00
isidor 0b3510db7d views: aria header label compute from title
fixes #91602
2020-03-09 11:43:01 +01:00
Joao Moreno a1f61fd0fe welcome views: telemetry events for buttons 2020-02-21 16:38:42 +01:00
isidor c379e3226e debug: remove BaseDebugViewPane 2020-02-14 11:31:35 +01:00
SteVen Batten 5def21f51c update css for debug viewlet 2020-02-13 09:03:17 -08:00
SteVen Batten c58e437830 remove unnecessary listeners for built-in views 2020-02-13 08:15:49 -08:00
isidor 4b0c906e68 fixes #90177 2020-02-12 16:18:02 +01:00
SteVen Batten 47813a3e40 run and debug views can move
refs #90468
2020-02-11 09:15:36 -08:00
Joao Moreno 9aa9ea752b Merge branch 'master' into joao/empty-views 2020-02-11 12:49:45 +01:00
Matt Bierner ee430f9d2a Adding casts for creation of generic workbench trees with strict function types
For #81574

Based on https://stackoverflow.com/questions/59384319/typescript-get-typeof-generic-constructor
2020-02-10 15:28:12 -08:00
Joao Moreno d4c1acf6cc add opener and theme services to ViewPane 2020-02-10 16:06:59 +01:00
Joao Moreno dc464e62bf Merge branch 'master' into joao/empty-views 2020-02-10 11:34:32 +01:00
SteVen Batten 481923c44e migrate search to use new setting (#89190)
* migrate search to use new setting

* rename

* add getViewLocation api to vds for search

* remove unreferenced location option
2020-01-24 08:23:34 -08:00
Joao Moreno 7c30a1b05e wip: empty view content 2020-01-23 20:10:29 +01:00
Johannes Rieken 1665beab9e move TitleMenus from customView to ViewPane, also fixes #88557 2020-01-14 16:28:42 +01:00
SteVen Batten cabcace4b5 Viewlet Refactor (#85566)
* wip 2

* use viewlet stubs

* fix layering issue

* fix saveState and contextmenus

* move context menu logic into panecomposite

* revert tasks.json

* tasks again

* add showHeaderInTitleWhenSingleView values

* patch tests

* some cleanup

* more cleanup

* start view

* merging conflicts

* fix title and dnd

* adding missing api surface to pane composite

* additional merge resolution
2019-12-09 15:30:46 -08:00
isidor 08b0a9bc59 Persisted data breakpoints are not registered when starting a new debug session
fixes #83743
2019-12-06 10:40:48 +01:00
SteVen Batten 8eaf2a3742 rename splitview panels to panes (#85166)
* rename splitview panels to panes

* rename files

* customViewPane
2019-11-20 10:59:22 -08:00
isidor 8eaf977b90 List, Tree: Make sure sub-pixel antialiasing works across all lists and trees
#84715
2019-11-18 15:31:54 +01:00
Matt Bierner 7d0267f49e Make createInstance stricter (#83472)
Part of #81574

Makes the `createInstance` function signature more strict. Previously it inferred the argument types based on the actual argument values passed to `createInstance`. Instead, we now infer them from the constructor signature itself
2019-10-28 14:30:54 -07:00
Miguel Solorio 8e12d4ded3 Adopt icon font in debug viewlet 2019-10-24 15:18:34 -07:00
isidor ed193fcb42 debug: more async await 2019-10-15 12:10:44 +02:00
Matt Bierner 4a79a0ba40 Fixing a few more strict init errors in panelViewlet
#78168Ï
2019-10-07 16:41:39 -07:00
isidor accd8597f0 debug: dispose context menu actions on hide. Also some breakpoint polish 2019-09-19 11:15:04 +02:00
Matt Bierner 7a00ddf9f8 Format files for 3.6
Fixes #80118
2019-09-02 21:29:05 -06:00
Joao Moreno 53c4fa6e84 fix formatting 2019-08-30 18:14:40 +02:00
Joao Moreno defb2320c1 fixes #80097 2019-08-30 17:36:48 +02:00
isidor b05051e549 fixes #79884 2019-08-28 15:08:22 +02:00
Matt Bierner f2334a79d3 Format file 2019-08-16 11:39:49 -07:00
isidor a7cc79a554 debug: introduce data breakpoints 2019-08-16 17:16:46 +02:00
isidor 31cd6aea84 strictPropertyInitialization
#78168
2019-08-06 10:50:29 +02:00
Sandeep Somavarapu 2063f65485 Fix #76881 2019-07-29 10:52:45 +05:30
Joao Moreno 105f843840 💄 remove unnecessary list/tree casts 2019-07-23 18:04:56 +02:00
SteVen Batten 305d5be119 implement browser clipboard service (#75293)
* implement browser clipboard service

* actually register the clipboard service

* update all refs to newly async funcs

* addressing comments

* small fixes

* all asyncs as a result of readText

* fix unit test

* cleanup for writeText refs

* cleanup and reduce diff noise

* qfix

* address feedback
2019-07-11 09:49:28 +02:00
Haneef Mohammed 8fb951328d Revert "Dummy change in comment to restart checks"
This reverts commit 9f86032f91.
2019-07-03 14:34:42 -07:00
Haneef Mohammed 9f86032f91 Dummy change in comment to restart checks 2019-07-03 10:39:28 -07:00
Haneef Mohammed 7ca5158461 simplify check before saving state. 2019-07-03 09:47:03 -07:00
Haneef Mohammed 48764becf2 Alternate implementation for lost tree state using getViewState() 2019-07-02 08:57:31 -07:00
Haneef Mohammed d7c8e71538 Don't lose state of tree when going from a stopped->running->stopped state. 2019-07-01 13:04:22 -07:00
isidor d6b3a85bd8 fixes #75359 2019-06-18 13:01:49 +02:00
Matt Bierner 3132d26813 Have Panel extend Disposable
The panel currently exposes a `disposables` protected member. In order to catch possible leaks of disposables, we should extend `Disposable` instead
2019-06-05 15:42:25 -07:00