Commit Graph
1319 Commits
Author SHA1 Message Date
Matt BiernerandGitHub 3e7637064d Use more generic button title for jsconfig create/open (#167482)
For #166808
2022-11-29 00:39:56 +00:00
Matt BiernerandGitHub 838b48504c Pick up TS 4.9 final (#166509) 2022-11-16 14:16:36 -08:00
Matt BiernerandGitHub 5452c6af10 Eagerly delete diagnostic on quick fix (#166417)
Fixes #166415
2022-11-16 07:43:28 +01:00
Matt BiernerandGitHub 7d6c575031 Check cancellation token earlier and avoid capturing resolve (#166416) 2022-11-15 16:33:01 -08:00
Matt BiernerandGitHub 44441de137 Adopt prefer-readonly in JS/TS extension (#165089) 2022-11-14 20:12:10 -08:00
Logan RamosandGitHub bf1697d98c Consume proposed telemetry API (#165862)
* Consume proposed telemetry API

* Update webpack
2022-11-08 21:58:28 -05:00
Matt BiernerandGitHub 5d04c3b06c Don't assume file paths in tsconfigs (#165779)
Fixes #160979
2022-11-07 20:24:31 -08:00
Matt BiernerandGitHub 3c874be287 Fix UI string (#165554) 2022-11-04 14:04:58 -07:00
Matt BiernerandGitHub 0bd1531e00 Adopt l10n for ts extension (#165450)
For #164438

Also refines the eslint rule from #165448
2022-11-04 09:50:18 +01:00
Matt BiernerandGitHub 8ad43669a9 Prompt users to test with extensions disabled (#165203) 2022-11-01 16:38:45 -07:00
Matt BiernerandGitHub 33378c2ec0 Fix organize imports (#164035)
Fixes #163994

This fixes the organize imports command (it was using the wrong id) and also cleans up the implementation
2022-10-19 09:27:41 -07:00
Andrew BranchandGitHub 1fb956d2f5 [typescript-language-features] Add removeUnusedImports command (#161654)
* Add `removeUnusedImports` command

* Continue to send `skipDestructiveCodeActions` for older TS versions

* Expose Sort Imports and Remove Unused Imports commands

* Update localization keys

* Update for 4.9 protocol

* Proto must be type only import?
2022-10-18 09:00:16 -07:00
Matt BiernerandGitHub 186d3415a3 Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Jake BaileyandGitHub 65a9097aa2 Remove forgoten reference to typescript/lib/protocol (#163585) 2022-10-13 13:15:13 -07:00
Jake BaileyandGitHub 07b87405e7 Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Suven-pandGitHub 22ff985c19 Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Matt BiernerandGitHub 3ee9749b35 Remove extra enums (#162686)
`showMessage` returns the selected item, so we don't need to create an enum here and can instead used the returned items directly
2022-10-04 10:46:53 -07:00
Daniel RosenwasserandGitHub da506e9b8d Tag existing events with experimentation info in typescript-language-features (#161463)
* Associate experiment info with existing telemetry.

* Move the ExperimentTelemetryReporter to its own file.

* Roughly copied the 'getPackageInfo' function from other extensions.

* Addressed code review feedback.
2022-09-23 15:18:57 -07:00
Daniel RosenwasserandGitHub 5cde74b767 Fix accidental case fallthroughs in experimentation services. (#161339) 2022-09-20 12:00:32 -07:00
Johannes RiekenandGitHub 77309b33d4 add WorkspaceEditMetadata and use it for applyEdit, (#160996)
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
2022-09-16 09:44:19 +02:00
Matt BiernerandGitHub 3c37a5a8d7 Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Daniel RosenwasserandGitHub 9dfd49db63 Ensure ExperimentationService gets disposed. (#161004) 2022-09-15 11:06:53 -07:00
Benjamin PaseroandGitHub cfc0119755 Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
2022-09-15 08:26:22 +02:00
0cbcb1b1ab JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
00902daee1 Instantiate ExperimentationService in typescript-language-features. (#160877)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:34:04 -07:00
Matt BiernerandGitHub 1d500fb4de Add CodeActionKind.RefactorMove (#160730)
Fixes #160728
2022-09-12 15:14:06 -07:00
Matt BiernerandGitHub c4722f1bb2 Write markdown link setting change to correct scope (#159816)
Fixes #159084

Also fixes the same issue for JS/TS
2022-09-02 13:38:41 +10:00
Matt BiernerandGitHub c9a97b5581 Pick up TS 4.8 final (#159238)
Fixes #157527
2022-08-26 01:30:07 +02:00
Matt BiernerandGitHub 129f5bc976 Use own calls to localize (#158372)
Fixes #156684
2022-08-17 10:27:29 -04:00
Matt BiernerandGitHub 0c78644c6e Use tabs to figure out when to report JS/TS diagnostics (#157117)
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
2022-08-04 10:46:56 -07:00
Matt BiernerandGitHub f0434c0960 Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Matt BiernerandGitHub 97c8a97261 Include globally enabled TS Server plugins when reporting issues (#156510)
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
2022-08-01 10:44:46 -07:00
Matt BiernerandGitHub 4eef7a94e1 Tell users about enabled TS plugins on crash (#156514)
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
2022-08-01 10:44:33 -07:00
Matt BiernerandGitHub 06f8d52e37 Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Matt BiernerandGitHub 00bb9bdefc Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
ryuurockandGitHub 42e79ca270 Update typescriptServiceClient.ts, fix naming errors (#155946)
Update typescriptServiceClient.ts

fix naming errors
2022-07-22 17:46:48 +00:00
Andrew BranchandGitHub 1d16e313d6 [typescript-language-features] Add setting for autoImportFileExcludePatterns (#153160)
* Add setting for autoImportFileExcludePatterns

* Add TS 4.8 to message
2022-06-28 16:43:24 -07:00
c16036705e Initial contents for experimentation in typescript-language-features. (#153358)
Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
2022-06-27 12:53:24 -07:00
Matt BiernerandGitHub 9051021473 Clarify label on source action (#153356)
Clairify label on source action

For https://github.com/microsoft/vscode-eslint/issues/1428
2022-06-27 19:01:41 +00:00
Matt BiernerandGitHub 8559324b09 Use more optional chaining in TS extension (#152271)
Use optional chaining in TS extension

Also removes `prefer-const` since this is now enabled globally
2022-06-16 05:33:58 +02:00
Matt BiernerandGitHub a289e64e09 Switch to finalized TS protocol types (#152259) 2022-06-15 15:37:21 -07:00
Matt BiernerandGitHub 8fb977f2c1 Make jsx: react the default for implicit js/ts projects (#152256)
Make jsx: react the default

Fixes #152150

This fixes imports of `react` getting removed with TS 4.7 in implicit projects
2022-06-15 21:41:52 +00:00
Andrew BranchandGitHub 5a32c3ff17 [typescript-language-features] Pass through all typescript.unstable.* settings (#151472)
Pass through all `typescript.unstable.*` settings
2022-06-08 11:53:06 -07:00
Matt BiernerandGitHub 6428d0fc7d Support TS's includeInlayVariableTypeHintsWhenTypeMatchesName setting (#150489)
From https://github.com/microsoft/TypeScript/pull/48529

Let users control is variable type inlay hints are suppresed if the variable name matches the type name, such as:

```ts
const range = new Range();
```
2022-05-26 16:00:04 -07:00
Logan RamosandGitHub 3a8b1fe03e More telemetry comments (#150303)
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
2022-05-24 16:00:55 -07:00
Matt BiernerandGitHub 6bd7605ae1 Enable strictNullChecks for implicit projects (#149844)
Mistakenly enabled checkJS instead of strictNullChecks
2022-05-18 10:47:37 -07:00
Matt BiernerandGitHub 101f6fb31d Enable enabling js/ts.implicitProjectConfig.checkJs by default (#149660)
Fixes #149659
2022-05-16 11:52:27 -07:00
Matt BiernerandGitHub 4923404e98 Don't include leading @ in JS/TS completion word range (#149400)
Fixes #149385
2022-05-12 15:22:18 -07:00
Matt BiernerandGitHub 3ba66bf24f Use explicit empty authority for JS/TS resources (#149125)
Fixes #149123

10c8c1c2cc made sure we sync over the authority of in-memory resources over to TS Server. However if a resource does not have an authority, this resulted in a url with `scheme//path` instead of `scheme/authority/path`

TS would then normalize the uri to `scheme/path`, resulting in us considering this a new resource

This fix adds an explicit empty authority that we use in this case instead
2022-05-09 15:52:52 -07:00
Matt BiernerandGitHub 10c8c1c2cc Include authority in TS in-memory scheme (#148940)
For #146853

Make sure we include the uri authority when serializing and then restoring the file paths we send to TSServer (similarly to how we already handle the uri scheme)
2022-05-06 11:48:53 -07:00