Commit Graph

88 Commits

Author SHA1 Message Date
Johannes Rieken 99e3914c7e move statusbar from /common/ to /browser/ 2021-08-20 10:59:00 +02:00
Benjamin Pasero 159479eb5a Allow to show status bar entries with an id and name (fix #74972) 2021-05-19 14:03:37 +02:00
Benjamin Pasero 5f697ad80d hot exit - turn progress on shutdown to a modal dialog (#122774) 2021-05-05 10:36:06 +02:00
Matt Bierner 731402dce2 async override -> override async 2021-04-21 13:40:44 -07:00
Matt Bierner e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Benjamin Pasero 5e3df4ce30 debt - onDispose => onWillDispose 2021-03-29 08:21:09 +02:00
isidor 97b2514ca7 include source.id for progress notifications 2021-03-23 17:06:53 +01:00
Benjamin Pasero 8d7ad831e5 Improve window.withProgress in status bar to use a static spin icon (fix #108657) 2020-10-19 08:07:52 +02:00
ChaseKnowlden e8760a5d6c Fix capitalization of GitHub org 2020-09-17 11:43:03 +02:00
Benjamin Pasero 3fb8967173 fix some TS 4.1 errors (#106358) 2020-09-10 08:49:08 +02:00
SteVen Batten 1b4935d35c fixes #104184 2020-08-06 10:08:43 -07:00
Benjamin Pasero 492b96a860 es6 - adopt more Array/String#includes over indexOf 2020-07-15 07:41:11 +02:00
Matt Bierner cadabab73f Mark _serviceBrand properties using declare (#99312)
_serviceBrand is only used for typing and should not result in emit

Also adds readonly
2020-06-05 11:04:15 -07:00
Sandeep Somavarapu 6df1443900 add view name in progress indicator api 2020-05-05 10:44:23 +02:00
Benjamin Pasero 2971e3a4e8 progress - preserve 150ms default delay for window progress (#95615) 2020-04-27 14:49:16 +02:00
Sandeep Somavarapu 921b9a92a1 Fix #95372 2020-04-24 15:04:14 +02:00
SteVen Batten ccffe89697 move view container registry api into view descriptor service 2020-04-22 13:04:16 -07:00
isidor b7a9bfa7f9 add ariaLabel to IStatusbarEntry
fixes #94677
2020-04-10 17:31:57 +02:00
Benjamin Pasero 3764d68e3b fix #93029 2020-04-06 14:38:45 +02:00
Benjamin Pasero daa4a618bb progress - turn window progress into silent notification progress (#93363) 2020-03-25 10:26:44 +01:00
isidor 73044c5e8c progress: show silent notifications in status bar 2020-03-18 18:42:54 +01:00
isidor 354657c351 progress service: support silent progress 2020-03-18 18:05:27 +01:00
Eric Amodio 44da9e136e Removes getInstantiated* methods 2020-03-10 15:52:48 -04:00
Eric Amodio 101beaae6a Removes code duplication
Consolidates ViewProgressIndicator into CompositeProgressIndicator
2020-03-10 15:52:48 -04:00
Eric Amodio 690007dfc4 Closes #92135 - Adds view-level progress indicator 2020-03-10 15:52:48 -04:00
Benjamin Pasero e44c50ba93 progress - reuse status entry if it exists 2020-03-02 09:49:06 +01:00
Benjamin Pasero a949694b25 debt - reduce usage of explicit any 2020-02-28 11:33:55 +01:00
Benjamin Pasero f9b3974299 notifications - handle markdown links in status bar 2020-02-27 13:13:33 +01:00
Benjamin Pasero 2f8ddbe3c2 notifications - revised progress indication for hidden notifications (fix #91469) 2020-02-27 13:01:13 +01:00
Benjamin Pasero 7cfbe2e6af Notification: X button shows up if progress is collapsed (fix #91414) 2020-02-26 07:52:49 +01:00
Benjamin Pasero e683dce828 progress - remove fallback to statusbar for now when notification closed 2020-02-19 17:40:54 +01:00
Benjamin Pasero 61d7743219 notifications - show progress in status bar when notification is closed (part of #90274) 2020-02-17 11:29:40 +01:00
Johannes Rieken 1f618a27aa add IProgressNotificationOptions#delay, #87449 2020-01-09 12:53:48 +01:00
Benjamin Pasero aa7721f438 debt - avoid Promise.reject() in async functions 2019-10-28 11:17:53 +01:00
Benjamin Pasero 935b0f1c0d debt - optional chaining 2019-10-21 15:44:21 +02:00
Alex Ross df10b76026 Add command to window progress (#82365)
and add command to task building progress

Fixes #81636
2019-10-18 15:52:55 +02:00
Benjamin Pasero 79722879ba debt - less null in workbench 2019-10-08 09:53:53 +02:00
Benjamin Pasero 64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00
Rob Lourens 928bafcb49 Fix microsoft/vscode-remote-release#1353 2019-09-12 14:26:43 -07:00
Johannes Rieken dedf0de944 change type of _serviceBrand from any to undefined, #79918 2019-08-30 15:40:46 +02:00
SteVen Batten 845202c59e allow select/copy on dialogs
fixes #71407
2019-08-26 11:52:26 -07:00
SteVen Batten 263312b6dd add reconnect now button 2019-08-22 17:07:13 -07:00
Benjamin Pasero 9e68f21d4d debt - a bit of strictPropertyInitialization (#78168) 2019-08-05 20:10:58 +02:00
Benjamin Pasero 0b4d2dcd52 debt - reduce scope of local progress service 2019-06-28 16:52:05 +02:00
Benjamin Pasero 9b8401da2d fix #74290 2019-06-17 15:06:47 +02:00
Benjamin Pasero 553e8d60ef progress - allow to report total/worked in viewlets/panels 2019-06-17 13:04:31 +02:00
Benjamin Pasero 17f7970145 fix #74815 2019-06-17 10:50:46 +02:00
Matt Bierner 65f4b4a159 Use MutableDisposable in a few more places 2019-06-11 10:20:31 -07:00
Matt Bierner 9f6de388ea Use ReadonlyArray for a few more lists of IActions
Also changes processService to not modify its input actions, which seems like unexpected behavior
2019-06-07 10:26:00 -07:00
Matt Bierner e78f05a7dc Use ReadonlyArrays for IActions used in notifications
These arrays of actions should not be modified by the caller. Mark them as readonly to prevent this. This also let me eliminate a number of not null supressions that had been introduced during the strict null migration

One small code change was required in `showError`. However I believe this was actually a bug since modifying the input array was likely not what would be expected (in practice, we usually just passed in array literals so I don't think we hit this one)
2019-06-07 10:26:00 -07:00