Commit Graph

227 Commits

Author SHA1 Message Date
Johannes Rieken
d00e5cb041 debt - replace CompletionItem#overwriteBefore/After with CompletionItem#range 2018-10-02 15:31:47 +02:00
Johannes Rieken
3f12ef35a8 debt - modes.ISuggestSupport becomes modes.CompletionItemProvider 2018-10-02 15:31:47 +02:00
Johannes Rieken
81b995a25d debt - less TPromise usage 2018-10-01 14:01:17 +02:00
Johannes Rieken
f79b59416b debt - SuggestionType -> SuggestionKind 2018-09-24 15:58:05 +02:00
Johannes Rieken
01e438743c debt - remove SnippetType 2018-09-17 12:57:34 +02:00
Alex Dima
f9d8addc07 Merge remote-tracking branch 'origin/master' into pr/limerickgds/51557 2018-09-11 15:30:40 +02:00
Johannes Rieken
01f615e016 better error handling when calling prep-rename, #58394 2018-09-11 11:39:21 +02:00
Matt Bierner
d33b1c3063 Initial work on signature help context (#58135)
* Initial work on signature help context

Fixes #54972

Adds `SignatureHelpContext`. This tells providers why signature help was requested

TODO:

- [ ] Better understand semantics of retrigger. Should `retrigger` be an flag instead of a `triggerReason`?
- [ ]  Fix skipped test
- [ ] Add more tests for trigger reasons / trigger characters

* Fix unit test

* Make sure we retrigger sig help if it is already showing

* Add test for dismiss and re-invoke

* Extract some constants

* Extract createMockEditor
2018-09-10 17:44:21 -07:00
Alex Dima
efd8f4a4b2 Adopt CancellationToken in ExtHostLanguageFeaturesShape 2018-09-04 15:33:40 +02:00
Alex Dima
a5ff3ce6c4 Add support for CancellationToken as last argument in RPC communication 2018-09-04 14:54:20 +02:00
Johannes Rieken
3c727a6d01 uri - replace usages of default export with named export (part 2) 2018-09-03 11:04:26 +02:00
Matt Bierner
bd1e8d40fd Fix unit test 2018-07-26 15:42:24 -07:00
Matt Bierner
341013c0ef Log warning when returned code action will be dropped (#55090)
* Add extension logging when returned code action will be dropped

Fixes #54803

Adds a loggin warning when a code action provider returns code actions that will be dropped. Warn in the the following cases:

- A provider returns code actions (not commands)
- And a specific code action type is requested.
- And the returned code actions either don't set kind or are of the wrong kind

* Use log service

* Include extension id in warning
2018-07-26 15:14:16 -07:00
Matt Bierner
44cd521ced Finalize definition link (#54424)
Finalize the definition link api

- Gives fields more explicit names (target and origin)
- Moves api to vscode.d.ts
- Makes other definition providers (such as type definition provider and implementation provider) also return definition links

Fixes #54101
2018-07-18 16:32:27 -07:00
Matt Bierner
0532c31e4c Definition link API (#52230)
* Definition link

Add a new `DefinitionLink` type. This type allows definition providers to return additional metadata about a definition, such as the defining span.

Hook up this new provider for typescript

This PR replaces #48001

* Correctly mark field optional

* Small code fixes

- Use lift
- Remove unused param

* Adding documentation
2018-06-20 11:52:47 -07:00
Johannes Rieken
97f48d7bba rename/create should be able to define override behaviour #10659 2018-06-20 12:46:57 +02:00
Johannes Rieken
8be8f65468 fix compile error 2018-06-18 17:53:25 +02:00
Johannes Rieken
62e0f34a35 add CompletionItem#preselect, #35551 2018-06-18 16:15:56 +02:00
Johannes Rieken
7753381eb6 renames: range/selectionRange #34968 2018-06-18 15:46:04 +02:00
Matt Bierner
d3a54049da remove reference to triggerKind 2018-06-15 11:23:57 -07:00
Johannes Rieken
ec60aab39f outline - use Provider#displayName instead of extension id 2018-06-15 15:14:04 +02:00
Johannes Rieken
cecfdcde22 update proposed API to DocumentSymbol-type, #34968 2018-06-12 12:47:27 +02:00
Johannes Rieken
7fa40d8a12 internally talk about DocumentSymbols and WorkspaceSymbols. #34968 2018-06-12 12:47:26 +02:00
习古
81f58337a9 fixed:generator method of class autocomplete causes star(*) to be added to next line 2018-06-11 01:26:47 +08:00
Johannes Rieken
e3a2077949 fill in document uri when document symbol location lacks uri, #51297 2018-06-07 11:03:08 +02:00
Johannes Rieken
9a86a83b50 back to more conventinal api proposal, #34968 2018-06-05 17:05:23 +02:00
Johannes Rieken
c562bd257d fix #50207 2018-05-30 14:48:33 +02:00
Johannes Rieken
f5300ced7f fix #50321 2018-05-29 16:06:08 +02:00
Matt Bierner
0a0d3d5e45 Add code action trigger to proposed API
#50248
2018-05-21 16:19:10 -07:00
Matt Bierner
2cfe96f451 Use member shorthand for more adapters 2018-05-21 11:54:30 -07:00
Johannes Rieken
49323b3798 explore Hierarchy<T> idea, #34968 2018-05-17 10:40:08 +02:00
Johannes Rieken
e538ec0945 synthesize a hierarchy based on range containment 2018-05-15 18:12:00 +02:00
Johannes Rieken
2a270de217 add extensionId to DocumentSymbolProvider interface 2018-05-14 14:27:26 +02:00
Matt Bierner
49170e54b1 API allowing CodeActionProviders to reliably get the current editor selection (#49081)
Fixes #49024
Fixes #49060

See #49024 for details on the problem. Makes code action providers take a range | selection. Always pass the selection if one is available.
2018-05-10 15:09:26 -07:00
Johannes Rieken
681a9e0d54 more tweaks #34968 2018-05-07 10:03:31 +02:00
Johannes Rieken
4e46d2a1bb type converters, use namespace for DocumentHighlight 2018-05-04 18:49:40 +02:00
Johannes Rieken
781520cbe1 type converters, use namespace for Hover 2018-05-04 18:49:40 +02:00
Johannes Rieken
d52bf577dc type converters, use namespace for Diagnostics 2018-05-04 18:49:40 +02:00
Johannes Rieken
9f6053242f type converters, use namespace for Position 2018-05-04 18:49:39 +02:00
Johannes Rieken
dfb070c277 type converter, use namespace for Range 2018-05-04 18:49:39 +02:00
Johannes Rieken
6b4f88991b experiment with internal hierarchical model, #34968 2018-05-04 18:49:39 +02:00
Johannes Rieken
fa0a49bbf2 add exclusivness to document filter 2018-05-03 11:38:15 +02:00
Matt Bierner
83d4bb6b53 Use property shorthand for CodeActionAdapter 2018-05-02 14:06:45 -07:00
Johannes Rieken
6f4d130ae5 rename it to prepareRename, #48700 2018-04-26 18:04:10 +02:00
Matt Bierner
1e7095ee31 Make sure we rehydrate uri in resolve rename location
Fixes #48592
2018-04-24 17:10:45 -07:00
Johannes Rieken
e56acedabe allow resolve for all, not just for proposed-api-users, #7340 2018-04-24 08:55:44 +02:00
Johannes Rieken
73f64b9312 first cut of _proposed_ api for hierarchy of document symbols, #34968 2018-04-23 12:59:40 +02:00
Martin Aeschlimann
45e859bfdc monaco folding api (for #47808) 2018-04-18 17:48:26 +02:00
Martin Aeschlimann
a1bb202eb6 incorperate folding api feedback 2018-04-18 15:26:43 +02:00
Alex Dima
101c8ed9e3 Add scheme transformer 2018-04-18 12:13:27 +02:00