Commit Graph

55 Commits

Author SHA1 Message Date
Matt Bierner
f9687fc5ec Strict null work on extHostLanguageFeatures 2019-02-11 09:31:13 -08:00
Johannes Rieken
0693cb7afc debt - don't track recursive but explict, #67694 2019-02-07 13:56:26 +01:00
Johannes Rieken
d0ba2734fa make sure to invoke command with correct argument types, #64376 2019-01-28 12:06:13 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Matt Bierner
30b2a5fd94 Replace !isFalsyOrEmpty with isNonEmptyArray
This new call works as a type guard and can help avoid writing double negations

Avoid either call in cases where we were iterating over the possibly undefined value. Use `|| []` for these
2018-11-14 16:06:13 -08:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
Joao Moreno
c46caf0ac4 smoketest: more tracing information 2018-06-08 17:53:53 +02:00
Johannes Rieken
9f6053242f type converters, use namespace for Position 2018-05-04 18:49:39 +02:00
Johannes Rieken
dfb070c277 type converter, use namespace for Range 2018-05-04 18:49:39 +02:00
Alex Dima
99b5cb6c9c Avoid registering api commands on the renderer 2018-03-21 12:26:00 +01:00
Johannes Rieken
3bac9bd027 fix #40307 2017-12-15 17:11:07 +01:00
Johannes Rieken
f1f2c19669 fix exthost commands issue 2017-12-14 16:03:16 +01:00
Johannes Rieken
8f18e87477 ExtHostCommands, MainThreadCommands, #40169 2017-12-14 15:46:03 +01:00
Alex Dima
367dd10413 Rename RPCProtocol.get to RPCProtocol.getProxy (#36972) 2017-12-13 16:04:14 +01:00
Johannes Rieken
9faf001bad eng - less TPromise in extHostCommands 2017-12-11 14:09:19 +01:00
Joao Moreno
4ecad4714f fixes #39806 2017-12-06 17:34:11 +01:00
Joao Moreno
15f9079a22 cleanup main log service 2017-12-04 12:59:00 +01:00
Joao Moreno
857ab9d59d use global log service 2017-12-04 12:08:04 +01:00
Joao Moreno
4e78a42abf log ext host commands, ext hsot scm 2017-11-29 15:38:01 +01:00
Johannes Rieken
47bd8ae1ca Revert "fix #37484"
This reverts commit c8a8fc7ddd.
2017-11-02 11:50:53 +01:00
Johannes Rieken
c8a8fc7ddd fix #37484 2017-11-02 11:05:03 +01:00
Simon Friis Vindum
e70616c810 Include command id in error message 2017-08-24 10:42:12 +02:00
Alex Dima
2b3298af79 Use native proxies for renderer <-> ext host RPC communication 2017-08-16 10:26:25 +02:00
Alex Dima
20a45eef3a Add a mechanism to be a customer of the extension host (share lifecycle) and begin reducing usage of IThreadService 2017-08-15 18:26:51 +02:00
Felix Becker
dbe0f89264 Always reject Promises with Error instances 2017-06-26 15:24:41 +02:00
Johannes Rieken
6fdfe2f055 fix ts 2.4.1 compile errors in workbench/api 2017-06-15 11:59:41 +02:00
Matt Bierner
6147b54439 Fix TS 2.3.1 Compiler Errors in VSCode src/workbench (#25249)
TS 2.3.1 introduced a breaking change by [switching to covariant types for callbacks](https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#covariance-in-callback-parameters). This change tries to fix these compiler errors in the workbench codebase
2017-04-25 08:20:25 -07:00
Matt Bierner
a0cb432471 Allow Code Lenses to Provide only a Title
Fixes #24209

**Bug**
Currently, for the js/ts references code lens, even if there are zero references you can click on the lens. This display an empty peek view

**Fix**
Allow code lenses to only register a title for the lens with no actual backing command
2017-04-12 15:47:20 -07:00
Joao Moreno
a8b2945855 🐛 remove the notion of active scm provider
introduces more changes to the SCM api

fixes #23623
fixes #23676
2017-03-30 21:10:44 +02:00
Joao Moreno
ae46d50241 🎨 unhook scm from marshalling 2017-03-30 10:27:14 +02:00
Johannes Rieken
7eeb5a6e48 💄 remove unused property 2017-03-07 09:38:18 +01:00
Johannes Rieken
1239cebb70 Merge branch 'joh/editors' 2017-03-06 12:40:47 +01:00
Matt Bierner
406014ae97 Adding explicit returns 2017-02-01 17:06:13 -08:00
Johannes Rieken
118b3e0d5a debt - use Map instead of object 2016-12-30 15:37:12 +01:00
Johannes Rieken
012622ead3 fix #14223 2016-10-24 10:45:15 +02:00
Johannes Rieken
fbacd65e2a debt - no guessing-caching, better use of gc-signals, command converter using gc-signals, main side heap service 2016-10-21 18:54:48 +02:00
Johannes Rieken
dc7402b978 make vscode.d.ts use a declare module, #13990
* a declared module allows to have a sibling module containing experimental API
* this change also cleans up some bogous type pollution that happened because vscode used to be both, a declare module and a global namespace
2016-10-19 11:43:56 +02:00
Johannes Rieken
6681a2a7d6 tsfmt - src 2016-10-08 09:53:13 +02:00
Johannes Rieken
a27782ed13 wire-up dispose calls, #9384 2016-08-29 18:10:05 +02:00
Alex Dima
bdaa72b842 ext host - extend *Shape classes 2016-07-12 21:10:54 +03:00
Alex Dima
581c260f9a Rename extHostProtocol to extHost.protocol 2016-07-12 19:33:55 +03:00
Johannes Rieken
bd4e85d8a3 move CommandRegistry out of KeybindingsRegistry 2016-07-07 10:39:30 +02:00
Johannes Rieken
1920059e45 rename index file 'keybindingService' to 'keybinding' such that it is aligned with the rest 2016-07-06 16:43:01 +02:00
Alex Dima
5d218261e8 Fixes #8379: validate column argument of vscode.previewHtml 2016-06-28 16:21:30 +02:00
Alex Dima
9f1e006be5 Do not use native Proxy as it breaks debugging vscode 2016-06-27 17:54:56 +02:00
Alex Dima
d285fe05e1 Split up ext host <-> main thread communication to separate files 2016-06-27 14:59:54 +02:00
Alex Dima
f00bbb18d9 Move IThreadService up to /workbench/ 2016-06-26 15:50:37 +02:00
Alex Dima
10cae007cd Use native JS Proxy for main <-> ext host proxies 2016-06-26 15:10:04 +02:00
Alex Dima
e05566c980 Command handlers are invoked with var-args 2016-05-02 19:00:33 +02:00
Alex Dima
487e7dd1a0 Do not patch in "context" when invoking command through keybinding service 2016-05-02 17:55:51 +02:00