Split darwinBundleDocumentType into two separate functions. The first function is unchanged.
The second function allows you to specify specific names for different groups of extensions while all sharing the same icon. For example, this would allow you to differentiate between a C header and a C source file while using the same icon for both.
Inherently, the second function will generate multiple file type declarations, so it returns an array instead of a single object. As a result we must use the splat operator on it when passing the result to an array literal.
Allow the caller to provide a specific file type description.
The new function will not require source changes to existing calls, but will change how the file type description is generated. An unmodified call to darwinBundleDocumentType will use the given icon name as the file type description. All extensions passed to this function continue to use the same icon as before, and all extensions will have the same file type description as before.
With this change, to define a document type, you need only pass the name (or relative path) of the darwin icon.
So instead of passing 'resources/darwin/css.icns' you would just pass 'css'
* draft trusted workspace service / model
* renaming
* add request model and action
* err fix
* add request handlers with mock actions
* some quick fixes
* adding badge icon to activity bar gear
* Add Statusbar item to indicate trust
* Cleanup code
* Add background color
* Use theme color for the status background color
* adding basic editing experience
* observe trust with startup tasks
* Extension enablement
* Add capability to provide a custom message
* Remove old actions
* explorer: if you can not undo, pass undo to editor
fixes#111630
* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689
* Fixed compilation error
* Handle extension uninstall
* Handle extension install
* Ability to prompt when state is untrusted
* Do not change state is the modal dialog is dismissed or the Cancel button is pressed
* Refactored enablement code
* Prompt when installing from VSIX
* Prompt when installing from the Gallery
* Move file into the browser folder
* fixes and polish
* restructure workspace contributions
* restructure actions and use confirmations
* Initial draft of the proposed APIs
* Added stubs for the proposed api
* Trusted Workspace proposed API
* Fix a regression introduced by merge
* status bar indicator improvements
* remove helper command as we now have hooks
* verbose messaging for the immediate request
* add indication to global activity icon of pending request
* try personal title
* Add configuration setting
* Add additional extension actions
* Fix contributions
* Removed context key that is not needed
* Fixed issue with the dialog
* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016
* Fixes#115221: update emoji tests
* Give a higher priority to language configuration set via API call (#114684)
* debug console menu action polish
* Avoid the CSS general sibling combinator ~ for perf reasons
* more notebook todos
* Use label as tooltip fallback properly
Part of #115337
* Fixesmicrosoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`
* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364
* simplify map creation, fyi @bpasero
* Fix#114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)
* fix multiple save dialogs appearing on Windows when spamming Ctrl+S
* remove old fix and instead keep track of windows with open dialogs in the dialogMainService
* keep initialisation of activeWindowDialogs in constructor
* remove unused variable
* some changes
* queue dialogs based on hash of options
* simplify structure, fix comment typo
* Apply suggestions from code review
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* remove unnecessary async/await for aquireFileDialogLock method
* don't acquire file dialog lock for message boxes
* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue
* Apply suggestions from code review
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* 💄 dialog main service locks
* debt - adopt some ? operator
* Better hiding of custom hover in icon label
* Limit to 8ms (120fps)
* more API todos for notebooks
* 💄
* Update grammars
* chore - group notebook specific api proposals together
* added unreleased fixes to endgame notebook
* Add changes back to the modal dialog
* Add back the workspace trust proposed APIs
* Adjust dialog buttons
* Standardize on WorkspaceTrust name across interfaces, classes, variables
* Renamed some of the missing keys
* Add TestWorkspaceTrust stub and fix failing tests
* Add requiresWorkspaceTrust property to fix test failure
* remove notebook change
Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
This workbench service handles opening external uris. Unlike the core OpenerService, it also has logic for configuring a default opener and prompting if multiple openers are availble for a given uri
