Commit Graph

13755 Commits

Author SHA1 Message Date
Bhavya U
b0cf9f8e24 Remove temp walkthroughs (#182996) 2023-05-19 15:28:27 -07:00
David Dossett
a4037a72ef Use default theme focus border color in Dark Modern theme (#182997)
Use regular focus border color in Dark Modern theme
2023-05-20 00:06:28 +02:00
Matt Bierner
2d416df5f0 Pick up TS 5.1-rc (#182932)
For #182931
2023-05-19 03:46:49 +02:00
Rob Lourens
047b9cd0f5 Restore preexisting php snippets (#182929)
That shouldn't have been deleted in #174889
And also bring back one constructor snippet
2023-05-19 02:17:56 +02:00
Matt Bierner
65123b465a Allow clickable links to absolute tsconfig extends paths (#182921)
Fixes #182898
2023-05-19 01:05:34 +02:00
David Freer
89636b9b4c PHP Snippets Quality of Life and Continuity (#174889)
* QoL & continuity update to existing php snippets

- Sorted snippets by snippet title for discoverability
- Removed all doc comments from non 'doc_' prefixed snippets
- Added doc_trait for continuity with other patterns
- Updated snippet prefixes
	- Add kvp to keyval
	- Prefixed fun with class_
	- Changed doc_param to doc_var
	- Qualified 'con' to 'constructor' to not be confused with const
- Updated class snippet to default the 'class' placeholder to the file's base name
- Add snippet choices for private, public, protected where appropriate
- Add an additional tab stop to end of functions for additional args/params
- Remove array kvps since arrays can be associative or just values

* Add try catch finally php snippet

* Add param php snippet

* Add php func snippets

- Add fun for a general function out of scope of class
- Add fun_anonymous for anonymous functions
- Add fun_arrow for arrow functions

* Add promotion style constructor to php snippets

* Add property snippet to php snippets

* Add spaceship snippet to php snippets

* Add goto snippet to php snippets

* Add class_const snippet to php snippets

* Add here/now doc snippets to php snippets

* Add namespace related snippets to php snippets

* Add superglobal snippets to php snippets

* Add php 8 snippets

- Add match expression
- Add Attribute snippets
  - Add sensitive parameter
  - Add attribute target
  - Add attribute with target
- Rename class_const to const
- Add Dynamic Property Class snippet
- Add enum snippets
  - Basic Enum
  - Backed Enum
  - foreach enum

* Merge master to resolve conflict

* Remove php snippets as candidates

- Remove heredoc
- Remove nowdoc
- Remove php super global snippets
- Remove namespace_path
- Remove ethis (echo $this->)
- Remove try/catch finally

* Trim snippets

---------

Co-authored-by: Rob Lourens <roblourens@gmail.com>
2023-05-18 14:46:36 -07:00
Matt Bierner
b11a3f7f87 Disable flaky test (#182814)
Fixes #182489
2023-05-18 13:17:51 -07:00
Matt Bierner
728197deb8 Remove some completions logic specific to old TS versions (#182894)
Removes workarounds added for TS versions that are many years old at this point
2023-05-18 11:10:31 -07:00
Joyce Er
0880f76765 Improvements to canonical URI API (#182667)
* Improve API names

* Allow requesting a specific scheme

* Implement ile uri support
2023-05-18 09:23:27 -07:00
Gabriela Araujo Britto
8457aa24b2 [typescript-language-features] Use original filterText if present (#172866)
* use original filter text, if present

* update comment
2023-05-17 22:37:11 +00:00
Matt Bierner
4d59b19b73 Enable project wide JS/TS intellisense on web by default (#182812)
Fixes #170920

Enables this feature by default but also disables semantic errors. This is needed to avoid lots of annoying false positive errors for external modules. We plan to remove this limitation once type downloading support is enabled
2023-05-18 00:06:00 +02:00
Matt Bierner
adddf406d0 Simplify buffer enums (#182811) 2023-05-18 00:01:06 +02:00
Ladislau Szomoru
46c9471450 Git - fix git status regression for git versions older than 2.18 (#182739)
* Git - fix git status regression for git versions older than 2.18

* 💄 - Tweak version number
2023-05-17 11:17:53 +02:00
Matt Bierner
bfc0808ac1 Bump TS versions (#182695)
Picks up new TS for building VS code: nightly, 5.2

Picks up new bundled TS version: last 5.1 release
2023-05-17 02:34:14 +02:00
Matt Bierner
1569f9d9d7 Don't cancel file reopen if language has changed (#182657)
Fixes #182526

The chat panel changes the language of a document. This revealed a bug in JS/TS about language changes.

Normally changing a language should close and reopen a text document. However we added an optimization to not do this full flow if the open then close happens quickly

However this causes issues if the file changes languages as TS gets into a state where its doc language id does not match VS Code's language id. To fix this, I've limited the optimization to only apply when the expected script kinds match
2023-05-16 12:28:14 -07:00
Connor Peet
8b3523a18d api: implementation of proposed window activity API (#182563)
* api: implementation of proposed window activity API

For #181569

* fix build

* fix build more

* add cell activity per @rebornix
2023-05-16 17:49:33 +02:00
Christof Marti
fb8bf97485 Remove obsolete warning (#170049) 2023-05-16 11:31:46 +02:00
Matt Bierner
7a7d45793b Allow external copying files into the workspace on markdown drop / paste (#182572)
Allow copying files in the workspace on markdown drop / paste

Fixes #157043

Also:

- Renames the markdown paste settings and makes them no longer experimental
- Makes the copyFiles setting no longer experimental
- Adds a `markdown.copyFiles.overwriteBehavior` which lets you control if/how existing files are overwritten
2023-05-15 20:17:52 -07:00
Matt Bierner
09023d824a Try to fix flaky paste tests (#182574)
These tests fail occasionally in CI, seemingly only on linux. This tries to fix this by:

- Adding retries
- Switching back to use `teardown` to disposed of things. `usingDisposable` may not clean up properly if the test times out
2023-05-15 19:56:25 -07:00
Ladislau Szomoru
b7be44e639 GitHub - fix an issue with toggling branch protection setting (#182536)
* GitHub - fix an issue with toggling branch protection setting

* 💄 Remove variable

* Pull request feedback
2023-05-15 21:03:27 +02:00
Joyce Er
2c5dcb3b81 Allow Continue On between repos with HTTPS and SSH remotes (#182352)
* Deduplicate HTTPS and SSH remote URLs

* Improve doc
2023-05-15 11:37:38 -07:00
Matt Bierner
06fc826c30 Copy paste api should not fail on invalid provider (#182535) 2023-05-15 20:24:15 +02:00
Connor Peet
ba7435efd6 Merge pull request #180263 from microsoft/connor4312/inline-remote-resolver
remote: first cut at 'inline' remote resolvers
2023-05-15 08:31:26 -07:00
Ladislau Szomoru
4981453f79 Git - fix working tree file system watcher regex (#182310) 2023-05-15 16:07:15 +02:00
Ladislau Szomoru
f47327fee9 Git - fix branch creation regression (#182504) 2023-05-15 06:57:12 -07:00
Gabriel Staples
b4368691e9 all color themes: treat comment docstrings as comments too (#182162)
* monokai-color-theme.json: treat Python comment string blocks

...as comments too

* Update *all* themes to consider Python block string comments as comments

	modified:   extensions/theme-abyss/themes/abyss-color-theme.json
	modified:   extensions/theme-defaults/themes/dark_vs.json
	modified:   extensions/theme-defaults/themes/hc_black.json
	modified:   extensions/theme-defaults/themes/hc_light.json
	modified:   extensions/theme-defaults/themes/light_vs.json
	modified:   extensions/theme-kimbie-dark/themes/kimbie-dark-color-theme.json
	modified:   extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json
	modified:   extensions/theme-monokai/themes/monokai-color-theme.json
	modified:   extensions/theme-quietlight/themes/quietlight-color-theme.json
	modified:   extensions/theme-red/themes/Red-color-theme.json
	modified:   extensions/theme-solarized-dark/themes/solarized-dark-color-theme.json
	modified:   extensions/theme-solarized-light/themes/solarized-light-color-theme.json
	modified:   extensions/theme-tomorrow-night-blue/themes/tomorrow-night-blue-color-theme.json

* Update all changes to use "string.quoted.docstring"

...instead of "string.quoted.docstring.multi.python", per
@aeschli's request here:
https://github.com/microsoft/vscode/pull/182162#issuecomment-1545296640

This way the comment formatting applies to *all* language quoted
docstrings, instead of just to Python.

* bring back python colorize tests

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2023-05-15 14:38:43 +02:00
Ladislau Szomoru
b0252732a7 Git - add similarity threshold setting (#182492) 2023-05-15 12:59:33 +02:00
Aaron Munger
89eec20d07 Merge pull request #180715 from microsoft/aamunger/scrollOutputWithKeys
keep scroll related key events in scrollable region
2023-05-12 08:50:44 -07:00
Matt Bierner
9b6b547d2d Fix range when copying empty selection (#182227)
This fixes the range extensions get when copying an empty selection. As part of this, I've also:

- Added tests for this change
- Made the paste parts of the api optional. This is useful when a test provider only wants to add data on copy
2023-05-11 17:31:11 -07:00
Matt Bierner
bf7ca503c2 Fix drop priorities for notebooks (#182209)
For copy paste, I added logic to prefer using the text content if there's both `image/*` and `text/*` content in the clipboard

This however I also incorrectly applied this logic when dropping. In those cases, we instead want to prefer the image data (at least we do in the case of dragging and dropping from VS Code's explorer)
2023-05-11 13:03:28 -07:00
Connor Peet
f76fd4f664 address pr comments 2023-05-11 12:29:42 -07:00
Aaron Munger
9ede543860 Merge branch 'main' into aamunger/scrollOutputWithKeys 2023-05-11 11:07:02 -07:00
Connor Peet
364b84e3ec Merge remote-tracking branch 'origin/main' into connor4312/inline-remote-resolver 2023-05-11 09:55:21 -07:00
Raymond Zhao
075c89881f Bump emmet-helper (#180583) 2023-05-10 16:17:58 -07:00
Aaron Munger
8f92d4b1ef Merge pull request #182117 from microsoft/aamunger/linkDetection
reduce false positive link detection
2023-05-10 15:06:07 -07:00
Peng Lyu
19545fea33 Fix isEmbeddedDiffEditor context key. (#182112)
Fix isInEmbeddedEditor context key.
2023-05-10 14:47:31 -07:00
Matt Bierner
4d38422afe Add priority to paste / drop apis (#182109)
* Add priority to paste / drop apis

Fixes #181886

Replacement for #181453

* Make notebooks prefer text over creating attachments
2023-05-10 14:18:05 -07:00
Aaron Munger
54f486aba5 Merge branch 'main' into aamunger/linkDetection 2023-05-10 14:05:53 -07:00
aamunger
2a7639b907 use look behind so whitespace is not matched 2023-05-10 13:59:44 -07:00
aamunger
5cedfd4b84 reduce false positive link detection 2023-05-10 13:33:14 -07:00
Matt Bierner
8b11c814cc Use better placeholder for move to file (#182108) 2023-05-10 12:56:25 -07:00
aamunger
2e902f0ac5 only listen for scroll events when scrolling is possible 2023-05-10 12:55:14 -07:00
Ladislau Szomoru
b4469cf109 Git - add setting to control default branch name (#181884)
* Initial implementation

* Refactor based on discussions

* More pull request feedback
2023-05-10 20:52:13 +02:00
aamunger
c56c481890 keep scroll related key events in scrollable region 2023-05-10 10:40:30 -07:00
Matt Bierner
ca51a4b04c Add paste as command (#181959)
For #30066

This command shows a quick pick that lets you select how to paste content
2023-05-10 06:17:42 -07:00
Ladislau Szomoru
4182ec739b GitHub - clear branch protection when signing out (#182053) 2023-05-10 06:16:56 -07:00
Martin Aeschlimann
32b8325159 Error while computing completions with snippets (#182007) 2023-05-10 10:14:27 +02:00
Matt Bierner
62bf9e45b6 Pick up latest TS for building VS Code and for builtin JS/TS (#181968) 2023-05-09 17:39:59 -07:00
Michael Lively
8867d20020 Remove ipynb.pasteAsAttachment setting to default to editor.pasteAs.enabled behavior (#181445)
* remove `ipynb.pasteAsAttachment` setting

* change default value to align with package.json

* Revert "remove `ipynb.pasteAsAttachment` setting"

This reverts commit 7471c030af.
2023-05-09 17:25:48 -07:00
Matt Bierner
83c12a2da2 Allow creating multiple files or attachments on paste (#181975) 2023-05-09 17:20:37 -07:00