Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-18 14:19:42 +01:00
Code Issues Packages Projects Releases Wiki Activity
157,390 Commits 3,960 Branches 364 Tags
d1e403ebbfe178ff3570f4e9d3f95bf52b806d5e
Commit Graph

282 Commits

Author SHA1 Message Date
Connor Peet 83cac60ab6 actually work 2026-05-13 20:26:23 -07:00
Connor Peet 34d208175f wip 2026-05-13 18:45:19 -07:00
Connor Peet 979d3176a2 fix CI: stable Duration ctor + drop stale doc block 2026-05-13 15:39:05 -07:00
Connor Peet 1c3ba6a284 Merge remote-tracking branch 'origin/main' into connor4312/ah-matrix 2026-05-13 15:20:44 -07:00
Connor Peet 5794a86f60 make it work 2026-05-13 15:11:50 -07:00
Connor Peet 0f960d26f1 wip: connection unification 2026-05-12 14:22:21 -07:00
Connor Peet cd73d8b686 cli: enable upgrades on proxied websocket client connection (#315802) 
The serve-web command's websocket proxy spawned the client-side hyper connection without `.with_upgrades()`, so `hyper::upgrade::on(&mut res)` rejected the upgrade with "upgrade expected but low level API in use" and the websocket failed to establish.

- Spawn `connection.with_upgrades()` in `forward_ws_req_to_server` to mirror the server side and the equivalent agent-host proxy.

Fixes https://github.com/microsoft/vscode/issues/315448

(Commit message generated by Copilot)
 2026-05-11 11:40:41 -07:00
Rob Lourens 9ea2ac02b3 Fix divide-by-zero panic in CLI unzip for small archives (#313389) 
When the archive contained fewer than 20 entries, `archive.len() / 20`
evaluated to 0 and the subsequent `i % report_progress_every` operation
panicked with 'attempt to calculate the remainder with a divisor of zero'.

Clamp the divisor to a minimum of 1.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 2026-04-30 20:39:40 -07:00
Connor Peet cdf20ffcba agentHost: improve update pickup and fix startup-failure wedge (#313541) 
- Shorten background update check interval from 24h to 6h so newly
  published server versions are picked up sooner after auto-shutdown.
- Don't store the child into self.running when it exits before signaling
  ready. Previously a failed startup left a dead child in running
  forever, wedging ensure_server() so it could never restart the server.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 2026-04-30 17:44:44 +00:00
Connor Peet 23fcb67582 agentHost: small cli polishes 
- Mark agent-host > agent as a native cli command
- Update to final tunnel URI format
- Lock to Github auth for agent host tunnels (matching agents app logic)
 2026-04-30 08:48:43 -07:00
Connor Peet ed85ff7a6c comments and more deps 2026-04-28 08:56:30 -07:00
Connor Peet 3317944fde Merge remote-tracking branch 'origin/main' into connor4312/cli-ahp-management 2026-04-28 08:35:16 -07:00
Connor Peet 2c36ddb55e cli: implement client AHP control functionality 2026-04-28 08:10:51 -07:00
Connor Peet 06db90587c cli: clean up and update dependencies 2026-04-26 19:53:35 -07:00
dependabot[bot] 7d224d9546 build(deps): bump rand from 0.8.5 to 0.9.3 in /cli (#309689) 
* build(deps): bump rand from 0.8.5 to 0.9.3 in /cli

Bumps [rand](https://github.com/rust-random/rand) from 0.8.5 to 0.9.3.
- [Release notes](https://github.com/rust-random/rand/releases)
- [Changelog](https://github.com/rust-random/rand/blob/0.9.3/CHANGELOG.md)
- [Commits](https://github.com/rust-random/rand/compare/0.8.5...0.9.3)

---
updated-dependencies:
- dependency-name: rand
  dependency-version: 0.9.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix clippy lint warnings after rand 0.8.5 → 0.9.3 upgrade

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/8e6151a9-d6c4-42c0-9e9e-e8e384b8ce48

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
 2026-04-17 10:31:19 -07:00
Connor Peet 62a503dc25 Revert "Revert build breakages (#308162)" 
This reverts commit 8aa4cf8a0f.
 2026-04-07 07:48:16 -07:00
João Moreno 8aa4cf8a0f Revert build breakages (#308162) 
* Revert "agentHost: Hook up isRead/isDone (#308107)"

This reverts commit a3d69b7767.

* Revert "agentHost: support connections over tunnels (#307948)"

This reverts commit 75f21d0a8d.
 2026-04-07 08:43:56 +00:00
Connor Peet 75f21d0a8d agentHost: support connections over tunnels (#307948) 
* wip

* clean up unused bits and make auth work correctly

* comments and fixes
 2026-04-06 16:14:01 +00:00
Raymond Zhao 167b3b89a2 Merge branch 'main' into main 2026-03-26 14:07:44 -07:00
Rob Lourens c82bc515c2 More specific log string for cli agent host proxy (#304339) 2026-03-24 14:14:44 +11:00
Connor Peet b7462b4a00 Merge pull request #303597 from microsoft/connor4312/agent-host-server-fixups 
agentHost: fixup build for server
 2026-03-20 13:54:33 -07:00
Connor Peet 5d5d0763fb fix build 2026-03-16 19:05:09 -07:00
Rob Lourens 4393d06a0f Skip quality check when VSCODE_CLI_OVERRIDE_SERVER_PATH is set and log agent host startup error 2026-03-13 15:36:45 -07:00
Connor Peet 60c18f38f6 auto updating agent host in the cli 2026-03-13 14:07:24 -07:00
Connor Peet 2da8aa0354 better command detection 2026-03-12 23:31:48 -07:00
Connor Peet 222bbd480e add agent-host command for cli 2026-03-12 23:31:40 -07:00
Dan Plischke b141217200 feat: add support for --default-folder, --default-workspace and --disable-telemetry in rust cli 2026-03-05 16:14:04 +01:00
Raymond Zhao 965d950c25 chore: run cargo update (#295062) 2026-02-13 10:58:40 -08:00
Josh Spicer 6cc2564bf9 remote: configurable 'reconnection grace time' (#274910) 
* reconnection grace period prototype

* plumb through CLI

* polish

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-12 18:51:28 -08:00
Josh Spicer b96e6d762c allow update endpoint in rs cli to be configurable by env var (#276761) 2025-11-11 10:23:39 -08:00
Justin Wang b0271fa725 Fix --commit-id flag for code serve-web (#258904) 
* Fix --commit-id flag for code serve-web

Fixes a bug where passing --commit-id during `code serve-web` would
prevent serve-web from downloading a new version of the client at all.

* Update cli/src/commands/serve_web.rs

---------

Co-authored-by: Connor Peet <connor@peet.io>
 2025-07-31 16:52:39 +00:00
Copilot 90072b47cf Fix serve-web port randomization when --port 0 is specified (#254676) 
* Initial plan

* Fix serve-web port randomization when --port 0 is specified

Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

* Fix serve-web to display actual bound port instead of 0

When --port 0 is specified, the OS assigns a random port but the
logging was showing port 0 instead of the actual assigned port.
Fixed by reading the local_addr() from the server builder after binding.

Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
 2025-07-22 13:35:24 -07:00
Justin Wang b4d1fec915 Add commit_id option to ServeWebArgs for specific client version (#255494) 
* Add commit_id option to ServeWebArgs for specific client version

* Don't start serve-web update checker if given commit-id
 2025-07-14 06:12:36 +00:00
S. M. Mohiuddin Khan Shiam 70f8e0e38f Fix incorrect SHA-1 commit regex in [version_manager.rs](cci:7://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:0:0-0:0) (#251329) 
The CLI’s `RequestedVersion::Commit` parser rejected many valid commit hashes and allowed invalid ones due to an erroneous regular expression:

* **Old pattern:** `^[a-e0-f]{40}$`
  * Allowed non-hex characters outside the `a–f` range
  * Excluded the valid hex digit `f` and any uppercase letters
* **New pattern:** [(?i)^[0-9a-f]{40}$](cci:1://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:102:1-107:2)
  * [(?i)](cci:1://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:102:1-107:2) enables case-insensitive matching (accepts `A–F`)
  * Character class now correctly restricts input to hexadecimal digits `0-9` and `a-f`
  * Ensures the string is exactly 40 characters, matching a valid SHA-1

#### Impact

`code version use <commit>` and related commands could silently fail or accept malformed commit IDs, leading to unexpected version resolution behavior.
With this fix, only valid 40-character hexadecimal commit hashes are accepted, restoring reliable version selection and preventing subtle bugs.

#### Notes

No API changes; the fix is a single-line update in [cli/src/desktop/version_manager.rs](cci:7://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:0:0-0:0).
 2025-06-13 15:40:55 +00:00
Robo 6947b69d47 fix: revert remote libcxx requirement to 3.4.25 (#248976) 
* fix: revert libcxx requirement to 3.4.25

* ci: temp debugging

* fix: use gcc 8.5.0 for remote

* ci: update cache

* ci: fix sysroot directory

* ci: fix objdump directory
 2025-05-14 20:10:32 -07:00
Robo 12326f9906 chore: update to Electron 35 (#245423) 
* chore: bump electron@35.0.1

* chore: update types/node@22.x

* chore: update web types for node v22.x

* chore: bump electron@35.1.2

* chore: update node.js build

* chore: update app.dock usage

Refs https://github.com/electron/electron/commit/71f3ff6bf289745c74d48cf54c254120a70804b4

* chore: bump electron@35.1.4

* chore: bump electron@35.1.5

* ci: bump sysroot to glibc 2.28 and gcc 10.5.0

* ci: enable timeout for smoketests

* chore: bump min glibcxx to 3.4.26 for server

* Revert "ci: enable timeout for smoketests"

This reverts commit afb637e85d.

* chore: update debian dependencies

* fix: workaround npm.ps1 argument parsing with powershell

* chore: update rpm dependencies

* test: partially revert changes from 242535

* test: remove redudant keybinding dispatch for selectTab

* test: fix test failure from running configured tasks

* test: focus settings editor for preferences.test.ts

* node - adopt compile cache (#246835)

* node - adopt compile cache

* adopt for utility process

* tweaks

* log state of compilation cache

* Revert "log state of compilation cache"

This reverts commit f3840387a583013834762e2c44f6e8424929297f.

* Revert "node - adopt compile cache (#246835)"

This reverts commit 673a00cab66c9bac87f3cd27b80efa41c80150f1.

* chore: update builds

* chore: bump electron@35.2.0

* chore: bump electron@35.2.1

* chore: bump electron@35.2.2

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
 2025-05-09 19:03:36 +09:00
Robo e9a3e2a03c fix: libc checks for exec server (#243254) 2025-03-11 12:54:24 -07:00
Robo 31ec1c528f build: remove legacy server support (#235232) 
* build: remove legacy server support

* chore: update rpm dependencies

* chore: fix publishing

* cli: provide option for unsupported glibc sysroot

* chore: add unsupported mode to prereq check

* chore: add logging

* chore: add comment about patchelf execution order
 2025-03-10 17:54:23 +01:00
Connor Peet 3331d2d87d chore: update to rust 1.85 (#242609) 2025-03-04 21:58:23 +01:00
M Hickford c515f75608 Log provider in "tunnel user show" 2025-02-11 19:53:57 +00:00
Connor Peet 90e4da155a cli: remove unsupported arguments from serve-web (#239731) 
Fixes #238303
 2025-02-05 13:20:23 -08:00
Connor Peet eee5e7643a cli: propagate server-data-dir and extensions-dir when installing service (#236734) 
Fixes #236195
 2024-12-20 10:29:40 -08:00
Connor Peet 3e86f1e6cd cli: fix serve-web needs to wait a certain amount of time after machine startup (#236427) 
Fixes #233155
 2024-12-18 01:38:47 +01:00
aslezar 386d58d0de fixed formattting error 2024-12-16 20:49:25 +05:30
aslezar 5c525a4d56 fixed formatting 2024-12-15 16:54:08 +05:30
aslezar e044a71719 Fix incorrect GLIBC version parsing 
Fixes #230370
 2024-12-13 22:22:13 +05:30
Sandeep Somavarapu 4920694ece fix #234843 (#235955) 
* fix #234843

* fix lint error
 2024-12-12 16:48:37 +01:00
benshi 4e2855ff7f Cli serve_web sets the path prefix to /<quality>-<commit>/, commit value parsing error (#233986) 
fix #233984
 2024-11-17 04:34:54 +00:00
Sandeep Somavarapu 653fd419de #232043 revert cli command and support downloading VSIX in UI (#233843) 
* Revert "fix #232043 (#233596)"

This reverts commit e9d6c6afc0.

* #232043 revert cli command and support downloading VSIX in UI
 2024-11-14 15:41:28 +01:00
Connor Peet c4efcbdfb4 cli: remove stray debug log (#233714) 2024-11-12 10:42:28 -08:00