Commit Graph

3159 Commits

Author SHA1 Message Date
Z. Grace Moreau d553d152a3 followup to renaming fish script, redux
See 90a258a & 2a81960.
2022-08-09 11:01:11 -06:00
Daniel Imms aafaebd5c1 Merge branch 'main' into fish-shell-integration 2022-08-08 15:16:14 -07:00
Benjamin Pasero e58c66c819 Issue reporter fails to report when sandbox is enabled (#157368)
issue repoter misses data
2022-08-06 10:37:34 -07:00
Peng Lyu 0f9323e411 Fix #157301. Fix process explorer scrolling (#157305) 2022-08-05 11:48:01 -07:00
Logan Ramos 46b6f3eb64 Better telemetry adblock check (#157279)
Dynamic adblock check based on telemetry setting
2022-08-05 11:20:48 -07:00
Z. Grace Moreau 95ef9dd07e add --locate-shell-integration-path CLI support 2022-08-05 11:06:36 -06:00
Benjamin Pasero 45245af3e9 smoke - disable opening devtools on error (#157080) 2022-08-04 11:16:54 +02:00
Benjamin Pasero f8ae10c8d0 Piping into Code fails if data writes delayed (fix #155341) (#156973) 2022-08-03 09:41:12 +02:00
Matt Bierner 342394d1e7 Use optional chaining for more method calls (#156938)
This rewrites code such as:

```ts
if (thing) {
    thing.method();
}
```

To the more concise:

```ts
thing?.method();
```

This was done using a simple find replace. I tried to keep the change pretty conservative so it only touches simple cases like above
2022-08-03 01:56:56 +02:00
John Murray e7426f3a73 Issue Reporter: add link to guidance on wiki (#73512) (#156139) 2022-08-02 19:33:24 +02:00
Benjamin Pasero 0fffd354d3 Sandbox: Enable on Insiders by default (fix #156440) (#156733)
* Sandbox: Enable on Insiders by default (fix #156440)

* fix tests
2022-08-02 07:18:44 +02:00
Logan Ramos cc098faebd Allow msftInternal to be setting toggled (#156198) 2022-07-25 21:01:27 -04:00
Aiday Marlen Kyzy ee903b00b7 Merge branch 'microsoft:main' into aiday/semanticScroll 2022-07-25 20:07:39 +02:00
Daniel Imms ac4d678fb9 Support --locate-shell-integration-path in server CLI (#155870)
* Fix shell-integration remote cli

* Don't silently fail based on TERM_PROGRAM

We want this to work even in terminals where TERM_PROGRAM may not exist, such
as in a regular ssh session. The manual install recommends using an if before
sourcing anyway.

* Handle shell integration option on server cli

* Move shell integration option handling higher
2022-07-25 08:39:27 -07:00
Aiday Marlen Kyzy 2b2f9f74ee Merge branch 'main' into aiday/semanticScroll 2022-07-22 22:04:54 +02:00
John Murray 8b7a0d8c25 Try to prevent update of user-type Windows installation when running as admin (#148428) (#155631)
* Try to prevent update of user-type Windows installation when running as admin (#148428)

* update win32: detect admin mode in initialize

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-07-22 16:10:53 +02:00
Sandeep Somavarapu d902fec1d2 Enhance settings profiles management (#155966)
* fix #154178

* - Support renaming profile
- Refactor profile actions

* fix compilation

* fix label
2022-07-22 15:42:52 +02:00
aiday-mar 0664facf1b Added csp policy for the sticky scroll and theme coloring 2022-07-22 14:23:19 +02:00
Daniel Imms ee636283a9 shell-integration -> locate-shell-integration-path
Part of #153921
2022-07-19 06:18:59 -07:00
Benjamin Pasero a567b593d5 introduce --merge to bring up merge editor (for #5770) (#155039)
* introduce `--merge` to bring up merge editor (for #5770)

* wait on proper editor when merging

* sqlite slowness

* disable flush on write in tests unless disk tests

* more runWithFakedTimers

* disable flush also in pfs

* introduce `IResourceMergeEditorInput`

* cleanup

* align with merge editor names

* stronger check

* adopt `ResourceSet`

* no need to coalesce

* improve `matches` method
2022-07-18 12:44:07 -04:00
Daniel Imms e1146e0a25 Merge pull request #155046 from microsoft/tyriar/si_cli
Provide simpler route for activating shell integration
2022-07-14 04:47:22 -07:00
Daniel Imms 1baeb71f07 Use TERM_PROGRAM conditional to activate 2022-07-13 07:32:24 -07:00
Daniel Imms 6763f2a996 Use common path instead of node path 2022-07-13 03:24:23 -07:00
Daniel Imms f3399f6679 Support bash and zsh paths too 2022-07-13 03:22:17 -07:00
Daniel Imms e0e5339bf7 Shell integration CLI progress 2022-07-12 12:56:42 -07:00
Sandeep Somavarapu 226911ccb2 use setting to switch between main and browser request service 2022-07-12 11:12:31 +02:00
Sandeep Somavarapu d90edae487 use request service from main 2022-07-11 15:03:04 +02:00
Sandeep Somavarapu 2a4e52e3c0 Enable profiles in web 2022-07-09 00:23:14 +02:00
Logan Ramos d6114a70be Remove app insights (#154296)
* Remove app insights

* Update product service to remove asimovKey
2022-07-06 22:23:30 -04:00
Sandeep Somavarapu cf1b75efbd Merge pull request #154256 from microsoft/sandy081/profiles-cleanup
Debt: Clean up in Profiles
2022-07-06 15:15:02 +02:00
Tyler James Leonhardt 8b475a06d9 Include if client is in unsupported mode & include restricted mode in copy (#154209) 2022-07-06 05:35:37 -07:00
Sandeep Somavarapu b94a4bf438 always include default profile in the profiles 2022-07-06 13:19:07 +02:00
Sandeep Somavarapu e4069c40f7 extract default extensions profile init and uninit
invoke it from main
2022-07-06 10:37:18 +02:00
Logan Ramos 510a74fc2c Update UTC flags properly for 1DS (#154189)
Update UTC flags properly for 1DS (#154187)

Ensure internal flag isn't applied to non internal data
2022-07-05 11:42:46 -07:00
Benjamin Pasero f4f1b04d87 Add a setting to enable sandbox: true for windows (#154062)
* sandbox - allow enabled sandbox in a full build

* sandbox - reduce `electron-browser` in workbench

* sandbox - reduce `electron-browser` in platform

* sandbox - add a setting to enable sandbox mode for window

* fix lint

* Revert "sandbox - reduce `electron-browser` in workbench"

This reverts commit 36a5167cf9.

* Revert "sandbox - reduce `electron-browser` in platform"

This reverts commit 6f49d704a5.

* fix layer issue

* fix some js errors
2022-07-05 09:54:28 +02:00
Sandeep Somavarapu c7c3174e13 Fix #153797 2022-07-01 08:32:10 +02:00
Sandeep Somavarapu ab670df24b disable profiles feature in stable quality (#153796) 2022-06-30 05:26:02 -07:00
Sandeep Somavarapu 59ca0494c8 - fix clean up logic
- fix installing other versions do not uninstall in profile mode
- add more logging
2022-06-26 02:05:23 +02:00
Sandeep Somavarapu 36f67de44f reset only map 2022-06-26 00:21:39 +02:00
Sandeep Somavarapu 2fdf21622b reset when all profiles are removed 2022-06-26 00:19:35 +02:00
Sandeep Somavarapu 94459e758e Improve extensions management in profiles
- Make version property mandatory in extension profiles (like in web)
- Extend extensions clean up to profiles
- Add necessay changes in other services to support extension cleanup:
- Introduce INativeServerExtensionManagementService
- Extend profile change event to provide added and removed profiles
2022-06-26 00:06:27 +02:00
Sandeep Somavarapu c480885fda Enable settings profiles behind experimental flag (#153044)
Enable settings profiles under experimental flag
2022-06-23 15:52:56 -07:00
Sandeep Somavarapu 1e5e1a02e8 support application scoped extensions (#152975)
* support application scoped extensions

* fix tests
2022-06-23 17:04:34 -04:00
Sandeep Somavarapu 28e9322f72 cleanup: initialize profiles when state is initiaized (#153002)
clean up:
- initialize profiles when state is initiaized
2022-06-23 17:21:28 +00:00
Sandeep Somavarapu 6d35288333 CLI: initialize state and profiles (#152994)
- create state service (readonly)  in node
- split state service between node and main
- split profiles service between node and main
- set up and init state and profiles services in cli
2022-06-23 18:37:10 +02:00
Tyler James Leonhardt fa57e29908 use new logic around nls (#152761) 2022-06-23 07:41:55 -07:00
Sandeep Somavarapu 87a6ba590a fix default profile (#152915)
- send all profiles to window and shared process
- set first profile as default profile
2022-06-23 08:57:47 +02:00
Logan Ramos 2d32e4041e Refactor telemetry appenders to reduce duplicated code (#152877)
* Reactor telemetry appenders to reduce duplicated code

* Update tsconfig

* Do not use Object.create(null) because we need object.hasOwnProperty
2022-06-22 18:25:00 -04:00
Logan Ramos 740b3f1e03 Fix telemetry not sending (#152745) 2022-06-21 14:29:29 +00:00
Joyce Er 74d7930fd1 Preserve editSessionId for protocol urls (#152669)
* Preserve `editSessionId` for protocol urls

* Always clear `editSessionId` `after applying

Avoid accidentally persisting it for unrelated workspaces

* Fix url with editSessionId query parameter not opening

* Set environmentService.editSessionId instead
2022-06-21 06:41:49 -07:00