Commit Graph

402 Commits

Author SHA1 Message Date
Matt Bierner
db02d57569 Introduce plugin config provider
Follow up on #61756

Two fixes:

- Avoid allowing the `_typescript.configurePlugin` to activate the ts extension non-lazily by instead using a `PluginConfigProvider`
- Restrict configurePlugin to TS 3.1.4
2018-10-29 14:11:28 -07:00
Mine Starks
2f18a14a5f Support configuring TypeScript plugins (#61756) 2018-10-29 13:55:52 -07:00
Matt Bierner
1476540297 Always use splice 2018-10-26 17:36:26 -07:00
Matt Bierner
221aa3d632 Introduce RequestQueueingType
Allow for finer control over how requests are queued
2018-10-26 17:36:26 -07:00
Matt Bierner
eafe48e901 Adding basic tests for request queue 2018-10-26 17:36:26 -07:00
Matt Bierner
5919eda976 Move request queue to own file 2018-10-26 17:36:25 -07:00
Matt Bierner
7363dcca25 Move callbackmap to own file 2018-10-26 17:36:25 -07:00
Matt Bierner
855d78e8a3 Move ts server into own directory 2018-10-26 17:36:25 -07:00
Matt Bierner
f4131970f6 Add isRetrigger field to signature help context
#54972

Instead of having a generic `Retrigger` reason, add a new field on the `SignatureHelpContext` that tracks if this was a retrigger or not. This allows retrigger for all the different trigger reasons, including invoke.

Replace the old `Retriggger` trigger reason with `ContentChange` which tracks cursor movement and text updates.
2018-10-25 10:38:44 -07:00
Matt Bierner
758206be09 Don't require selection for showing TS refactorings
Fixes #61655
2018-10-23 16:18:14 -07:00
Matt Bierner
b43d76887d Add more detail to disableAutomaticTypeAcquisition setting description
Fixes #60984
2018-10-17 16:22:25 -07:00
Karthikayan
f891d5a7b0 include priority in requestItem and add to request queue accordingly (#60582)
* include priority in requestItem and add to queue accordingly

* add boolean lowPriority flag to requestItem and add to queue based on that

* set lowPriority flag to optional

* send lowPriority flag from CodeLensProvider

* revert priorityFlag for provider
2018-10-17 15:21:36 -07:00
Matt Bierner
799bc78af5 Fix parameters not having commit characters
Fixes #60907
2018-10-16 17:10:43 -07:00
Ramya Achutha Rao
a975e59eaf Update applicationInsights for #60585 2018-10-16 16:29:08 -07:00
Matt Bierner
a57e7abae2 Remove deprecated js/ts completion settings
These were marked as deprecated in VS Code 1.28 and are now being removed
2018-10-15 17:39:33 -07:00
Emil Hessman
14ef4255d6 Remove duplicate switch case (#59677) 2018-10-15 16:51:35 -07:00
Matt Bierner
0cfe8a1d7e Fix potential TSC error 2018-10-08 15:24:11 -07:00
Matt Bierner
f516d17267 Add support for TS RenameTextSpan
Fixes #60204
2018-10-08 15:18:08 -07:00
Matt Bierner
2f51e97117 Add retrigger characters to SignatureHelpProvider
Introduces the concept of a re-trigger character to the signature help provider. This is a seperate set of characters that are registered with the provider. Typing a retrigger character fires a new signature help request if signature help is already showing.

#54972
2018-10-05 16:01:02 -07:00
Matt Bierner
000f027497 Formatting 2018-10-05 13:56:34 -07:00
Matt Bierner
696fc1b48e Make sure we close old resource on ts server for path updates
Fixes #53466
2018-10-05 13:55:11 -07:00
Matt Bierner
03ed0959ee Improve message on update imports prompt
Fixes #59151
2018-10-05 13:47:14 -07:00
Johannes Rieken
7d7c27cf3e less strict checking of rename locations, #58907 2018-10-03 16:49:09 +02:00
Matt Bierner
402106a699 Introduce a shared tsconfig for extensions
Setup a baseline tsconfig for extensions to extend. This will help make sure thatof our built-in extensions are using the recommended settings for target and so on. it also reduces duplicated code and will make updating tsconfig settings easier
2018-10-01 16:35:43 -07:00
Joao Moreno
707787c5b8 update yarn.lock files to use integrity 2018-09-30 16:34:43 +02:00
Matt Bierner
e20fdf9545 Signal that TS Server has loaded succesfully when any error event is received
A successful error computation more or less signals that the server is ready and is more reliable than waiting for the projectUpdatedInBackground signal
2018-09-27 11:59:58 -07:00
Matt Bierner
17cfeaf31e Add better error message about disallowed rename of directory in import path 2018-09-26 17:47:28 -07:00
Matt Bierner
29e8dcffcf Use rename cancellation token for file rename request to ts server 2018-09-26 17:47:27 -07:00
Matt Bierner
41c47d1b56 Don't rely on updatePathOnFileMove for path renames
Better fix for #51175
2018-09-26 17:32:20 -07:00
Matt Bierner
a2d3c87982 Fix file path rename for js/ts
Fixes #51175
2018-09-26 17:23:55 -07:00
Matt Bierner
f94cfe6677 Make sure javascript.updateImportsOnFileMove.enabled also has enum descriptions
Fixes #59509
2018-09-26 17:23:55 -07:00
Matt Bierner
2e95080816 Use markdownEnumDescription for all js/ts enums
Fixes #59508
2018-09-26 17:23:55 -07:00
Matt Bierner
9906ecc7a5 Disable path renames on TS 3.1
Outcome of #51175. Requires fixes upstream
2018-09-26 14:15:07 -07:00
Matt Bierner
6e9a02177a Fix fileToRename no preserving extension 2018-09-26 14:08:18 -07:00
Matt Bierner
d8ccc514f5 Remove unneeded any cast 2018-09-26 14:08:18 -07:00
Matt Bierner
f169056822 Use better name for insertParamtersForFunctionCall setting
Renamed to `completeFunctionCalls` to hopefully make it clear that this setting will also complete functions with no parameters

Fixes #59325
2018-09-26 11:53:54 -07:00
Ramya Achutha Rao
972ee3f948 Use latest applicationinsights in extensions too 2018-09-25 16:45:00 -07:00
Matt Bierner
7d359986ba Use less than for TS version checks instead of inverting greater than checks 2018-09-24 17:57:45 -07:00
Matt Bierner
484bf49abf Better fix for #58518 to avoid possible duplicated configure requests 2018-09-24 16:42:17 -07:00
Matt Bierner
58a72ab6cf Don't cache file config options until we succesfully complete a request
Fixes #58518
2018-09-24 16:42:17 -07:00
Matt Bierner
4861c344e2 Fixing tsc build tasks for project references
https://github.com/Microsoft/TypeScript/issues/27150
2018-09-24 16:18:58 -07:00
Matt Bierner
1369c6e595 Don't send @ as trigger character for ts 3.1
Fixes #59165

Workaround for https://github.com/Microsoft/TypeScript/issues/27321
2018-09-24 15:16:42 -07:00
Matt Bierner
97c753fa1f Don't treat cancellation as an error
**Problem**
In the ts server communication, canceling a request currently throws an exception. This is wrong because  cancellation is not an error. It also means that we need to wrap every server call in a generic try catch to handle cancellation. There are no checks in place to distinquish a cancellation from a rea
2018-09-20 10:59:01 -07:00
Matt Bierner
df411e9db3 Make js/ts quickfix-all action last item in group
fixes #55641
2018-09-20 10:59:01 -07:00
Johannes Rieken
5037516238 updated lock files 2018-09-20 12:06:55 +02:00
Johannes Rieken
6999ddbab7 update vscode-extension-telemetry 2018-09-20 12:06:55 +02:00
Matt Bierner
81562ab7b7 Tweak survey message 2018-09-19 17:39:30 -07:00
Matt Bierner
fd80f0de8a Don't potentially allow showing survey multiple times if user does not interact with a previously shown survey 2018-09-19 17:35:19 -07:00
Matt Bierner
f6b11178f7 Add check js survey
**Problem**
We'd like to understand the types of problems users are running into when using the checkJs feature in real world code. This is not something we can determine automatically

**Fix**
The TS team has put together a short survey that will hopefully help them understand how people are using checkJS and what problems they run into. This change adds client side logic to show the survey in the following case:

- A user as opened 10 projects that have checkJS set
- And they have not been prompted to complete the survey previously
- And they have not opted out of all js/ts surveys
2018-09-19 17:19:38 -07:00
Matt Bierner
a39679a8d0 Use results from _register directly 2018-09-19 17:19:38 -07:00