Johannes
98f0259912
chore - move isInteractiveEditorOptions into its type
2023-09-22 11:51:11 +02:00
Alex Ross
f4761fe652
Show next/previous commenting range in command palette ( #193782 )
2023-09-22 10:45:16 +01:00
Sandeep Somavarapu
685987d23a
fix #192266 ( #193781 )
2023-09-22 10:45:02 +01:00
Sandeep Somavarapu
feed93f995
fix width ( #193777 )
2023-09-22 10:30:55 +01:00
Rebecca Dodd
b8e8db96fa
Update info-needed label name in contributing doc ( #182528 )
2023-09-22 10:23:57 +01:00
Benjamin Pasero
c72447e8d8
Cannot read properties of null (reading 'b') ( fix #193773 ) ( #193774 )
2023-09-22 09:48:12 +01:00
Benjamin Simmonds
aa88e1829d
Don't show TAB_LAST_PINNED_BORDER color when all tabs are pinned ( #193762 )
...
* #193687
* dont show tab border when all sticky
2023-09-22 10:41:20 +02:00
Johannes Rieken
ffc6fdea8f
Merge pull request #193767 from microsoft/joh/disgusted-dolphin
...
WorkbenchToolBar allows to configure exemption from overflow logic
2023-09-22 10:12:03 +02:00
Johannes
b7ab7290d9
WorkbenchToolBar allows to configure exemption from overflow logic
...
fixes https://github.com/microsoft/vscode/issues/193723
2023-09-22 09:51:51 +02:00
Benjamin Pasero
e7b10fc717
editors - further improve isFirst and isLast and add test for sticky: true with index ( #193760 )
2023-09-22 09:34:28 +02:00
Benjamin Pasero
f92ee6faeb
debt - move away from generic groups accessor name ( #193707 )
...
debt - move away from generic `accessor` name
2023-09-22 09:19:10 +02:00
Benjamin Pasero
2cd6bbdb73
[Accessibility] ctrl+k, ctrl+shift+n does not open actionable notification items ( fix #193715 ) ( #193758 )
2023-09-22 07:37:57 +01:00
Ladislau Szomoru
54fc6334f5
Git - fix file decoration for history item changes ( #193755 )
2023-09-22 07:27:26 +01:00
Rob Lourens
b1ecf6f7bc
Add decorations for variables in rendered chat requests ( #193745 )
...
* Use parsed chat request in model and renderer
* Fix using variables with the chat parser
* Test snapshot
* Add test
* Update test snapshots
2023-09-22 08:19:41 +02:00
Justin Chen
444399e23b
Lets issues of the "don't know" variety be filed from the issue reporter. ( #193733 )
...
makes string value not null
2023-09-21 22:31:10 -04:00
Connor Peet
280c840f87
cli: support setting the --parent-process-id in command shell ( #193735 )
2023-09-21 15:12:02 -07:00
Matt Bierner
e2bd761d52
Adopt ensureNoDisposablesAreLeakedInTestSuite ( #193736 )
...
For #190503
2023-09-21 15:09:19 -07:00
Connor Peet
31067371f2
eng: fix snapshot tests in macos webkit for real? ( #193734 )
...
Second attempt at this, which should work. Stop trying to use
exposeFunction, which seems to work poorly on macOS webkit in CI, and
just run a server with HTTP endpoints to do the "RPC."
Reuses Alex's "yaserver" module that we were already using for other
tests. Uses a secure random prefix for security in each run.
2023-09-21 22:48:21 +01:00
Connor Peet
f92db2f96e
cli: fix renamed self-update name, cleanup old binaries
...
Fixes #192948
2023-09-21 14:37:33 -07:00
Connor Peet
4fa7137b05
cli: add more details if untar fails
...
For #192647
2023-09-21 14:37:33 -07:00
Tyler James Leonhardt
d5c2817e69
Use email for label & use label to group results in Account menu ( #193727 )
...
So, when you make a new session in the Microsoft Identity stack, depending on the scopes you pass in you might get:
* A token with a name & email
* A token with just a name
Additionally, Microsoft has like 3-4 concepts of essentially an "id" but depending on what you're trying to access, you might get a different value.
This historical behavior leads to 2 awkward things:
1. The account menu shows two accounts, one with name & email, one with just email.
2. The account menu shows two of the same accounts, but their underlying id is different
So, to fix this, we're just gonna lean on the labels. In other words, if there are two accounts that share the same label, then they will be grouped together.
The previous behavior was hurting the Azure Account folks and the Q# folks and with this change, I believe they both should be happy.
Interestingly enough, when I inherited this code, it use to do this, but I changed it to use the id as that seemed "more correct"... so it a way, this is reverting a change I did a while back.
Fixes https://github.com/microsoft/vscode/issues/184218
2023-09-21 14:09:25 -07:00
Aaron Munger
f5e97242d0
Merge pull request #193729 from microsoft/aamunger/flakyTest
...
skip flaky test
2023-09-21 13:41:21 -07:00
Megan Rogge
384201f38a
Merge pull request #193706 from microsoft/merogge/task-status-test
...
task terminal status test take 2 adoption of ensure no disposables are leaked
2023-09-21 13:23:27 -07:00
meganrogge
5064b1153c
gramatically correct
2023-09-21 12:59:55 -07:00
Aaron Munger
150d09b37b
skip flaky test
2023-09-21 12:57:28 -07:00
meganrogge
95675fae4f
use mutable disposable, rm dispose func
2023-09-21 12:16:18 -07:00
Justin Chen
85134de902
Fixes issue reporter bug with extension selection ( #193719 )
...
checks if we pre-existing extension information
2023-09-21 19:55:20 +01:00
João Moreno
4039416844
add disposableTimeout calls to disposable stores ( #193673 )
...
* add disposableTimeout calls to disposable stores
related to #193613
* fix compile error
* address feedback
2023-09-21 11:36:48 -07:00
meganrogge
4798d3a222
expose commentable help info, use in diff editor
2023-09-21 11:15:13 -07:00
meganrogge
c8869acd16
Merge branch 'main' into merogge/diff
2023-09-21 11:05:15 -07:00
Megan Rogge
df0549b866
Merge pull request #193714 from microsoft/merogge/concise-accessibility-help
...
reduce words & improve consistency in accessibility help text
2023-09-21 11:04:22 -07:00
meganrogge
ee26bfc979
reorder statement
2023-09-21 11:04:09 -07:00
Connor Peet
8730f56c09
eng: add io warmup for webkit tests in ci ( #193711 )
...
Should fix the issue that @roblourens and @Yoyokrazy were hitting with snapshot tests on macOS WebKit in CI. Not pretty, but I'd rather do this than spend a bunch of time chasing down something that certainly seems to be a browser issue.
2023-09-21 11:03:20 -07:00
Ladislau Szomoru
fdad923393
SCM - Add List/Tree view mode to the SCM Sync view ( #193696 )
...
* Add actions
* Saving my work
* Moved the actions into the '...' menu
* Automatically expand history item
* Remove unused import statement
2023-09-21 11:02:26 -07:00
meganrogge
19ea4b1c73
fix #191672
2023-09-21 10:47:45 -07:00
Ulugbek Abdullaev
384e191d8e
mapped edits: remove comments
2023-09-21 19:13:49 +02:00
Ulugbek Abdullaev
63080adeb6
mapped edits: restore backward compat
2023-09-21 19:11:58 +02:00
Ulugbek Abdullaev
4849a90efe
mapped edits: change proposed API to take a context of array of arrays of documents
2023-09-21 19:11:09 +02:00
Ulugbek Abdullaev
49dadc018d
mapped edits: implement support for getting doc ranges from InteractiveSessionProvider's
2023-09-21 19:11:08 +02:00
Ulugbek Abdullaev
95f79a91e4
refactor(chatModel):
...
* create a separate type to represent a response part
* rename existing `ResponsePart` to `InternalResponsePart`
* fix? handle if response part's resolved value is a markdown string, which is allowed in the `IResponse` interface
2023-09-21 19:09:24 +02:00
Connor Peet
029ba9ec98
eng: fix snapshot tests not working with prefix-named test ( #193709 )
...
Fixes #193632
2023-09-21 18:05:09 +01:00
Megan Rogge
6b51c974f6
Merge pull request #193708 from microsoft/merogge/mac-keybinding
...
for screen reader users, use `cmd+r` for mac `Run recent command`
2023-09-21 10:04:36 -07:00
meganrogge
c8d2ba07d4
fix #189340
2023-09-21 09:49:14 -07:00
Nathan Shively-Sanders
d534d6b441
Tweak wording and position of copilot infer-types
2023-09-21 09:36:28 -07:00
Nathan Shively-Sanders
a9a66e4dc3
Correct+customise copilot-specific titles
2023-09-21 09:25:11 -07:00
meganrogge
cd93f51433
marker has already been disposed of
2023-09-21 09:17:16 -07:00
meganrogge
c20815788f
#193676
2023-09-21 09:15:31 -07:00
Megan Rogge
2f4371e8bd
Merge pull request #193420 from microsoft/merogge/comment-help
...
add comment widget help dialog
2023-09-21 08:51:13 -07:00
troy351
a67f435467
add fallback for css var --vscode-sash-hover-size ( #187678 )
2023-09-21 16:41:33 +01:00
Nathan Shively-Sanders
32bb21550c
Merge remote-tracking branch 'origin/main' into ai-codefixes
2023-09-21 08:40:31 -07:00