Commit Graph

326 Commits

Author SHA1 Message Date
Ramya Rao
2de91fdce5 Css partial parse refactoring (#46894)
* Refactor parsePartialStylesheet

* More refactoring

* To avoid errors, parse line comments char by char and no when getting to previous line.

* Revert "To avoid errors, parse line comments char by char and no when getting to previous line."

This reverts commit f353dba4c7.

* Fix for inline comments inside block comments
2018-03-28 18:12:07 -07:00
Gus Hurovich
95b0cffe72 Fix for #46745 (#46788)
* Fix for #46745

* If { found in selector, don't partial parse.
Adding sanity checks
2018-03-27 18:32:46 -07:00
Ramya Achutha Rao
7cf6969bd0 Absorb upstream fix for #45790 2018-03-27 17:17:21 -07:00
Ramya Achutha Rao
c2dc46c1ce Offset is relative to position when finding comment 2018-03-27 12:28:20 -07:00
Ramya Achutha Rao
c07abc03f7 Avoid parsing file when abbr is invalid #43470 2018-03-27 12:12:22 -07:00
Ramya Achutha Rao
f5b569b633 Use partial parsing for stylesheets for Emmet command #43470 2018-03-27 09:51:19 -07:00
Ramya Achutha Rao
65e502e8ef Remove unused variables 2018-03-26 21:19:35 -07:00
Ramya Achutha Rao
2792b8f437 Skip emmet inside comments in stylesheets when running the command 2018-03-26 20:47:09 -07:00
Ramya Achutha Rao
4f10555e3c Skip emmet inside comments in stylesheets #46434 2018-03-26 18:30:37 -07:00
Gus Hurovich
91416ffab8 Stylesheet partial parse (#46376)
* First draft at partial parsing of css for emmet

* Partial parsing of stylesheets for Emmet

* Addressing feedback

* Refactoring and fixing little bug

* Liitle fix

* Equals are now equals

* We don't want emmet in selectors

* Skip comments when preparsing

* Addressing feedback, refactoring and cleaning up code.

* Update endPosition only if not eof

* Use function to find closing comment

* Don't check more than 5000 characters back
2018-03-26 18:14:28 -07:00
Ramya Achutha Rao
871e610848 Respect selfClosingStyle when joining tags Fixes #44417 2018-03-26 15:05:04 -07:00
Ramya Achutha Rao
9d95fbae98 Use latest emmet helper to fix #46305 2018-03-26 14:19:22 -07:00
Ramya Achutha Rao
7db6419d78 Avoid re-parsing for emmet completions when triggered for incomplete completions 2018-03-26 13:33:38 -07:00
Ramya Achutha Rao
e7ce1f53ea Do not lookahead when extracting css abbreviations Fixes #46452 2018-03-23 17:38:38 -07:00
Jean Pierre
af21dc7925 Fix for #46106 (#46309) 2018-03-22 14:19:53 -07:00
Ramya Achutha Rao
a406976823 Upstream bug fix for Fixes #44256 2018-03-14 19:13:41 -07:00
Gus Hurovich
a716373aaa Adding Live Preview for Wrapping Individual Lines with Abbreviation (#45453)
* Adding Live Preview to wrapIndividualLinesWithAbbreviation

* Refactoring

* Re-arranging code
2018-03-13 21:34:52 -07:00
Ramya Achutha Rao
fa6a57bf47 Fix emmet tests 2018-03-13 00:07:05 -07:00
Ramya Achutha Rao
6d5739d3ec Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:47:09 -07:00
Ramya Achutha Rao
9d578694d0 Validate position for emmet using best guess fixes #45634 2018-03-12 23:39:38 -07:00
Ramya Achutha Rao
b7cf44841a Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:39:25 -07:00
Gus Hurovich
16b91c78f4 Emmet: when wrapping, skip lines with no characters selected (#45224)
* When wrapping using Emmet, don't consider lines with no characters selected.

* Adding unit tests

* Adding support for multicursors in wrapIndividualLinesWithAbbreviation

* Moving check in multicursor wrapIndividualLines

* Make sure when expanding several abbreviations with different snippets that the edits are applied in reverse order.
2018-03-09 16:49:07 -08:00
Gus Hurovich
0caed6b927 Emmet in Interactive Playground (#45434)
Emmet commands will no longer appear in non-editor contexts.
2018-03-09 12:53:12 -08:00
Gus Hurovich
3817c899ca Adding Emmet preference for changing fuzzySearchMinScore (#45240)
* Adding Emmet preference for changing fuzzySearchMinScore

* Changing name and description of the new setting.

* Updating version of vscode-emmet-helper
2018-03-08 18:02:33 -08:00
Gus Hurovich
2e746d8118 Emmet - Wrap with abbreviation with live preview (#45092)
* Revert "Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)"

This reverts commit 7420a04c64.

* Adding ability for emmet to wrap with abbreviation in real time.

Currently it's only working for single cursor.

* Fixes to wrap in real time:

- Removed flickering when typing abbreviation
- Removed tabstops
- Fixed bug when wrapping multiline text

* Fixes to a few issues.

- Added checks for not reverting previews more times than needed, that was causing extra text to be deleted.
- Fixed issue when wrapping nodes with multiple level of indentation.
- Removed all the undo commands. Now all the logic of going back to the original state is handled by revertPreview.

* Ammend for previous revert

* Reapplying reverted commit, fixing the bug for this branch's version

Refactoring some of the code, now a single object contains the current and original ranges, as well as the original content to wrap

* Adding multicursor support

* Renaming, refactoring and other stuff

* More refactorings

* More renaming and refactoring

* Replacing placeholders when previewing, simplifying the extracting of preceeding whitespace, added a check for validity of expandedtext on each selection.

* More refactoring

* Adding a comment.

* Readding test removed by mistake.

* Refactoring

* Carefully reverting changes in yarn.lock

* carefully but right
2018-03-06 17:11:07 -08:00
Ramya Achutha Rao
6e1574671a Use copy of config object to avoid making changes to the readonly objects 2018-03-05 10:22:01 -08:00
Ramya Achutha Rao
4392d2efff Trigger emmet in js files on ! Fixes #43841 2018-03-02 16:22:07 -08:00
Ramya Rao
d7dca142ad Allow css emmet completions when abbr contains period Fixes #44352 (#44781)
* Allow css emmet completions when abbr contains period Fixes #44352

* Move css related workaround to cssMode #44352

* getEmbeddedParsedDocument is now not needed

* Show emmet completions everywhere inside the embedded css doc
2018-03-01 16:44:28 -08:00
Ramya Achutha Rao
ba38492bfd Add emmet icon as png #44626 2018-03-01 15:25:43 -08:00
Ramya Achutha Rao
c16869d804 Revert move of emmet to css extension Fixes #44840 2018-03-01 12:59:47 -08:00
Benjamin Pasero
9a04587cc6 Revert "Update icon for Emmet"
This reverts commit 31f3a21523.
2018-03-01 07:30:52 +01:00
Ramya Achutha Rao
31f3a21523 Update icon for Emmet 2018-02-28 11:17:56 -08:00
Ramya Achutha Rao
9c1a05e26a Update ReadMe for Emmet 2018-02-27 17:40:37 -08:00
Ramya Achutha Rao
dcbeb21cb3 Update displayName, description for Emmet #43978 2018-02-27 16:42:46 -08:00
Ramya Achutha Rao
f10b71e994 Avoid setting completion items as undefined 2018-02-26 17:52:27 -08:00
Ramya Achutha Rao
57572a12e9 Use latest emmet helper 2018-02-26 14:59:25 -08:00
Gus Hurovich
7420a04c64 Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)
* Fixing trailing spaces in expansion

* Emmet - Fixing extra spaces when wrapping with abbreviation

* Avoid fetching tag if there's no need to ezpand again

* Replacing several 'indexof's with regexp

* Making regexp for tagname stricter. Removing unnecessary check.

* Removing extra call to expand.

* tiny changes

* tinitiny changes
2018-02-14 17:08:44 -08:00
Ramya Rao
00f2d8ed71 Get emmet completions from css extension (#41652)
* Get emmet completions from html,css extensions

* Resolve extensionsPath, use emmet results even if empty

* Support css abbr with :

* Refactoring

* Add some basic emmet tests

* Refactoring

* More tests
2018-02-12 21:40:10 -08:00
Ramya Achutha Rao
bfbbe132cf Fix css emmet abbreviations with : Fixes #43544 2018-02-12 14:48:56 -08:00
Matt Bierner
308c1887df Update extensions for TS 2.7
Update src to build with TS 2.7

Explicitly assign this.message in the else body
2018-02-08 14:28:55 -08:00
gushuro
e10ce07e3a Emmet - Fixing bug in toggle comment with multi cursor (#42857)
* Fixing issue with toggleComment on multiple nested cursors

* Fix error when an edit is empty

* reordering

* adding a test for toggleComment on nested selections

* Adding test for stylesheet files

* Removing change that was making integration tests fail
2018-02-08 11:45:52 -08:00
Ramya Achutha Rao
b8a11e9349 Upstream emmet fixes 2018-02-06 17:55:40 -08:00
Dániel Tar
64b30f38c8 Stylistic and grammar fixes in Emmet messages (#42893)
* Stylistic and grammar fixes in Emmet messages

Also emphasize vendor prefixes with an apostrophe to make them stand out.

* Add missing space
2018-02-05 09:14:09 -08:00
Ramya Achutha Rao
a31d226c54 Fix emmet for sass,stylus #42904 2018-02-03 20:12:25 -08:00
Ramya Achutha Rao
611b4b365f Support vendor prefix in emmet #35951 2018-01-31 17:05:02 -08:00
Ramya Achutha Rao
02526ccf61 Semicolon is nolonger required to reset emmet 2018-01-31 17:05:01 -08:00
Ramya Achutha Rao
0155dca759 Move default vendor prefix whitelist to emmet helper 2018-01-30 14:18:38 -08:00
gushuro
3625e8f879 Adding default values for CSS vendor prefixes in emmet (#42385) 2018-01-29 21:12:11 -08:00
Ramya Achutha Rao
4f5a256a4b Allow vendor prefix in emmet #35951 2018-01-29 17:29:31 -08:00
Dirk Baeumer
e91b851ca8 Upgrade to latest language pack format 2018-01-30 00:11:57 +01:00