Commit Graph

2643 Commits

Author SHA1 Message Date
rebornix
e05b33163c Re #261. Update comments only when visible editor changes. 2018-10-11 17:05:15 -07:00
Matt Bierner
69fd947d76 Mark types as nullable where we explicitly assign something to undefined 2018-10-11 16:45:05 -07:00
Matt Bierner
29d97683a1 Add null annotations for x: T[] = null
This code pattern indicates that the type should be nullable
2018-10-11 14:25:11 -07:00
Matt Bierner
0318e90c93 Add null type annotations for the common x: T = null pattern
In these cases, the programmer has explicitly indicated that the type should be nullable
2018-10-11 14:13:20 -07:00
isidor
3f7f72dd2b debug: do not prepand DEBUG_SCHEME to paths 2018-10-11 16:16:09 +02:00
Johannes Rieken
d166c0c8ca Merge pull request #60167 from Microsoft/tyriar/58357
Stabilize active terminal APIs
2018-10-09 12:09:43 +02:00
isidor
099c23febc repl: allow to inspect repl output of inactive sessions 2018-10-09 12:08:46 +02:00
Johannes Rieken
5300bc54b4 debt - less TPromise usage 2018-10-09 10:43:43 +02:00
Johannes Rieken
291f9af174 debt - less TPromise usage 2018-10-09 10:35:13 +02:00
Daniel Imms
ab8bc96039 Stabilize active terminal APIs
Fixes #58357
2018-10-08 11:03:00 -07:00
Johannes Rieken
1580cd1846 first version of simple clipboard API, #217 2018-10-08 12:38:36 +02:00
Johannes Rieken
31f86f72bd update ParameterInformation#label in extHostTypes.ts, #56337 2018-10-08 10:27:20 +02:00
Johannes Rieken
9fa354a7aa update internal API to allow parameter label to be an offset-range of its the signature label, #56337 2018-10-08 10:22:54 +02:00
Matt Bierner
2f51e97117 Add retrigger characters to SignatureHelpProvider
Introduces the concept of a re-trigger character to the signature help provider. This is a seperate set of characters that are registered with the provider. Typing a retrigger character fires a new signature help request if signature help is already showing.

#54972
2018-10-05 16:01:02 -07:00
isidor
fac58fc8fe debug: DebugSession.getLabel() clenaup 2018-10-05 17:56:47 +02:00
isidor
aa351d8293 debug: keep repl elements per session 2018-10-05 11:52:57 +02:00
Rob Lourens
38a2c24ca2 Merge pull request #59717 from skprabhanjan/fix-59364
Fix #59364 : Respect global .gitignore when searching
2018-10-04 11:40:23 -07:00
Andre Weinand
744d94ab42 don't try to use non-existing tracker 2018-10-04 13:28:10 +02:00
Christof Marti
f523fd2036 Fire onDidHide only once (fixes #57852) 2018-10-04 13:10:18 +02:00
isidor
84f1d0d438 debug: use debug scheme when parsing paths to uris
fixes #59430
2018-10-04 11:07:12 +02:00
Matt Bierner
f7456ebf90 Switch to use standard @types/node types instead of our customized version
Using a custom version of the node typings is causing a lot of pain while trying to upgrade our build to use `@types` instead of the `d.ts` files we have to maintain. I believe we primarily maintain our own version for two reason:

- Custom require function
- setTimeout and other timer functions return NodeJs.timer instead of a number

These can both be delt with, the first by using interface augmentation and the second by switching to use any types for timer. I believe that the pain of maintaining our own node `d.ts` outweighs the benefits here

This change switches us to use the standard @types/node package for our node typings
2018-10-03 14:18:36 -07:00
Martin Aeschlimann
683a76f295 use FileDialogService with vscode APIs 2018-10-03 16:54:02 +02:00
Johannes Rieken
7d7c27cf3e less strict checking of rename locations, #58907 2018-10-03 16:49:09 +02:00
Matt Bierner
be38e56996 Remove duplicate blank lines at the start of some files 2018-10-02 16:28:19 -07:00
Matt Bierner
d4edb9abcc Remove use strict directives in main VS Code src (part 3)
We compile using the alwaysStrict flag so these directives are not needed.

This part removes most of the remaining use strict directives that were not caught by part 1 and 2
2018-10-02 16:14:11 -07:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
Matt Bierner
c63c97c128 Remove use strict directives in main vs code ts files
We compile using the alwaysStrict flag so these directives are not needed
2018-10-02 16:05:44 -07:00
Johannes Rieken
e808161b9e perf - pre-compute and cache lower case variants for label, sortText, and filterText 2018-10-02 17:46:04 +02:00
pkoushik
c4928076b7 fix #59364 - Review #2 2018-10-02 19:35:18 +05:30
Johannes Rieken
a157002380 debt - remove suggest adapter and use CompletionItemProvider from modes.ts. Also fixes https://github.com/Microsoft/monaco-editor/issues/985 2018-10-02 15:58:45 +02:00
Johannes Rieken
d00e5cb041 debt - replace CompletionItem#overwriteBefore/After with CompletionItem#range 2018-10-02 15:31:47 +02:00
Johannes Rieken
3f12ef35a8 debt - modes.ISuggestSupport becomes modes.CompletionItemProvider 2018-10-02 15:31:47 +02:00
Adam Curtis
ccb63aacfa Removed duplicate "the" from documentation. (#59736) 2018-10-01 17:30:06 -07:00
Daniel Imms
a50e3fe64d Simplify teterminal ID retry mechanism
Fixes #59765
2018-10-01 11:36:02 -07:00
Matt Bierner
d37076a596 Build VS Code using TypeScript 3.1.1
Fixes #59757
2018-10-01 10:55:16 -07:00
Christof Marti
54c51f2f23 QuickPickItem.alwaysShow (#59232) 2018-10-01 16:39:00 +02:00
Daniel Imms
5fb1e8b8b0 Merge pull request #59631 from Microsoft/tyriar/small_type
Add missing return type
2018-10-01 06:04:19 -07:00
Johannes Rieken
81b995a25d debt - less TPromise usage 2018-10-01 14:01:17 +02:00
Johannes Rieken
9e81c8f25f Revert "debt - remove declaration for WinJS.Promise#any"
This reverts commit 61a2faf7e4.
2018-10-01 12:28:52 +02:00
Johannes Rieken
9496bb79c5 debt - replace asThenable with Promise.resolve 2018-10-01 12:27:43 +02:00
Johannes Rieken
61a2faf7e4 debt - remove declaration for WinJS.Promise#any 2018-10-01 12:09:00 +02:00
Isidor Nikolic
15192ac88d Merge pull request #59617 from Microsoft/isidorn/debugStart
Isidorn/debug start
2018-10-01 11:32:11 +02:00
Isidor Nikolic
ca19bd62c6 Merge pull request #59621 from Microsoft/isidorn/panelPosition
Panel: remove the "toggle location" action in the panel header and move to menu
2018-10-01 11:31:22 +02:00
Johannes Rieken
441a5ccf0f use proper proxy declaration 2018-10-01 09:29:09 +02:00
Johannes Rieken
9435f9cbc7 use IdleValue to prevent overly eager service creation 2018-10-01 09:29:09 +02:00
Benjamin Pasero
0c4fa8a7b5 October changes (#59712)
* fix #59597

* fix #59552

* fix #57997

* Open Workspace button in .code-workspace files (fixes #59305)

* debt - filename => filepath to make method clear
2018-10-01 07:52:48 +02:00
Martin Aeschlimann
9ba00291c1 labelservice: match prefix, take longest match 2018-09-29 21:47:05 +02:00
Daniel Imms
52e9425445 Add missing return type 2018-09-28 08:29:57 -07:00
isidor
483f9cbe8e move sidebar location in sidebar title area context menu 2018-09-28 16:10:40 +02:00
isidor
f5fc1e0da6 mainThreadDebugService: adopt to success return result of debugService.startDebugging
fixes #54214
2018-09-28 15:05:53 +02:00