Tyler James Leonhardt
9b3e147d6d
GitHub Enterprise Auth improvements ( #165082 )
...
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
* UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
* misc style (`private` usage, better `disposable` handling)
2022-10-31 12:18:54 -07:00
Tyler Leonhardt
520fa49e68
refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck.
2021-08-16 16:34:21 -07:00
Tyler Leonhardt
a8134002cd
lazily load experimentation service in github-authentication
2021-07-23 09:07:41 -07:00
Tyler Leonhardt
3ed425bef9
Rework github authentication extension to make less HTTP requests.
...
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com >
2021-07-22 17:25:59 -07:00
Kevin Abel
4978a1891e
Implement GitHub Enterprise authn provider ( #115940 )
2021-05-07 14:13:11 -07:00
Rachel Macfarlane
94589129a2
Add experimentation service to github auth extension
2021-04-20 09:25:01 -07:00
Rachel Macfarlane
2f277cb41e
Add github session telemetry event
2021-02-12 15:39:04 -08:00
Rachel Macfarlane
14669c2e45
Make scopes parameter optional to getSessions and remove getAllSessions
2021-02-12 09:13:11 -08:00
Rachel Macfarlane
eceff53351
Rename login/logout to createSession/removeSession
2021-02-11 16:46:47 -08:00
Rachel Macfarlane
650906c369
Pass scopes through to authentication providers
2021-02-11 14:15:36 -08:00
Rachel Macfarlane
9118a3461c
Make onDidChangeSessions event for auth providers fire complete session
2021-02-11 10:14:28 -08:00
Rachel Macfarlane
c85297669e
Move id, label, and options to authentication provider registration
2021-01-11 10:53:17 -08:00
Rachel Macfarlane
7db413d4c1
Move secrets API to extension context
2021-01-04 22:04:40 -08:00
Rachel Macfarlane
4059ff428f
Allow cancelling GitHub sign in, fixes #109101
2020-11-05 16:39:25 -08:00
Rachel Macfarlane
31419adc34
Polish onDidChangePassword changes
2020-10-12 10:31:16 -07:00
Rachel Macfarlane
8eb9cdaba9
Fix #105955 , make sure auth provider registration completes when getSession is called
2020-09-02 11:51:59 -07:00
Rachel Macfarlane
0a30c7a64d
Add GDPR comments for auth provider telemetry
2020-07-08 11:22:21 -07:00
Rachel Macfarlane
ab7a5ec3ad
Address part of feedback for #100993
2020-07-06 08:51:24 -07:00
Rachel Macfarlane
cbb0b04d7d
Add supportsMultipleAccounts to auth providers
2020-05-11 18:32:36 -07:00
Rachel Macfarlane
b05b32bfd8
Use github auth server for provider
2020-04-27 08:10:46 -07:00
Rachel Macfarlane
87287d0275
Code cleanup, remove stuff related to sign in commands
2020-04-16 19:29:56 -07:00
Rachel Macfarlane
c63a842f00
Add basic telemetry to auth providers
2020-04-16 11:59:07 -07:00
Rachel Macfarlane
061f4967f9
Show sign in entry for all auth providers in accounts menu, fixes #94488
2020-04-13 14:28:07 -07:00
Rachel Macfarlane
ab91532466
Add 'manage trusted extensions' option to account quickpick, #90385
2020-03-27 15:38:53 -07:00
Rachel Macfarlane
d9d90a0d3d
Use GitHub app for VSO, closes #92675
2020-03-23 07:52:22 -07:00
Rachel Macfarlane
7a13028b70
Lowercase auth provider ids, fixes #91538
2020-02-26 15:06:53 -08:00
Rachel Macfarlane
eed39324b6
Add GitHub authentication provider extension, closes #90384
2020-02-20 10:56:16 -08:00
