Matt Bierner
e1f0f8f513
Add override keyword in codebase ( #120755 )
...
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Johannes Rieken
fca1144d00
remove NotebookDocument#cells in favor of cellsAt, getCells, and cellCount
2021-04-06 11:50:48 +02:00
Johannes Rieken
ca980ecfac
update notebook editor view column when moving editors, https://github.com/microsoft/vscode/issues/115704
2021-03-31 18:09:39 +02:00
Johannes Rieken
fa48622fdf
split mainThreadNotebook up into logical pieces
...
* notebookDocumentsAndEditors -> owns the truth of the notebooks and editor that extensions know about
* notebookEditor -> everything about editors
* notebookDocuments -> everything about documents
2021-03-31 15:44:31 +02:00
Johannes Rieken
d13f3b4a2f
remove NotebookContentProvider#resolveNotebook
2021-03-29 12:21:45 +02:00
Rob Lourens
961935482f
Fix build
2021-03-25 20:25:40 -07:00
Rob Lourens
33c5dbf040
Force internal execution metadata to be transient
...
Fix #119853
2021-03-25 19:58:50 -07:00
Rob Lourens
c5a8eed033
Accept array or single item for output items methods
...
#119601
2021-03-25 09:39:09 -07:00
Rob Lourens
1a425eacb8
Accept single outputs or arrays in execution task output edit methods
...
Fix #119601
2021-03-24 17:48:26 -07:00
Rob Lourens
7b96cc4c8b
Implement Execution API ( #116416 )
...
Implement new execution task API
#106744
Fix #105847
2021-03-22 11:27:00 -07:00
Johannes Rieken
7d99c47b75
move notebook save event into notebook editor model service, remove resolve/save/backup from notebook service and let editor model use content provider directly
2021-03-19 13:13:40 +01:00
Johannes Rieken
232266aaf2
first cut of IFileWorkingCopy adoption, misses saveAs and backsnapshot are improper...
2021-03-18 15:26:18 +01:00
Johannes Rieken
31283f32b2
keep notebook serializer locally
2021-03-16 14:52:24 +01:00
Johannes Rieken
2de06d768b
add INotebookSerializer interfaces and wire up IPC calls
2021-03-16 13:19:33 +01:00
Johannes Rieken
fdd57917f3
don't mixin default metadata when "replacing" notebook metadata
2021-03-11 09:16:24 +01:00
Logan Ramos
c72d7612b4
Add an untitled document data property ( #115790 )
...
* Add an untitled document data property
* Dispose of the model passed back
* Fix layer problem
* Add untitledDocumentData to untitled notebooks
* Fix compilation errors
* Switch to using VS Buffer
* Fix threading the untitled document data back through
* Prevent save dialog on untitled reopen with
* Change ignore save setting
* Change setting name and abide by preserve focus
* Add unit test
* Switch to js doc comments
* Consolidate calculating the untitled value, and added test
2021-03-10 19:54:18 +00:00
Johannes Rieken
8fd2402570
:liptstick: deep freeze notebook events before emitting them
2021-03-10 15:48:30 +01:00
Johannes Rieken
637b659e4a
refine NotebookCell API
2021-03-10 14:49:05 +01:00
Johannes Rieken
a6d7d86e85
remove viewType from openNotebookDocument call
2021-03-10 14:30:40 +01:00
Johannes Rieken
0f64ef1b65
remove NotebookDocument#contentOptions
2021-03-09 17:44:22 +01:00
Johannes Rieken
9cc276648e
remove onDidChangeCellLanguage-event in favor of the existing document closed/opened event sequence
2021-03-09 15:14:30 +01:00
Johannes Rieken
98a22a957a
declare cancellation support for openNotebook and wire it up, exempt notebook content provider from provider naming rules
2021-03-09 12:40:37 +01:00
Johannes Rieken
30d699fa10
on fire active notebook change event when something changed, https://github.com/microsoft/vscode/issues/118470
2021-03-09 11:11:17 +01:00
Johannes Rieken
230e0fdc9a
clean up, some ground work to support viewColumn, $acceptEditorPropertiesChanged must update all state before sending events, remove active notion from notebook editor
2021-03-05 17:22:06 +01:00
Johannes Rieken
68a6f1c30e
look up editor by id, slimmer dtos
2021-03-05 17:22:05 +01:00
Johannes Rieken
c024db9f41
NotebookEditorSelectionChangeEvent should contain selection ranges, not cells
2021-03-05 15:41:56 +01:00
Johannes Rieken
997c9f2930
add showNotebookDocument overload or uri
2021-03-05 14:50:47 +01:00
rebornix
ba3bd11ac7
fix kernel cache and add unit test for kernel reg.
2021-02-22 16:56:31 -08:00
rebornix
ed08a14111
selections[0] is primary.
2021-02-22 10:16:57 -08:00
rebornix
c38aa5a341
file cleaning.
2021-02-21 23:13:03 -08:00
rebornix
dea95d3e4f
map handles to cellrange in UI.
2021-02-21 22:24:20 -08:00
rebornix
de956ce8bd
differenciate selection and focus.
2021-02-21 19:35:26 -08:00
rebornix
e8966ecaa9
notebookeditor.selections
2021-02-19 17:03:33 -08:00
Johannes Rieken
3723081d63
separate vscode.NotebookEditor from ExtHostNotebookEditor
2021-02-19 17:05:25 +01:00
Johannes Rieken
e09a46e017
use document directly, not editor.document, for $acceptDocumentPropertiesChanged, fyi @rebornix
2021-02-19 15:08:43 +01:00
Johannes Rieken
4a74fa81c1
💄
2021-02-19 15:04:17 +01:00
Johannes Rieken
57cd5d4936
🪓 remove unused $acceptDisplayOrder-RPC and everything around it
2021-02-19 15:02:43 +01:00
Johannes Rieken
d240f119d4
strictness (fail fast) in extHostNotebook
2021-02-19 14:54:32 +01:00
Johannes Rieken
93ec7113e1
don't bind notebook document to a provider/extension, do then when calling backup, fixes https://github.com/microsoft/vscode/issues/117035
2021-02-19 14:54:32 +01:00
Johannes Rieken
7e7a71d733
💄 more supportsBackup removal
2021-02-19 14:54:32 +01:00
rebornix
9c77f4d86a
add NotebookDocument.save().
2021-02-18 11:57:49 -08:00
rebornix
e8836805dc
remove attachedEditors.
2021-02-18 11:56:18 -08:00
Johannes Rieken
5870204e95
make notebook and cell metadata classes, https://github.com/microsoft/vscode/issues/116333
2021-02-17 14:19:49 +01:00
rebornix
b3f8737839
fix #116808 .
2021-02-16 16:40:51 -08:00
Johannes Rieken
974b214334
rename: resolveNotebook is openNotebook
2021-02-16 14:50:57 +01:00
Johannes Rieken
5f48de03e6
use metadata classes for cell and notebook document implementation, https://github.com/microsoft/vscode/issues/116333
2021-02-15 16:54:40 +01:00
Johannes Rieken
3e2aebd790
Revert "use metadata classes inside NotebookCell and NotebookDocument"
...
This reverts commit 8848ddd9c0
2021-02-15 16:06:48 +01:00
Johannes Rieken
18c04a5716
make vscode.NotebookCellRange a class
2021-02-15 16:06:48 +01:00
Johannes Rieken
8848ddd9c0
use metadata classes inside NotebookCell and NotebookDocument
2021-02-15 15:29:33 +01:00
Johannes Rieken
196bf678a1
reset dirty state when reverting a notebook, update extension host when dirty state of a notebook (working copy) changes
2021-02-15 11:44:51 +01:00
