Commit Graph

3146 Commits

Author SHA1 Message Date
Matt Bierner
e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Daniel Imms
264ca56fe1 Rename initialText to message
Part of #120368
2021-04-07 09:20:18 -07:00
Alex Ross
b1523b435b Update port attributes api to not use array
Par of #115616
2021-04-07 12:12:34 +02:00
Daniel Imms
f8810116c6 Add terminal icon ext api
Part of #120538
2021-04-05 02:42:39 -07:00
Daniel Imms
75b9018255 Validate /etc/shells and findExecutable in unix tests 2021-04-02 05:49:53 -07:00
Daniel Imms
c8ccd07d0f Add initialText proposed API
Part of #120368
2021-04-01 12:27:13 -07:00
Alex Ross
d05d8ca4c2 Adopt async configuration resolver in Tasks
Part of #108804
2021-04-01 11:00:32 +02:00
Alex Ross
dddbfa6165 Remove process.env from tasks
Part of #108804
2021-03-30 16:55:27 +02:00
Daniel Imms
d02a4aacba Remove quick launch terminology from code
Fixes #119815
2021-03-26 09:56:20 -07:00
Martin Aeschlimann
1eb987f85f LocalizationService.update no longer needed. Fixes https://github.com/microsoft/vssaas-planning/issues/3290 2021-03-26 12:14:52 +01:00
meganrogge
ddb7709cbf Fix #119700 fix #119731 fix #119701
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-24 11:02:05 -07:00
Alex Ross
2d9069014e Add a placeholder for already forwarded root ports (#119792)
when possible
Fixes microsoft/vscode-remote-release#4749
2021-03-24 14:57:12 +01:00
Alex Ross
1b7470b25d Try to find ports with a root process (#119341)
Improves microsoft/vscode-remote-release#4654
2021-03-19 17:59:08 +01:00
Megan Rogge
e8e6d64105 Terminal profiles (#118790)
* get basics working in current dropdown

* filter profiles based on what we want in the dropdown and other info

* add copywright

* terminal.ts -> terminalProfile.ts

* seperate linux distro code

* improve terminalConfig setting description

* add passing tests and fix #79572

* add test for login args

* add wsl stuff

* fix #77652

* lengthen throttle time to 10s

* shell -> process and fire update profiles so dropdown is updated

* consolidate code in terminalProfile

* change profile selection logic

* change profile config structure

* use <ProfileName, IterminalProfileObject> and get wsl distro names to look normal

* provide terminalConfig to terminalProfiles

* move detection/validation to terminalProfiles

* isWorkspaceShellAllowed

* add quickPickOnly so Select Default Profiles returns all and otherwise filters based on config

* Add logs for errors within terminalProfiles

* change return type

* use sync

* fix bug, get custom generated to work

* workspace shell permissions

* add some comments and clean up

* when ext host ready update profiles

* improve terminalProfileObjectEqual check

* don't use windows powershell unless no other powershell
2021-03-16 17:02:59 -07:00
Andre Weinand
21d20148ee new debug setting for clearing a terminal before reusing; fixes #116699 2021-03-16 13:09:26 +01:00
Benjamin Pasero
1441ba91f0 environment - consistently handle VSCODE_CWD in all our node.js processes 2021-03-15 11:22:42 +01:00
Johannes Rieken
edf387a2e8 run filename through realpath because it seems nodejs isn't always doing that, https://github.com/microsoft/vscode/issues/118812 2021-03-12 14:17:19 +01:00
Alex Ross
da562fa27c Add regular expressions and "others" to portsAttributes
Fixes microsoft/vscode-remote-release#4623
2021-03-10 14:14:00 +01:00
Tyler James Leonhardt
27975dad4f move to IProcessEnvService where appropriate in default shell logic (#118271)
* move to IProcessEnvService where appropriate

* change distro
2021-03-08 19:46:34 -08:00
Alex Ross
06044789bf API proposal for PortAttributesProvider (#118446)
Part of #115616
2021-03-08 15:45:32 +01:00
Jackson Kearl
2ba67b7b07 Allow ripgrep search provider to work for files backed by file scheme, but not file scheme themselves (vscode-userdata) (#118069)
* Allow ripgrep search provider to work for files backed by file scheme, but not file scheme themselves (vscode-userdata)
Fixes #115434

* Only execute new code path for userData scheme

* Differentiate output channels
2021-03-03 21:13:58 -08:00
Alex Ross
f80f0d7074 More forwarded ports trace logging 2021-03-03 15:40:43 +01:00
Megan Rogge
cf3faa4046 Don't relaunch extension owned terminals (#117987)
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-02 13:55:38 -08:00
Daniel Imms
df5d7c257d Remove exthost terminal processes
Fixes #116864
2021-02-26 04:35:03 -08:00
Megan Rogge
6d0ce95af4 fix #116713 2021-02-24 17:23:19 -08:00
Megan Rogge
7130344e98 Merge branch 'main' into tyriar_megan_reconnect 2021-02-18 11:22:23 -08:00
Daniel Imms
666351b321 Merge remote-tracking branch 'origin/main' into tyriar/megan 2021-02-18 04:35:54 -08:00
Alex Ross
7a0caf4d86 Let Remote extensions set port source (#116838) 2021-02-17 10:33:46 +01:00
Megan Rogge
de9c04cae4 remove storage service, try to hook up layout info communication, bad layering also 2021-02-11 21:23:48 -08:00
Megan Rogge
68a47518f8 move things back to platform and delete duplicate code 2021-02-11 12:19:25 -08:00
Megan Rogge
a35338b250 move things back to the workbench and leave only necessary items in platform 2021-02-11 11:02:03 -08:00
Megan Rogge
da39b7af3e create PersistentTerminalProcess and move terminal and environmentVariable files from workbench -> platform 2021-02-10 15:26:05 -08:00
Daniel Imms
1abb2d9534 Merge remote-tracking branch 'origin/master' into tyriar/74620_2 2021-02-10 11:34:32 -08:00
Daniel Imms
6132a763bc Get one way communication happening 2021-02-09 04:07:38 -08:00
Daniel Imms
456841a93b Create createProcess ipc interface 2021-02-08 12:37:10 -08:00
Sandeep Somavarapu
2baf63ad00 use logger service for output appenders 2021-02-07 13:10:15 +01:00
Alex Ross
26e6d9e93a Set the remote ext host pid and name (#115891)
Fixes #115213
2021-02-05 17:00:34 +01:00
Daniel Imms
6848fcd7b0 Merge remote-tracking branch 'origin/master' into tyriar/115053 2021-02-05 07:35:58 -08:00
Martin Aeschlimann
a9b412330a remote cli: open URL: %2F lost. Fixes microsoft/vscode-remote-release#4421 2021-02-05 11:41:10 +01:00
Sandeep Somavarapu
cdc8628d55 rename log service to logger 2021-02-05 11:38:39 +01:00
Eno Yao
e9c65a7e62 Supplementary function parameter types 2021-02-05 08:17:18 +01:00
Daniel Imms
9dbc765a38 Add appDirname variable
Part of #115053
2021-02-03 07:50:58 -08:00
Benjamin Pasero
00d8115647 Merge branch 'master' into ben/modernize-fs 2021-02-03 14:29:12 +01:00
Benjamin Pasero
aca5d3ea2e fs - merge readdir functions into one 2021-02-03 12:07:48 +01:00
Benjamin Pasero
b28cd23d52 fs - more removal of promisify utility 2021-02-03 11:29:26 +01:00
Benjamin Pasero
dbf6147c01 fs - remove promise based methods from pfs and replace with fs.promises 2021-02-03 11:20:14 +01:00
Johannes Rieken
74937e0a89 Merge pull request #115530 from microsoft/joh/norpc
Hide API implementation proxies, add tests to check for "proxy leakage"
2021-02-03 09:17:56 +01:00
Benjamin Pasero
5b913c0cc2 Merge branch 'master' into ben/modernize-fs 2021-02-03 08:33:26 +01:00
Benjamin Pasero
0677d5e6f6 fs - sort pfs and introduce SymlinkSupport namespace 2021-02-02 17:33:41 +01:00
Connor Peet
3088c27fbd debug: mark terminal as free when the associated debug session ends (#115573) 2021-02-02 08:27:37 -08:00