Commit Graph

3002 Commits

Author SHA1 Message Date
Logan Ramos
e2ce6d92a9 add isPreview and group reference to tab 2022-03-18 14:15:27 -04:00
Logan Ramos
4d9393e9d3 Renamed NotebookEditorDiffTabInput 2022-03-18 12:53:55 -04:00
Logan Ramos
09ce13ef29 Bring back type import 2022-03-18 10:56:21 -04:00
Logan Ramos
482e828bb3 Update object freeze pattern 2022-03-18 10:55:46 -04:00
Johannes
464a36d785 tabs - add onDidChangeTab which fires when only a tab changes, don't fire TabGroup even for that anymore, go 180 and remove ExtHostEditorTabs again 2022-03-18 15:29:28 +01:00
Logan Ramos
1f244e76c7 Unnecessary null safety 2022-03-18 09:53:25 -04:00
Logan Ramos
3aa9892461 Fix casting 2022-03-18 09:52:41 -04:00
Johannes
c385364f5d tabs - move move into TabGroups 2022-03-18 14:35:46 +01:00
Logan Ramos
897c851383 Allow more granular configuration of telemetry through product.json (#143406)
* Allow configuration of telemetry through product.json

* Fix compilation

* Address PR comments

Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>
2022-03-18 09:33:51 -04:00
Logan Ramos
85c3df0dde Tie in tab input, remove cleanup .d.ts 2022-03-17 16:54:44 -04:00
Peng Lyu
f890d96e35 Merge pull request #145090 from microsoft/rebornix/notebook-commenting
notebook comment support
2022-03-17 12:58:59 -07:00
Logan Ramos
02f15063a0 Implement other tab inputs 2022-03-17 15:50:01 -04:00
Henning Dieterichs
1c3067895c Merge pull request #145328 from microsoft/hediet/filterTextInlineCompletions
Filter text inline completions
2022-03-17 20:17:04 +01:00
Matt Bierner
989caf1849 Remove extra type 2022-03-17 11:56:38 -07:00
Henning Dieterichs
ba356dc428 Adopt filter text in proposed extension API. 2022-03-17 19:49:55 +01:00
rebornix
14635e26ce Merge remote-tracking branch 'origin/main' into rebornix/notebook-commenting 2022-03-17 11:43:49 -07:00
Matt Bierner
41dad79edc Fix bad merge 2022-03-17 11:26:38 -07:00
Matt Bierner
bc9de9e7eb Pick up TS 4.7 for building VS Code (#145273)
Adds fixes for https://github.com/microsoft/TypeScript/issues/48276
2022-03-17 11:10:35 -07:00
Henning Dieterichs
827371128b 💄 2022-03-17 17:35:06 +01:00
Hermann Loose
f6e8ee9cca Introduce themable colors for resolved and unresolved comments (#145230)
* Make `CommentThread.state` available to `ReviewZoneWidget`

* Apply themable colors for resolved and unresolved comments

* Update color properties in comment widget

* PR feedback

Co-authored-by: Hermann Loose <hermannloose@google.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
2022-03-17 17:23:45 +01:00
Johannes
2f9632ec45 first steps towards Tab#input 2022-03-17 16:49:34 +01:00
Logan Ramos
c56ff000d4 Move close and add array support 2022-03-17 10:59:28 -04:00
Logan Ramos
1e0f8c9ba1 Re-enable vscode.open tab est 2022-03-17 10:59:27 -04:00
Johannes
b88f400ec8 tackle a todo, implement vscode.TabGroups with the ExtHostTabGroups/apiObject trick, enforce and test readonly-ness, fyi @lramos15 2022-03-17 13:01:26 +01:00
Johannes
d2336f07b7 use the correct this for active group and active tab 2022-03-17 11:12:20 +01:00
rebornix
48d8401d97 Merge remote-tracking branch 'origin/main' into rebornix/notebook-commenting 2022-03-16 19:26:12 -07:00
Matt Bierner
342e05815a Clean up few more calls to object.freeze
- Fixed explicit casts hiding some type errors on object passed to `object.freeze` (too many properties or missing properties)
- Remove some extra casts
- Fixed casts of `Object.freeze` removing readonly
2022-03-16 16:00:32 -07:00
rebornix
fe224d0d96 comment thread generics 2022-03-16 15:19:27 -07:00
Logan Ramos
a223750f17 Fix #144664 2022-03-16 16:59:11 -04:00
Logan Ramos
da52702687 Abstract ExtHostEditorTabs 2022-03-16 14:05:00 -04:00
Martin Aeschlimann
02e8bd149c Merge pull request #144759 from microsoft/aeschli/hcLightThemeKind
Add high contrast light theme kind
2022-03-16 16:41:22 +01:00
Logan Ramos
4a8f00b9c4 More work towards adopting unique tab ids 2022-03-16 09:31:15 -04:00
Jackson Kearl
2626c7f17c Fix #145135 2022-03-15 12:25:31 -07:00
Matt Bierner
f911411c46 Revert "Pick up new TS version for building VS Code"
This reverts commit cd522655a1.

This breaks some of our build scripts. Needs more work
2022-03-15 10:06:22 -07:00
Matt Bierner
cd522655a1 Pick up new TS version for building VS Code 2022-03-15 09:53:01 -07:00
Logan Ramos
ed5a545047 Fix #145111 2022-03-15 09:55:57 -04:00
Martin Aeschlimann
596181cb26 Merge branch 'main' into aeschli/hcLightThemeKind 2022-03-15 14:20:31 +01:00
Logan Ramos
6837589569 Remove TabKind.other 2022-03-14 14:55:08 -04:00
Logan Ramos
53aaa205e6 Fix #144605 2022-03-14 13:26:45 -04:00
Alexandru Dima
5f5e1ca791 Merge pull request #144840 from microsoft/alex/multiple-local-extension-hosts
Run multiple local extension hosts
2022-03-11 23:12:30 +01:00
Alex Dima
f6ad20b09a Ask all local extension hosts to resolve canonical URIs 2022-03-11 10:04:00 +01:00
Johannes
1799e12d7b for now, don't deepFreeze the onDidChangeNotebook event, https://github.com/microsoft/vscode/pull/144868, https://github.com/microsoft/vscode-jupyter/issues/9327 2022-03-11 09:21:15 +01:00
Henning Dieterichs
3626e6ab0c Adds inlineCompletionsNew and inlineCompletionsAdditions proposed APIs to avoid breaking changes when finalizing inline completions API. 2022-03-10 11:23:01 +01:00
Alex Ross
4ce5585b4c Use ext host comment value in commands (#144743)
Part of #130107
2022-03-10 10:35:56 +01:00
Alex Dima
5c20802742 Fixes #144518: Improve activation logic around handling dependencies 2022-03-09 21:42:59 +01:00
Alex Dima
d7ffa37a73 Add tests for ExtensionsActivator 2022-03-09 21:03:14 +01:00
Johannes Rieken
af79d2108d Merge branch 'main' into joh/notebookDocumentEvents 2022-03-09 08:33:16 +01:00
Sandeep Somavarapu
55c34a3df6 Fix #19561 2022-03-08 18:29:03 +01:00
Johannes Rieken
9aa84a3eb0 finalize DocumentFilter#notebookType, https://github.com/microsoft/vscode/issues/141143 2022-03-08 17:53:18 +01:00
Johannes Rieken
4e417cbc55 add tests, also an issue that the tests uncovered 2022-03-08 17:44:06 +01:00